[Maps] Update titles and descriptions for data sources#44833
Merged
nreese merged 6 commits intoelastic:masterfrom Sep 6, 2019
Merged
[Maps] Update titles and descriptions for data sources#44833nreese merged 6 commits intoelastic:masterfrom
nreese merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis |
gchaps
approved these changes
Sep 4, 2019
Contributor
gchaps
left a comment
There was a problem hiding this comment.
LGTM with one minor suggestion.
x-pack/legacy/plugins/maps/public/layers/sources/es_pew_pew_source/es_pew_pew_source.js
Outdated
Show resolved
Hide resolved
Contributor
💔 Build Failed |
…urce/es_pew_pew_source.js Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com>
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
kindsun
reviewed
Sep 5, 2019
Contributor
kindsun
left a comment
There was a problem hiding this comment.
It still feels strange to me to give such different descriptions for each of the Tilemap Service options when the real differentiation is how they're entered by the user. "Map tiles from a URL that includes the XYZ coordinates" vs. "Map tiles service configured in kibana.yml".
Contributor
Author
|
I missed the part about making TMS descriptions more consistent. Agree that making them more consistent is a worthwhile goal. How about: configured: Tile map service configured in kibana.yml |
Contributor
That works for me. I'll give it another looks as soon as you've got these updates in! |
Contributor
💚 Build Succeeded |
kindsun
approved these changes
Sep 5, 2019
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Looks much better. Thanks!
- code review
- tested in chrome
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 6, 2019
* [Maps] Update titles and descriptions for data sources * update kibana tilemap source description * Update x-pack/legacy/plugins/maps/public/layers/sources/es_pew_pew_source/es_pew_pew_source.js Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * update functional test dataTestSubj click handles based on source name changes * update TMS source descriptions to be more consistent
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Sep 6, 2019
* [Maps] Update titles and descriptions for data sources * update kibana tilemap source description * Update x-pack/legacy/plugins/maps/public/layers/sources/es_pew_pew_source/es_pew_pew_source.js Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * update functional test dataTestSubj click handles based on source name changes * update TMS source descriptions to be more consistent
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…ete-for-distance_feature * 'master' of github.com:elastic/kibana: (89 commits) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) [ML] File data viz limiting uploaded doc chunk size (elastic#44768) [code] Append go env variable 'GOCACHE' to go lsp spawn command. (elastic#44864) ...
nreese
added a commit
that referenced
this pull request
Sep 6, 2019
* [Maps] Update titles and descriptions for data sources * update kibana tilemap source description * Update x-pack/legacy/plugins/maps/public/layers/sources/es_pew_pew_source/es_pew_pew_source.js Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * update functional test dataTestSubj click handles based on source name changes * update TMS source descriptions to be more consistent
nreese
added a commit
that referenced
this pull request
Sep 6, 2019
* [Maps] Update titles and descriptions for data sources * update kibana tilemap source description * Update x-pack/legacy/plugins/maps/public/layers/sources/es_pew_pew_source/es_pew_pew_source.js Co-Authored-By: gchaps <33642766+gchaps@users.noreply.github.com> * update functional test dataTestSubj click handles based on source name changes * update TMS source descriptions to be more consistent
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 6, 2019
…plate * 'master' of github.com:elastic/kibana: (91 commits) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements copy changes from #44347
I keep the original
Web Map ServiceandTile Map Servicedescriptions because I thought the existing descriptions provided better descriptions.cc @alexfrancoeur