FTR: fix WebDriver Actions calls by dmlemeshko · Pull Request #44605 · elastic/kibana

dmlemeshko · 2019-09-02T11:52:24Z

Summary

I noticed that the same functions work different while called on browser and webElementWrapper, e.g. browser.moveMouseTo vs element.moveMouseTo. Running some of them in Firefox causes exceptions.

This PR contains the following changes:

moveMouseTo, clickMouseButton, doubleClick can be executed on WebElementWrapper instance directly
browser service should be used to do the same operation using screen coordinates (pointer)
make sure all the Webdriver Actions API related calls work properly in both Chrome (non-w3c, w3c) and Firefox (w3c)

@LeeDr I noticed that dragging Histogram bars on Discover page in Firefox returns the exact same result we got on Chrome with w3c turned on: probably the main reason behind it, is that now offset is calculated from element center box (per W3C spec) and before it was the top left corner

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-02T13:24:56Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-02T15:10:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

dmlemeshko · 2019-09-02T16:34:47Z

test/functional/apps/dashboard/dashboard_grid.js

  const PageObjects = getPageObjects(['dashboard']);

  describe('dashboard grid', function () {
-    this.tags(['skipFirefox']);


Now this test is passing in Firefox as well

dmlemeshko · 2019-09-02T16:37:01Z

test/functional/apps/discover/_discover.js

        const newDurationHours = await PageObjects.timePicker.getTimeDurationInHours();
        expect(Math.round(newDurationHours)).to.be(3);
-        const rowData = await PageObjects.discover.getDocTableIndex(1);
+        const rowData = await PageObjects.discover.getDocTableField(1);


In case of failure, we were getting a long string with all fields. To simplify analysis getDocTableField returns the date only.

dmlemeshko · 2019-09-02T16:38:48Z

test/functional/services/browser.ts

+          offset ? { x: offset.x, y: offset.y } : { x: 0, y: 0 };
+
+        if (from.location instanceof WebElementWrapper === false) {
+          throw new Error('Dragging point should be WebElementWrapper instance');


To avoid confusing while getting this error. InvalidArgumentError: invalid argument: at least an element or offset should be set │ (Session info: chrome=76.0.3809.132) │ (Driver info: chromedriver=76.0.3809.68 (420c9498db8ce8fcd190a954d51297672c1515d5-refs/branch-heads/3809@{#864}),platform=Mac OS X 10.14.6 x86_64)

In non-w3c start point should be provided as WebElement

elasticmachine · 2019-09-02T17:54:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

spalger

LGTM

…-actions-calls

elasticmachine · 2019-09-04T17:33:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

LeeDr · 2019-09-04T19:43:13Z

Running --grep 'discover test'
on Chrome browser first. Several test failures;

         └- × fail: "discover app discover test query should modify the time range when the histogram is brushed"
         │      Error: expected 'Sep 20, 2015 @ 02:53:24.492' to contain 'Sep 20, 2015 @ 02:56:02.323'

24 passing (8.0m)
1 failing

I changed my display scaling from 175% to 100% thinking this could fix the issue but it failed again with a different time;

         └- × fail: "discover app discover test query should modify the time range when the histogram is brushed"
         │      Error: expected 'Sep 20, 2015 @ 02:55:18.954' to contain 'Sep 20, 2015 @ 02:56:02.323'

This test is actually failing for me on master (on Windows, running Chrome headless) :-(

         └- × fail: "discover app discover test query should modify the time range when the histogram is brushed"
         │      Error: expected 'Sep 20, 2015 @ 02:53:24.492' to contain 'Sep 20, 2015 @ 02:56:02.323'

I could try this PR (and master) on Ubuntu and make another update here.

LeeDr · 2019-09-04T20:39:49Z

Ran the brush test on Ubuntu 18 on Chrome and it still failed;

         └- ✖ fail: "discover app discover test query should modify the time range when the histogram is brushed"
         │       Error: expected 'Sep 20, 2015 @ 02:54:25.048\n@message:34.197.178.155 - - [2015-09-20T02:54:25.048Z] "GET /uploads/daniel-bursch.jpg HTTP/1.1" 200 2609 "-" "Mozilla/4.0 (compatible; MSIE 6.

LeeDr · 2019-09-04T20:46:16Z

That brush test passed for me locally on Ubuntu when I ran it TEST_BROWSER_HEADLESS=1

elasticmachine · 2019-09-05T11:33:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

dmlemeshko · 2019-09-05T18:19:56Z

@LeeDr Since brushing test fails on Windows with master code, I think we need to address the issue in separate PR. Probably it will require additional work on window scaling size, that you already started some time ago.

I checked the code again, and I do not make any specific changes to dragNdrop in Chrome, but splitting logic to make it easy to read and support.

LeeDr

LGTM

* [services/web_element_wrapper] add actions API methods * fixes * [services/browser] fix dragAnDrop to work in both w3c/non-w3c modes * small review changes * dragAndDrop: add default values for offset

…ete-for-distance_feature * 'master' of github.com:elastic/kibana: (89 commits) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) [ML] File data viz limiting uploaded doc chunk size (elastic#44768) [code] Append go env variable 'GOCACHE' to go lsp spawn command. (elastic#44864) ...

…plate * 'master' of github.com:elastic/kibana: (91 commits) [APM] Make number of x ticks responsive to the plot width (elastic#44870) [ML] Single metric viewer: Fix top nav refresh behaviour. (elastic#44860) Replace TSVB timeseries charts with elastic-charts (elastic#33558) [TSVB][Top N aggregation] Unable to deal with negative values (elastic#43581) [alerting] Adds Action Type configuration support and whitelisting (elastic#44483) FTR: fix WebDriver Actions calls (elastic#44605) [Code] add NodeRepositoriesService to watch new repositories on local node (elastic#44677) [skip-ci][Maps] Improve Maps intro page (elastic#44721) [Maps] Update titles and descriptions for data sources (elastic#44833) Types + Extract Integration Util (elastic#44433) Downgrade log level from info to debug for cases when we cannot handle authentication attempt. (elastic#44933) [Reporting] Remove Chome stdout/stderr observables, Add Browser Logger observable (elastic#44359) Update Jest script to output coverage (elastic#44447) [ftr] support --kibana-install-dir flag (elastic#44552) [WATCHER] Allow user to set a threshold value of 0 (elastic#44810) Remove injectI18n in dashboard plugin. (elastic#44580) [Graph] Save modal (elastic#44261) Use external script for the OIDC Implicit flow handler page. (elastic#44866) disable router prefixing with pluginId (elastic#44855) [SIEM] Fix bug on url + inspect functionality on hosts/hostDetails page (elastic#44671) ...

* [services/web_element_wrapper] add actions API methods * fixes * [services/browser] fix dragAnDrop to work in both w3c/non-w3c modes * small review changes * dragAndDrop: add default values for offset

[services/web_element_wrapper] add actions API methods

a54cae1

fixes

c71d606

[services/browser] fix dragAnDrop to work in both w3c/non-w3c modes

ee7361e

dmlemeshko commented Sep 2, 2019

View reviewed changes

dmlemeshko marked this pull request as ready for review September 2, 2019 18:34

dmlemeshko requested review from LeeDr and spalger September 2, 2019 18:34

dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0 v7.3.2 v7.4.0 labels Sep 2, 2019

spalger approved these changes Sep 3, 2019

View reviewed changes

dmlemeshko added 2 commits September 4, 2019 12:45

Merge remote-tracking branch 'upstream/master' into ftr/fix-webdriver…

1ebef6c

…-actions-calls

small review changes

63d6d23

dragAndDrop: add default values for offset

2d1268e

LeeDr approved these changes Sep 5, 2019

View reviewed changes

dmlemeshko merged commit 3a158b9 into elastic:master Sep 6, 2019

dmlemeshko mentioned this pull request Sep 6, 2019

[7.x] FTR: fix WebDriver Actions calls (#44605) #44967

Merged

dmlemeshko mentioned this pull request Sep 6, 2019

[7.4] FTR: fix WebDriver Actions calls (#44605) #45000

Merged

dmlemeshko mentioned this pull request Sep 9, 2019

[7.3] FTR: fix WebDriver Actions calls (#44605) #45111

Merged

dmlemeshko deleted the ftr/fix-webdriver-actions-calls branch January 31, 2022 12:18

Conversation

dmlemeshko commented Sep 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 2, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 2, 2019

💚 Build Succeeded

Uh oh!

dmlemeshko Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

dmlemeshko Sep 2, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 2, 2019

💚 Build Succeeded

Uh oh!

spalger left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 4, 2019

💔 Build Failed

Uh oh!

LeeDr commented Sep 4, 2019

Uh oh!

LeeDr commented Sep 4, 2019

Uh oh!

LeeDr commented Sep 4, 2019

Uh oh!

elasticmachine commented Sep 5, 2019

💚 Build Succeeded

Uh oh!

dmlemeshko commented Sep 5, 2019

Uh oh!

LeeDr left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dmlemeshko commented Sep 2, 2019 •

edited

Loading