Skip to content

Update Storybook Dependencies#44519

Merged
clintandrewhall merged 2 commits intoelastic:masterfrom
clintandrewhall:storybook-deps
Aug 31, 2019
Merged

Update Storybook Dependencies#44519
clintandrewhall merged 2 commits intoelastic:masterfrom
clintandrewhall:storybook-deps

Conversation

@clintandrewhall
Copy link
Copy Markdown
Contributor

@clintandrewhall clintandrewhall commented Aug 30, 2019

Summary

This PR updates Storybook in Canvas to 5.1.11. I figured the start of 7.5 would be an opportune time to pull the trigger on this. There are a number of yarn.lock changes, but at first glance, they appear benign (e.g. core-js remains in 3.x.x). I tested this in FF and IE 11.

Other eyes on this PR would be helpful. I'm beginning to think I need to create a package.json for Storybook, or all of this will be unnecessary if/when #43529 is completed. If so, I'll punt on this update.

Checklist

@clintandrewhall clintandrewhall added review chore Team:Operations Kibana-Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// loe:small Small Level of Effort v8.0.0 release_note:skip Skip the PR/issue when compiling release notes impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. v7.5.0 labels Aug 30, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-canvas

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations

@elasticmachine

This comment has been minimized.

@spalger
Copy link
Copy Markdown
Contributor

spalger commented Aug 30, 2019

Skipped flaky test #22322

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@clintandrewhall clintandrewhall merged commit 3779931 into elastic:master Aug 31, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 2, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana: (409 commits)
  [ML] Data frame analytics: Fix source index checks. (elastic#44479)
  [Code] try fix this test (elastic#43692)
  skip flaky suite (elastic#44572) (elastic#42111) (elastic#44286) (elastic#43557) (elastic#42567)
  skip flaky suite (elastic#44560)
  skip flaky suite (elastic#44250)
  disable flaky suite (elastic#41336)
  [code] Update download URLs for go lsp. (elastic#44581)
  disable flaky suite (elastic#44575)
  disable flaky suite (elastic#44576)
  [Code] add functional test to verify lang server full api symbol/reference counts (elastic#44051)
  Improve Storybook scripts and load time (elastic#44511)
  Update Dependencies (elastic#44519)
  Remove use of injecti18n in Embeddables plugin (elastic#44043)
  [SIEM] Adds a configuraton option for the default SIEM date time range (elastic#44540)
  [Uptime]Fix/issue 40584  section headline should be inside panel (elastic#43468)
  disable flaky suite (elastic#22322)
  Changes network to use ECS fields (elastic#44392)
  Fix 'workpad flash' when loading new workpad (elastic#44387)
  [renovate] bump new PR version labels
  Update dependency cmd-shim to ^2.1.0 (elastic#44034)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/index.html
clintandrewhall added a commit that referenced this pull request Sep 5, 2019
* Merging again

* Updated yarn.lock

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>


Co-authored-by: Tyler Smalley <tyler.smalley@elastic.co>
@clintandrewhall clintandrewhall deleted the storybook-deps branch September 18, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Operations Kibana-Operations Team Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants