[Code] add functional test to verify lang server full api symbol/reference counts#44051
Merged
mw-ding merged 2 commits intoelastic:masterfrom Sep 1, 2019
mw-ding:index-status
Merged
[Code] add functional test to verify lang server full api symbol/reference counts#44051mw-ding merged 2 commits intoelastic:masterfrom mw-ding:index-status
mw-ding merged 2 commits intoelastic:masterfrom
mw-ding:index-status
Conversation
Contributor
|
Pinging @elastic/code |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
zfy0701
reviewed
Aug 28, 2019
Contributor
There was a problem hiding this comment.
actually, the count here should be different than the one we have in kibana repo, because we should have java langserver installed here, thus we should see more symbols
Contributor
Author
There was a problem hiding this comment.
this one is right. the one in the integration test need to be updated.
Contributor
💔 Build Failed |
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@zfy0701 ping |
zfy0701
approved these changes
Aug 31, 2019
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 2, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (409 commits) [ML] Data frame analytics: Fix source index checks. (elastic#44479) [Code] try fix this test (elastic#43692) skip flaky suite (elastic#44572) (elastic#42111) (elastic#44286) (elastic#43557) (elastic#42567) skip flaky suite (elastic#44560) skip flaky suite (elastic#44250) disable flaky suite (elastic#41336) [code] Update download URLs for go lsp. (elastic#44581) disable flaky suite (elastic#44575) disable flaky suite (elastic#44576) [Code] add functional test to verify lang server full api symbol/reference counts (elastic#44051) Improve Storybook scripts and load time (elastic#44511) Update Dependencies (elastic#44519) Remove use of injecti18n in Embeddables plugin (elastic#44043) [SIEM] Adds a configuraton option for the default SIEM date time range (elastic#44540) [Uptime]Fix/issue 40584 section headline should be inside panel (elastic#43468) disable flaky suite (elastic#22322) Changes network to use ECS fields (elastic#44392) Fix 'workpad flash' when loading new workpad (elastic#44387) [renovate] bump new PR version labels Update dependency cmd-shim to ^2.1.0 (elastic#44034) ... # Conflicts: # src/legacy/core_plugins/console/public/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
https://github.com/elastic/code/issues/1563
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers