Skip to content

Remove use of injecti18n in Embeddables plugin#44043

Merged
stacey-gammon merged 3 commits intoelastic:masterfrom
stacey-gammon:2019-08-26-no-inject18N-2
Aug 31, 2019
Merged

Remove use of injecti18n in Embeddables plugin#44043
stacey-gammon merged 3 commits intoelastic:masterfrom
stacey-gammon:2019-08-26-no-inject18N-2

Conversation

@stacey-gammon
Copy link
Copy Markdown

@stacey-gammon stacey-gammon commented Aug 26, 2019

Update to recommended usage of localization, using i18n.translate instead of injected intl prop.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 26, 2019

Pinging @elastic/kibana-app-arch

@stacey-gammon stacey-gammon added the release_note:skip Skip the PR/issue when compiling release notes label Aug 26, 2019
@stacey-gammon stacey-gammon requested a review from Bamieh August 26, 2019 21:33
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 26, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 27, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 27, 2019

💚 Build Succeeded

@stacey-gammon stacey-gammon force-pushed the 2019-08-26-no-inject18N-2 branch from 8a97e64 to 0d354d6 Compare August 29, 2019 21:19
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 29, 2019

💔 Build Failed

@stacey-gammon stacey-gammon force-pushed the 2019-08-26-no-inject18N-2 branch from 0d354d6 to edcd33a Compare August 30, 2019 15:16
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 30, 2019

💔 Build Failed

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 30, 2019

Don't think the failures are related:

11:33:12 Output:
11:33:12 Current existing ChromeDriver binary is unavailable, proceding with download and extraction.
11:33:12 Downloading from file:  https://us-central1-elastic-kibana-184716.cloudfunctions.net/kibana-ci-proxy-cache/76.0.3809.68/chromedriver_linux64.zip
11:33:12 Saving to file: /tmp/76.0.3809.68/chromedriver/chromedriver_linux64.zip
11:33:12 ChromeDriver installation failed Error with http(s) request: Error: connect ETIMEDOUT 172.217.214.128:80
11:33:12 
11:33:12 [bootstrap] failed:
11:33:12 
11:33:12 Error: Command failed: yarn install --non-interactive --prefer-offline
11:33:12     at makeError (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-ciGroup2/node/linux-immutable/kibana/packages/kbn-pm/dist/index.js:19129:9)
11:33:12     at Promise.all.then.arr (/var/lib/jenkins/workspace/elastic+kibana+pull-request/JOB/kibana-ciGroup2/node/linux-immutable/kibana/packages/kbn-pm/dist/index.js:19233:16)
11:33:12     at process._tickCallback (internal/process/next_tick.js:68:7)
11:33:12 info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
11:33:12 error Command failed with exit code 1.

retest

streamich
streamich approved these changes Aug 30, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I wanted to do the same.

Curious if there is any benefit of using injectI18n HOC as we do not re-render the application automatically when language changes.

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 30, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 30, 2019

💔 Build Failed

@stacey-gammon
Copy link
Copy Markdown
Author

stacey-gammon commented Aug 31, 2019

Different failure this time, X-Pack API Integration Tests.x-pack/test/api_integration/apis/code/repo_status·ts.apis Code repo status

@stacey-gammon stacey-gammon force-pushed the 2019-08-26-no-inject18N-2 branch from edcd33a to 465864a Compare August 31, 2019 12:53
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 31, 2019

💚 Build Succeeded

@stacey-gammon stacey-gammon merged commit 892728e into elastic:master Aug 31, 2019
stacey-gammon pushed a commit to stacey-gammon/kibana that referenced this pull request Aug 31, 2019
Remove use of injecti18n in Embeddables plugin (elastic#44043)
48007a4 
* remove use of injecti18n

* fix jest tests and typescript errors

* Fix more jest tests
@stacey-gammon stacey-gammon mentioned this pull request Aug 31, 2019
Merged
@sainthkh sainthkh mentioned this pull request Sep 2, 2019
Merged
5 tasks
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 2, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into chore/console…
a6b8750 
…-to-np-ready

* 'master' of github.com:elastic/kibana: (409 commits)
  [ML] Data frame analytics: Fix source index checks. (elastic#44479)
  [Code] try fix this test (elastic#43692)
  skip flaky suite (elastic#44572) (elastic#42111) (elastic#44286) (elastic#43557) (elastic#42567)
  skip flaky suite (elastic#44560)
  skip flaky suite (elastic#44250)
  disable flaky suite (elastic#41336)
  [code] Update download URLs for go lsp. (elastic#44581)
  disable flaky suite (elastic#44575)
  disable flaky suite (elastic#44576)
  [Code] add functional test to verify lang server full api symbol/reference counts (elastic#44051)
  Improve Storybook scripts and load time (elastic#44511)
  Update Dependencies (elastic#44519)
  Remove use of injecti18n in Embeddables plugin (elastic#44043)
  [SIEM] Adds a configuraton option for the default SIEM date time range (elastic#44540)
  [Uptime]Fix/issue 40584  section headline should be inside panel (elastic#43468)
  disable flaky suite (elastic#22322)
  Changes network to use ECS fields (elastic#44392)
  Fix 'workpad flash' when loading new workpad (elastic#44387)
  [renovate] bump new PR version labels
  Update dependency cmd-shim to ^2.1.0 (elastic#44034)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/index.html
stacey-gammon pushed a commit that referenced this pull request Sep 2, 2019
Remove use of injecti18n in Embeddables plugin (#44043) (#44561)
bddb3ae 
* remove use of injecti18n

* fix jest tests and typescript errors

* Fix more jest tests
@sainthkh sainthkh mentioned this pull request Sep 18, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Awaiting requested review from Bamieh

1 more reviewer

@streamich streamich streamich approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stacey-gammon @elasticmachine @streamich