Fix 'workpad flash' when loading new workpad#44387
Merged
clintandrewhall merged 3 commits intoelastic:masterfrom Aug 30, 2019
Merged
Fix 'workpad flash' when loading new workpad#44387clintandrewhall merged 3 commits intoelastic:masterfrom
clintandrewhall merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-canvas |
Contributor
💔 Build Failed |
Member
|
@elasticmachine run elasticsearch-ci/docs |
snide
approved these changes
Aug 29, 2019
Contributor
snide
left a comment
There was a problem hiding this comment.
SCSS changes are minor and moves. Did not test functionality.
Contributor
💔 Build Failed |
Contributor
Author
|
jenkins test this |
Contributor
💔 Build Failed |
cqliu1
approved these changes
Aug 30, 2019
Contributor
💚 Build Succeeded |
clintandrewhall
added a commit
that referenced
this pull request
Aug 30, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Sep 2, 2019
…-to-np-ready * 'master' of github.com:elastic/kibana: (409 commits) [ML] Data frame analytics: Fix source index checks. (elastic#44479) [Code] try fix this test (elastic#43692) skip flaky suite (elastic#44572) (elastic#42111) (elastic#44286) (elastic#43557) (elastic#42567) skip flaky suite (elastic#44560) skip flaky suite (elastic#44250) disable flaky suite (elastic#41336) [code] Update download URLs for go lsp. (elastic#44581) disable flaky suite (elastic#44575) disable flaky suite (elastic#44576) [Code] add functional test to verify lang server full api symbol/reference counts (elastic#44051) Improve Storybook scripts and load time (elastic#44511) Update Dependencies (elastic#44519) Remove use of injecti18n in Embeddables plugin (elastic#44043) [SIEM] Adds a configuraton option for the default SIEM date time range (elastic#44540) [Uptime]Fix/issue 40584 section headline should be inside panel (elastic#43468) disable flaky suite (elastic#22322) Changes network to use ECS fields (elastic#44392) Fix 'workpad flash' when loading new workpad (elastic#44387) [renovate] bump new PR version labels Update dependency cmd-shim to ^2.1.0 (elastic#44034) ... # Conflicts: # src/legacy/core_plugins/console/public/index.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #29956.
The workpad state is not "reset" when visiting the home page of Canvas. As a result, the previously-loaded workpad stays active until the user chooses another workpad to load. When the do so, the previous workpad "flashes" in place before the next is loaded. This has some awkward consequences, including re-saving the newly-loaded workpad, (because the persist middleware catches the change in workpad), and the link to load the previously-loaded workpad is bold, which is a feature reserved for the loading workpad dialog, not the home page.
This fix resets the workpad state back to the "default" workpad when visiting the home page. It also instructs the persist middleware to ignore
resetWorkpadas well asappReady, (why persist the workpad when the app just loaded?)