[Discover] [Metrics] Add tier 2 journeys for Metrics in Discover E2E by justinkambic · Pull Request #255036 · elastic/kibana

justinkambic · 2026-02-26T02:54:41Z

Summary

Related to https://github.com/elastic/observability-dev/issues/5219.

Implements Tier 2 E2E coverage for Discover Metrics journeys, aligned with the existing metrics_experience test architecture and config pattern.

Adds two new parallel Scout specs in metrics_experience:

query_kickstart.spec.ts: validates recommended-query kickstart behavior from the ES|QL help flow, with environment-aware handling when Search all metrics is unavailable and Search all fields is shown.
breakdown_by_dimension.spec.ts: validates that selecting “Breakdown by dimension” from the field list is reflected in the metrics toolbar and preserves metrics grid rendering.

This patch introduces coverage for the two unblocked journeys, but does not yet implement the "switch between tabs" third journey, which is blocked by #251637.

Test Plan

Validated via Scout metrics parallel config:

node scripts/scout.js run-tests --arch stateful --domain classic --config src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts

Result on latest run:

All tests pass: 36 passed, 8 skipped, 0 failed. Exit code 0.

…eakdown flow. Add metrics-experience Scout coverage for ES|QL recommended-query kickstart and field-list breakdown-by-dimension journeys. Extend Scout page objects/constants with stable helpers and selectors so the new tests run reliably across the metrics parallel suite.

lucaslopezf · 2026-02-26T07:33:48Z

Thanks Justin!! Just FYI: I've marked the task as blocked by this PR
to avoid too many conflicts or duplicate work (it’s ready, but I’m pending resolution of this, which is the more important one, and I’m also expecting feedback from the AppEx team). Besides that, we can move forward with this PR since I don’t see many conflicts later, but only after merging the flaky one, as I believe it’s a common issue affecting the entire E2E metrics stack

…-coverage

…ibility in metrics experience tests

…-coverage

- Moved recommended ESQL query handling and sidebar breakdown field methods from DiscoverApp to DiscoverActions for better separation of concerns. - Updated tests to utilize the new DiscoverActions class for running recommended queries and adding breakdown fields. - Ensured that the DiscoverActions class is properly integrated into the existing test fixtures and page objects.

…-coverage

- Removed fallback query handling from the runRecommendedEsqlQuery method for simplification. - Updated related tests to reflect the changes in the query execution logic. - Cleaned up constants by removing unused SEARCH_ALL_FIELDS_FALLBACK label. This refactor enhances the clarity and maintainability of the code.

elasticmachine · 2026-03-10T15:27:29Z

Pinging @elastic/obs-exploration-team (Team:obs-exploration)

lucaslopezf · 2026-03-10T15:30:02Z

/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-03-10T15:30:36Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11041

src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts x30

justinkambic · 2026-03-10T16:49:44Z

I pushed a change that I thought was minor but seems to have broken the test. Working on a fix, will push again soon.

...s/shared/discover/test/scout/ui/fixtures/metrics_experience/page_objects/discover_actions.ts

kibanamachine · 2026-03-10T17:13:34Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11041

[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 0/30 tests passed.

see run history

- Introduced RECOMMENDED_QUERY_TAGS constant to enhance query handling. - Updated DiscoverActions to include a timeout for query visibility checks. - Modified query_kickstart.spec to utilize the new RECOMMENDED_QUERY_TAGS for improved test accuracy.

justinkambic · 2026-03-10T17:28:26Z

/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-03-10T17:28:43Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11045

src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts x30

kibanamachine · 2026-03-10T18:41:53Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11045

[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 0/30 tests passed.

see run history

- Updated the test for Search

kibanamachine · 2026-03-17T23:36:45Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11138

src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts x30

kibanamachine · 2026-03-18T00:50:09Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11138

[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 23/30 tests passed.

see run history

justinkambic · 2026-03-18T02:07:43Z

This PR is failing the flaky test runner. It looks like the majority of the failures took place due to grid.spec.ts.

Failure example.

setCommonlyUsedTime does not wait for the search to finish after changing the time range. When Discover re-executes the ES|QL query, fetchParams.timeRange changes, triggering useFetchMetricsData to call executeFetch().

The useAsyncFn hook (from react-use) resets value to undefined when a new async call begins.
This causes metricItems to become [] (via value?.metricItems ?? [] at line 109 of use_fetch_metrics_data.ts).
In MetricsExperienceGrid (line 117), the condition metricItems.length === 0 && isDiscoverLoading becomes true.
The grid is completely unmounted from the DOM and replaced with <EmptyState>.
The default 10s Playwright timeout is insufficient for the re-fetch to complete in CI.

We did not modify this file as part of this set of changes. Should I try to modify the file in here to prevent the flakiness?

justinkambic · 2026-03-18T02:10:12Z

/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-03-18T02:10:30Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11140

src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts x30

kibanamachine · 2026-03-18T03:27:10Z

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11140

[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 26/30 tests passed.

see run history

lucaslopezf · 2026-03-18T10:21:14Z

/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-03-18T10:21:29Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11145

src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts x30

lucaslopezf · 2026-03-18T10:23:33Z

This PR is failing the flaky test runner. It looks like the majority of the failures took place due to grid.spec.ts.

Failure example.

setCommonlyUsedTime does not wait for the search to finish after changing the time range. When Discover re-executes the ES|QL query, fetchParams.timeRange changes, triggering useFetchMetricsData to call executeFetch().

The useAsyncFn hook (from react-use) resets value to undefined when a new async call begins.

This causes metricItems to become [] (via value?.metricItems ?? [] at line 109 of use_fetch_metrics_data.ts).

In MetricsExperienceGrid (line 117), the condition metricItems.length === 0 && isDiscoverLoading becomes true.

The grid is completely unmounted from the DOM and replaced with <EmptyState>.

The default 10s Playwright timeout is insufficient for the re-fetch to complete in CI.

We did not modify this file as part of this set of changes. Should I try to modify the file in here to prevent the flakiness?

Not related with this PR, fixed here

kibanamachine · 2026-03-18T11:47:20Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11145

[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 30/30 tests passed.

see run history

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/discover_app.ts

…-coverage

…bana into 5219/e2e-tier-2-coverage

…queries - Removed unnecessary visibility check for the panel title button. - Simplified the wait for the panel title button to use a direct locator call. - Improved code clarity and efficiency in handling recommended queries.

- Removed unnecessary visibility check for the breakdown button. - Streamlined the process of clicking on fields and handling the field popover. - Improved code clarity and efficiency in the Discover app's interaction logic.

elasticmachine · 2026-03-18T16:08:38Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 256f8b2

Failed CI Steps

Scout: [ platform / discover ] plugin

Metrics [docs]

✅ unchanged

History

💛 Build #411974 was flaky e42c845
💔 Build #411791 failed e348328
💛 Build #411714 was flaky 3419d5e
💛 Build #411641 was flaky 4b325c1
💔 Build #411389 failed f62e6fd
💔 Build #411066 failed c3ea75f

cc @justinkambic

justinkambic · 2026-03-18T16:58:55Z

/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30

kibanamachine · 2026-03-18T16:59:14Z

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11161

src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts x30

kibanamachine · 2026-03-18T18:36:26Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11161

[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 30/30 tests passed.

see run history

…d_agent_navigation2 * commit '9289d6b5502db245e645e190b0246554396c6c20': (34 commits) [api-docs] 2026-03-19 Daily api_docs build (elastic#258471) [Shared UX][DateRangePicker] Missing parts (elastic#258229) [Dashboard] Keep pinned_panels separate in read response (elastic#258444) Move inheritance: true to top level in .coderabbit.yml (elastic#258461) [DOCS] 9.3.2 Kibana release notes (elastic#257332) adds routing accept metric attribute to the cps metric (elastic#258168) [ML] AI/Inference Connector creation: use 'location' field to correctly set provider config (elastic#250838) [Lens] Add e2e test for legend list layout (elastic#258160) [SigEvents] Convert feature duplication evaluators to createPrompt pattern (elastic#256534) Add actionable-obs author to .coderabbit.yml (elastic#257922) [DOCS] 9.2.7 Kibana release notes (elastic#257331) Grant Serverless editor/viewer access to ES v2 indices (elastic#258384) [SigEvents][Evals] Rename terminology for KI features and KI queries (elastic#258361) [EDR Workflows][Osquery] Add shared table toolbar components and redesign saved queries list (elastic#258394) [Automatic Import V2] Upload samples using an existing index (elastic#258074) Add GET /inference_features route to expose feature registry (elastic#258044) fix additional fields not included (elastic#257625) [Discover] [Metrics] Add tier 2 journeys for Metrics in Discover E2E (elastic#255036) [Lens as code] Support correct X-Axis types in ES|QL visualizations (elastic#258159) Update APM (main) (elastic#254880) ...

…lastic#255036) ## Summary Related to elastic/observability-dev#5219. Implements Tier 2 E2E coverage for Discover Metrics journeys, aligned with the existing metrics_experience test architecture and config pattern. Adds two new parallel Scout specs in metrics_experience: - `query_kickstart.spec.ts`: validates recommended-query kickstart behavior from the ES|QL help flow, with environment-aware handling when Search all metrics is unavailable and Search all fields is shown. - `breakdown_by_dimension.spec.ts`: validates that selecting “Breakdown by dimension” from the field list is reflected in the metrics toolbar and preserves metrics grid rendering. This patch introduces coverage for the two unblocked journeys, but does not yet implement the "switch between tabs" third journey, which is blocked by elastic#251637. ## Test Plan Validated via Scout metrics parallel config: ``` node scripts/scout.js run-tests --arch stateful --domain classic --config src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts ``` Result on latest run: ``` All tests pass: 36 passed, 8 skipped, 0 failed. Exit code 0. ``` --------- Co-authored-by: Lucas Francisco López <lucaslopezf@gmail.com>

justinkambic self-assigned this Feb 26, 2026

justinkambic added release_note:skip Skip the PR/issue when compiling release notes backport:version Backport to applied version labels Team:obs-exploration Observability Exploration team v9.4.0 labels Feb 26, 2026

justinkambic added 9 commits March 2, 2026 13:40

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

3c44d31

…-coverage

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

817dea7

…-coverage

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

4f020b2

…-coverage

Update ESQL query submission method and adjust breakdown selector vis…

c5cd05b

…ibility in metrics experience tests

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

01b2d0c

…-coverage

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

ba24dac

…-coverage

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

0b5213a

…-coverage

justinkambic marked this pull request as ready for review March 10, 2026 15:27

justinkambic requested a review from a team as a code owner March 10, 2026 15:27

lucaslopezf reviewed Mar 10, 2026

View reviewed changes

...s/shared/discover/test/scout/ui/fixtures/metrics_experience/page_objects/discover_actions.ts Outdated Show resolved Hide resolved

justinkambic force-pushed the 5219/e2e-tier-2-coverage branch from 300941d to 9d54490 Compare March 10, 2026 17:27

Refactor query_kickstart.spec to enhance test clarity and functionality

832e0d7

- Updated the test for Search

Merge branch 'main' into 5219/e2e-tier-2-coverage

e348328

elastic deleted a comment from kibanamachine Mar 18, 2026

Merge branch 'main' into 5219/e2e-tier-2-coverage

e42c845

steliosmavro reviewed Mar 18, 2026

View reviewed changes

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/discover_app.ts Outdated Show resolved Hide resolved

src/platform/packages/shared/kbn-scout/src/playwright/page_objects/discover_app.ts Outdated Show resolved Hide resolved

justinkambic added 4 commits March 18, 2026 10:34

Merge branch 'main' of github.com:elastic/kibana into 5219/e2e-tier-2…

6e3262f

…-coverage

Merge branch '5219/e2e-tier-2-coverage' of github.com:justinkambic/ki…

48fcccd

…bana into 5219/e2e-tier-2-coverage

refactor(discover_app): simplify field interaction logic

256f8b2

- Removed unnecessary visibility check for the breakdown button. - Streamlined the process of clicking on fields and handling the field popover. - Improved code clarity and efficiency in the Discover app's interaction logic.

justinkambic requested a review from steliosmavro March 18, 2026 15:44

steliosmavro approved these changes Mar 18, 2026

View reviewed changes

justinkambic merged commit da2bcdd into elastic:main Mar 18, 2026
18 checks passed

kibanamachine added backport:skip This PR does not require backporting and removed backport:version Backport to applied version labels labels Mar 18, 2026

Conversation

justinkambic commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Uh oh!

lucaslopezf commented Feb 26, 2026

Uh oh!

elasticmachine commented Mar 10, 2026

Uh oh!

lucaslopezf commented Mar 10, 2026

Uh oh!

kibanamachine commented Mar 10, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11041

Uh oh!

justinkambic commented Mar 10, 2026

Uh oh!

Uh oh!

kibanamachine commented Mar 10, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11041

Uh oh!

justinkambic commented Mar 10, 2026

Uh oh!

kibanamachine commented Mar 10, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11045

Uh oh!

kibanamachine commented Mar 10, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11045

Uh oh!

kibanamachine commented Mar 17, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11138

Uh oh!

kibanamachine commented Mar 18, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11138

Uh oh!

justinkambic commented Mar 18, 2026

Uh oh!

justinkambic commented Mar 18, 2026

Uh oh!

kibanamachine commented Mar 18, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11140

Uh oh!

kibanamachine commented Mar 18, 2026

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#11140

Uh oh!

lucaslopezf commented Mar 18, 2026

Uh oh!

kibanamachine commented Mar 18, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11145

Uh oh!

lucaslopezf commented Mar 18, 2026

Uh oh!

kibanamachine commented Mar 18, 2026

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#11145

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Mar 18, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

History

Uh oh!

justinkambic commented Mar 18, 2026

Uh oh!

kibanamachine commented Mar 18, 2026

Flaky Test Runner

✅ Build triggered - kibana-flaky-test-suite-runner#11161

Uh oh!

kibanamachine commented Mar 18, 2026

justinkambic commented Feb 26, 2026 •

edited

Loading