[Discover][Metrics] Fix e2e metrics flaky test#254786
[Discover][Metrics] Fix e2e metrics flaky test#254786lucaslopezf merged 19 commits intoelastic:mainfrom
Conversation
|
/ci |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10843
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10843[❌] src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts: 0/30 tests passed. |
|
/ci |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10845
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10845[✅] src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts: 30/30 tests passed. |
|
/ci |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10846
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10846[✅] src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts: 30/30 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10847
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10847[✅] src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts: 30/30 tests passed. |
|
/ci |
|
/ci |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:35 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10858
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10858[✅] src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts: 35/35 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:40 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10859
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10917[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 50/50 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:50 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10921
|
|
/ci |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10921[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 50/50 tests passed. |
💚 Build Succeeded
Metrics [docs]
History
|
|
Pinging @elastic/obs-exploration-team (Team:obs-exploration) |
iblancof
left a comment
There was a problem hiding this comment.
Worth mentioning for other reviewers that this is just a temporary workaround until the appex team adds support for separating tests with namespaces (which will be happening soon in appex-qa-team/762) .
There’s already an issue (observability-dev/5290) created on our side to separate the configs/ownerships again once that support is merged.
akowalska622
left a comment
There was a problem hiding this comment.
Data Discovery changes LGTM
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:100 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10927
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10927[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 100/100 tests passed. |
Closes: elastic#254759, elastic#254760, elastic#254752 ## Summary Fixes flaky Metrics Experience E2E tests by reorganizing the Scout test structure to comply with Scout's config naming requirements. ### Root Cause Scout expects specific config names (`parallel.playwright.config.ts` or `playwright.config.ts`) to properly assign CI cluster resources. Our custom names (`metrics_experience.parallel.playwright.config.ts`, `traces_experience.parallel.playwright.config.ts`) caused Scout to fall back to a default cluster with fewer resources, leading to intermittent timeouts. ### Changes - **Unified config**: Single `parallel.playwright.config.ts` pointing to `./parallel_tests` - **Unified global setup**: Single `globalSetupHook` handling both Metrics and Traces data setup This PR is necessary to avoid CI cluster misassignment and test flakiness. More details in [this comment](elastic#254759 (comment)). Thanks a lot @dmlemeshko !! ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes: elastic#254759, elastic#254760, elastic#254752 ## Summary Fixes flaky Metrics Experience E2E tests by reorganizing the Scout test structure to comply with Scout's config naming requirements. ### Root Cause Scout expects specific config names (`parallel.playwright.config.ts` or `playwright.config.ts`) to properly assign CI cluster resources. Our custom names (`metrics_experience.parallel.playwright.config.ts`, `traces_experience.parallel.playwright.config.ts`) caused Scout to fall back to a default cluster with fewer resources, leading to intermittent timeouts. ### Changes - **Unified config**: Single `parallel.playwright.config.ts` pointing to `./parallel_tests` - **Unified global setup**: Single `globalSetupHook` handling both Metrics and Traces data setup This PR is necessary to avoid CI cluster misassignment and test flakiness. More details in [this comment](elastic#254759 (comment)). Thanks a lot @dmlemeshko !! ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ... --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Closes: #254759, #254760, #254752
Summary
Fixes flaky Metrics Experience E2E tests by reorganizing the Scout test structure to comply with Scout's config naming requirements.
Root Cause
Scout expects specific config names (
parallel.playwright.config.tsorplaywright.config.ts) to properly assign CI cluster resources. Our custom names (metrics_experience.parallel.playwright.config.ts,traces_experience.parallel.playwright.config.ts) caused Scout to fall back to a default cluster with fewer resources, leading to intermittent timeouts.Changes
parallel.playwright.config.tspointing to./parallel_testsglobalSetupHookhandling both Metrics and Traces data setupThis PR is necessary to avoid CI cluster misassignment and test flakiness. More details in this comment.
Thanks a lot @dmlemeshko !!
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.