x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_feature_extraction_evaluators.test.ts (1)

134-134: Minor inconsistency: describe block name doesn't match new terminology.

The describe block says 'ki count evaluator' but the evaluator is now named 'ki_feature_count'. Consider updating for consistency:

-describe('ki count evaluator', () => {
+describe('ki feature count evaluator', () => {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_feature_extraction_evaluators.test.ts`
at line 134, Update the test suite description to match the evaluator's current
name: change the describe block string from 'ki count evaluator' to
'ki_feature_count evaluator' (or similar consistent phrasing) so it aligns with
the evaluator identifier ki_feature_count used in the tests.

x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_query_generation_evaluators.test.ts (1)

30-33: Avoid the non-null assertion when selecting the evaluator.

Line 33 uses !, which makes failures less explicit if the evaluator name drifts. Prefer an explicit guard with a clear error.

Proposed fix

 const getKIQueryGenerationCodeEvaluator = (esClient: ElasticsearchClient) =>
-  createKIQueryGenerationEvaluators(esClient).find(
-    (evaluator) => evaluator.name === 'ki_query_generation_code_evaluator'
-  )!;
+  {
+    const evaluator = createKIQueryGenerationEvaluators(esClient).find(
+      (item) => item.name === 'ki_query_generation_code_evaluator'
+    );
+    if (!evaluator) {
+      throw new Error('ki_query_generation_code_evaluator was not registered');
+    }
+    return evaluator;
+  };

As per coding guidelines: "Avoid non-null assertions (!) unless locally justified in TypeScript."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_query_generation_evaluators.test.ts`
around lines 30 - 33, The test uses a non-null assertion when selecting the
evaluator which hides failures if the evaluator list changes; update
getKIQueryGenerationCodeEvaluator to explicitly check the result of
createKIQueryGenerationEvaluators(esClient).find(...) (looking for
evaluator.name === 'ki_query_generation_code_evaluator') and throw a clear error
(e.g., new Error with message identifying 'ki_query_generation_code_evaluator'
not found) when the evaluator is undefined so failures are explicit and
informative.

x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_feature_extraction_evaluators.test.ts (1)

12-17: Create evaluators once and reuse for both lookups.

You can avoid duplicate factory calls by creating one evaluator list and reusing it for find().

♻️ Suggested refactor

-const evidenceGroundingEvaluator = createKIFeatureExtractionEvaluators().find(
+const kiFeatureExtractionEvaluators = createKIFeatureExtractionEvaluators();
+
+const evidenceGroundingEvaluator = kiFeatureExtractionEvaluators.find(
   (evaluator) => evaluator.name === 'evidence_grounding'
 );
-const kiFeatureCountEvaluator = createKIFeatureExtractionEvaluators().find(
+const kiFeatureCountEvaluator = kiFeatureExtractionEvaluators.find(
   (evaluator) => evaluator.name === 'ki_feature_count'
 );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_feature_extraction_evaluators.test.ts`
around lines 12 - 17, The test calls createKIFeatureExtractionEvaluators()
twice; instead, call it once, assign the returned array to a variable (e.g.,
evaluators), and then reuse that array for the two find() lookups to obtain
evidenceGroundingEvaluator and kiFeatureCountEvaluator; update references to use
the single evaluators variable and remove the duplicate factory invocation in
createKIFeatureExtractionEvaluators().

x-pack/platform/packages/shared/kbn-evals-suite-streams/src/data_generators/load_ki_features_from_snapshot.test.ts (1)

98-123: Assert the source snapshot index in this happy-path test.

This only pins the temp rename target today. Because allowNoMatches: true, a bad getSigeventsSnapshotKIFeaturesIndex() rename can quietly degrade into an empty restore and this test would still pass. Please also assert the indices argument passed to restoreSnapshot.

✅ Suggested test tightening

+import { getSigeventsSnapshotKIFeaturesIndex } from './sigevents_ki_features_index';
...
     expect(mockRestoreSnapshot).toHaveBeenCalledWith(
       expect.objectContaining({
         snapshotName: 'payment-unreachable',
+        indices: [getSigeventsSnapshotKIFeaturesIndex('payment-unreachable')],
         renamePattern: '(.+)',
         renameReplacement: KI_FEATURES_TEMP_INDEX,
         allowNoMatches: true,
       })
     );

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@x-pack/platform/packages/shared/kbn-evals-suite-streams/src/data_generators/load_ki_features_from_snapshot.test.ts`
around lines 98 - 123, The test currently only asserts the rename target for
restoreSnapshot, leaving the source snapshot index unchecked and allowing
misnamed source indices to slip by; add an assertion on mockRestoreSnapshot to
include the indices field (the source snapshot index) — either compute the
expected value by calling
getSigeventsSnapshotKIFeaturesIndex('payment-unreachable') (or importing the
source-index constant used by loadKIFeaturesFromSnapshot) and then assert
expect(mockRestoreSnapshot).toHaveBeenCalledWith(expect.objectContaining({
indices: expectedIndex })), ensuring the restore call uses the correct source
index.

x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_feature_extraction_evaluators.ts (1)

449-476: Add an explicit return type to this exported factory.

This public helper currently relies on a fairly wide inferred return type across the base path and the scenario-criteria path. Pinning it will make future refactors fail at the declaration instead of widening the evaluator API silently.

✍️ Suggested tightening

 export const createKIFeatureExtractionEvaluators = (scenarioCriteria?: {
   criteriaFn: (criteria: EvaluationCriterion[]) => Evaluator;
   criteria: EvaluationCriterion[];
-}) => {
+}): ReadonlyArray<KIFeatureExtractionEvaluator> => {

As per coding guidelines, "Prefer explicit return types for public APIs and exported functions in TypeScript."

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In
`@x-pack/platform/packages/shared/kbn-evals-suite-streams/src/evaluators/ki_feature_extraction_evaluators.ts`
around lines 449 - 476, The exported factory createKIFeatureExtractionEvaluators
currently relies on inference across the base (selectEvaluators) and scenario
branch (createScenarioCriteriaLlmEvaluator) paths; add an explicit return type
to the function signature (for example Evaluator[] or the more specific
Evaluator<KIFeatureExtractionEvaluationExample, KIFeatureExtractionOutput>[] if
you want to constrain elements) so the public API is pinned — update the
signature of createKIFeatureExtractionEvaluators to include that return type and
import the Evaluator type if necessary.