[Discover][Metrics] Add Scout E2E tests for metrics insights flyout and breakdown dimensions#254753
Conversation
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10854
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10854[✅] src/platform/plugins/shared/discover/test/scout/ui/metrics_experience_parallel.playwright.config.ts: 30/30 tests passed. |
f4b6402 to
965813b
Compare
965813b to
9fc03b7
Compare
|
/ci |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:1 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10944
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10944[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 0/1 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:1 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10945
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10945[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 1/1 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:100 |
|
/ci |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10946
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10946[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 100/100 tests passed. |
|
Pinging @elastic/obs-exploration-team (Team:obs-exploration) |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10964
|
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10964[❌] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 29/30 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:50 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10966
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10966[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 50/50 tests passed. |
...gins/shared/discover/test/scout/ui/parallel_tests/metrics_experience/insights_flyout.spec.ts
Show resolved
Hide resolved
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10993
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10993[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 30/30 tests passed. |
|
/flaky scoutConfig:src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts:30 |
Flaky Test Runner✅ Build triggered - kibana-flaky-test-suite-runner#10996
|
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10996[✅] src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts: 30/30 tests passed. |
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
…nd breakdown dimensions (elastic#254753) ## Summary This PR adds Scout UI (Playwright) e2e coverage for **Metrics in Discover**, focusing on the grid’s key interactions and the Insights flyout experience. It also adds minimal, stable `data-test-subj` hooks in the flyout components to make selectors reliable. ## What’s included - **Insights flyout e2e** - Open flyout from a metric card via **View details** - Verify **Overview** tab content renders - Verify **ES|QL Query** tab renders the query code block - Validate **Dimensions pagination** (jump to last page, next/prev) - **Metrics grid e2e** - Grid activation compatibility across ES|QL commands (`TS`, `WHERE`, `LIMIT`, `SORT`) and non-supported commands (`FROM`, `STATS`) - **Pagination** across metric cards - **Search** filtering and empty state - **Breakdown selector** dimension changes keep grid functional - Metric card actions menu exposes **View details** and **Copy to dashboard**; hover actions expose **Explore** ## Test plan - Run Scout UI tests locally (examples): ```bash # Start a server (choose one) node scripts/scout start-server --arch stateful --domain classic node scripts/scout start-server --arch serverless --domain observability_complete # Run the suite npx playwright test \ src/platform/plugins/shared/discover/test/scout/ui/parallel_tests/metrics_experience/ \ --config src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts \ --project local --trace on ``` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
…nd breakdown dimensions (elastic#254753) ## Summary This PR adds Scout UI (Playwright) e2e coverage for **Metrics in Discover**, focusing on the grid’s key interactions and the Insights flyout experience. It also adds minimal, stable `data-test-subj` hooks in the flyout components to make selectors reliable. ## What’s included - **Insights flyout e2e** - Open flyout from a metric card via **View details** - Verify **Overview** tab content renders - Verify **ES|QL Query** tab renders the query code block - Validate **Dimensions pagination** (jump to last page, next/prev) - **Metrics grid e2e** - Grid activation compatibility across ES|QL commands (`TS`, `WHERE`, `LIMIT`, `SORT`) and non-supported commands (`FROM`, `STATS`) - **Pagination** across metric cards - **Search** filtering and empty state - **Breakdown selector** dimension changes keep grid functional - Metric card actions menu exposes **View details** and **Copy to dashboard**; hover actions expose **Explore** ## Test plan - Run Scout UI tests locally (examples): ```bash # Start a server (choose one) node scripts/scout start-server --arch stateful --domain classic node scripts/scout start-server --arch serverless --domain observability_complete # Run the suite npx playwright test \ src/platform/plugins/shared/discover/test/scout/ui/parallel_tests/metrics_experience/ \ --config src/platform/plugins/shared/discover/test/scout/ui/parallel.playwright.config.ts \ --project local --trace on ``` ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/src/platform/packages/shared/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The `release_note:breaking` label should be applied in these situations. - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) - [ ] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. ### Identify risks Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss. Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging. - [ ] [See some risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) - [ ] ...
Summary
This PR adds Scout UI (Playwright) e2e coverage for Metrics in Discover, focusing on the grid’s key interactions and the Insights flyout experience. It also adds minimal, stable
data-test-subjhooks in the flyout components to make selectors reliable.What’s included
Insights flyout e2e
Metrics grid e2e
TS,WHERE,LIMIT,SORT) and non-supported commands (FROM,STATS)Test plan
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breakinglabel should be applied in these situations.release_note:*label is applied per the guidelinesbackport:*labels.Identify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.