Skip to content

[ES|QL] Grouping functions as arguments to scalar functions#251015

Merged
momovdg merged 3 commits intoelastic:mainfrom
momovdg:esql-allow-grouping-fns-in-scalar-fns
Feb 2, 2026
Merged

[ES|QL] Grouping functions as arguments to scalar functions#251015
momovdg merged 3 commits intoelastic:mainfrom
momovdg:esql-allow-grouping-fns-in-scalar-fns

Conversation

@momovdg
Copy link
Copy Markdown
Contributor

@momovdg momovdg commented Jan 30, 2026 •
edited
Loading

resolves #229995

Summary

With this fix grouping functions are suggested as arguments to scalar functions, but still not suggested as arguments to other grouping functions.

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Unit or functional tests were updated or added to match the most common scenarios
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines
  • Review the backport guidelines and apply applicable backport:* labels.

@momovdg momovdg self-assigned this Jan 30, 2026
@momovdg momovdg added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana t// v9.4.0 labels Jan 30, 2026
@momovdg momovdg marked this pull request as ready for review January 30, 2026 13:34
@momovdg momovdg requested a review from a team as a code owner January 30, 2026 13:34
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 30, 2026

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 1, 2026

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 4.5MB 4.5MB +84.0B

History

cc @momovdg

stratoula
stratoula approved these changes Feb 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! And seems more contextual correct

@momovdg momovdg merged commit 8a621fb into elastic:main Feb 2, 2026
16 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 2, 2026
@mbondyra
Merge commit '3cd2ea4a515d8a0aafd32f75dc61f1cff892a4b0' into copy_rev…
26db809 
…iew_cps

* commit '3cd2ea4a515d8a0aafd32f75dc61f1cff892a4b0':
  Fix Failing test: APM Service overview - header filters (elastic#250355)
  [ES|QL] Small improvements on the editor (elastic#251004)
  [ES|QL] Refactor promql validation (elastic#250996)
  [ES|QL] Update the readme in esql-utils (elastic#251024)
  [ES|QL] Grouping functions as arguments to scalar functions (elastic#251015)
  [ES|QL] focus editor when user uses visor (elastic#251084)
  [Contextual Security] add relationship node type for entity graph (elastic#249479)
  [One Workflow] Fix email connector documentation: to field (elastic#251171)
@momovdg momovdg deleted the esql-allow-grouping-fns-in-scalar-fns branch February 2, 2026 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

@momovdg momovdg

Labels

backport:skip This PR does not require backporting Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana t// v9.4.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ES|QL] suggest grouping functions as arguments to scalars in STATS BY

3 participants

@momovdg @elasticmachine @stratoula