Skip to content

Fix Failing test: APM Service overview - header filters#250355

Merged
sbelastic merged 13 commits intoelastic:mainfrom
sbelastic:214673-add-more-complex-kuery-to-header-filters-tests
Feb 2, 2026
Merged

Fix Failing test: APM Service overview - header filters#250355
sbelastic merged 13 commits intoelastic:mainfrom
sbelastic:214673-add-more-complex-kuery-to-header-filters-tests

Conversation

@sbelastic
Copy link
Copy Markdown
Contributor

@sbelastic sbelastic commented Jan 26, 2026

Closes #214673

Summary

Re-done migration of cypress tests to scout and made a more complex validation to the kuery test.

Running tests e2e locally

Run server (first terminal):

node scripts/scout.js start-server --stateful

Run apm tests (second terminal):

npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts

Checklist

@sbelastic sbelastic self-assigned this Jan 26, 2026
@sbelastic sbelastic added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.4.0 Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation labels Jan 26, 2026
@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10588

[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10589

[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10591

[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10598

[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 1/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10600

[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🟠 Some tests failed. - kibana-flaky-test-suite-runner#10602

[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#10606

[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 15/15 tests passed.

see run history

@sbelastic sbelastic marked this pull request as ready for review January 27, 2026 10:52
@sbelastic sbelastic requested a review from a team as a code owner January 27, 2026 10:52
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

Copy link
Copy Markdown
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! Just some questions about the maxItems changes:

"type": "object"
},
"maxItems": 1000,
"maxItems": 10000,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Do we need this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, but this is something done by the CI...

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for explaining, so I guess it is something the @elastic/observablt-robots configured 🤔

Comment on lines +82 to +84
await expect(
page.getByTestId('transactionBreakdownChart').getByText('No data to display')
).toBeVisible({ timeout: EXTENDED_TIMEOUT });
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT We can keep the same validation as above using toHaveText so we don't try to get by text:

Suggested change
await expect(
page.getByTestId('transactionBreakdownChart').getByText('No data to display')
).toBeVisible({ timeout: EXTENDED_TIMEOUT });
await expect(
page.getByTestId('transactionBreakdownChart')
).toHaveText('No data to display', { timeout: EXTENDED_TIMEOUT });

Copy link
Copy Markdown
Member

@jennypavlova jennypavlova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

"type": "object"
},
"maxItems": 1000,
"maxItems": 10000,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, thanks for explaining, so I guess it is something the @elastic/observablt-robots configured 🤔

@elasticmachine
Copy link
Copy Markdown
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #123 / "before all" hook in "{root}"
  • [job] [logs] FTR Configs #44 / Search solution tests Search index details page Solution Nav - Search search index details page has index actions enabled add field button is enabled

The CI Stats report is too large to be displayed here, check out the CI build annotation for this information.

History

cc @sbelastic

@sbelastic sbelastic merged commit 3cd2ea4 into elastic:main Feb 2, 2026
16 checks passed
mbondyra added a commit to mbondyra/kibana that referenced this pull request Feb 2, 2026
…iew_cps

* commit '3cd2ea4a515d8a0aafd32f75dc61f1cff892a4b0':
  Fix Failing test: APM Service overview - header filters (elastic#250355)
  [ES|QL] Small improvements on the editor (elastic#251004)
  [ES|QL] Refactor promql validation (elastic#250996)
  [ES|QL] Update the readme in esql-utils (elastic#251024)
  [ES|QL] Grouping functions as arguments to scalar functions (elastic#251015)
  [ES|QL] focus editor when user uses visor (elastic#251084)
  [Contextual Security] add relationship node type for entity graph (elastic#249479)
  [One Workflow] Fix email connector documentation: to field (elastic#251171)
@sbelastic
Copy link
Copy Markdown
Contributor Author

💔 Some backports could not be created

Status Branch Result
9.3
9.1 Conflict resolution was aborted by the user

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 250355

Questions ?

Please refer to the Backport tool documentation

@sbelastic
Copy link
Copy Markdown
Contributor Author

💚 All backports created successfully

Status Branch Result
9.1

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation v9.4.0

Projects

None yet

4 participants