Fix Failing test: APM Service overview - header filters#250355
Fix Failing test: APM Service overview - header filters#250355sbelastic merged 13 commits intoelastic:mainfrom
Conversation
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10588[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10589[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10591[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10598[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 1/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10600[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🟠 Some tests failed. - kibana-flaky-test-suite-runner#10602[❌] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 0/15 tests passed. |
Flaky Test Runner Stats🎉 All tests passed! - kibana-flaky-test-suite-runner#10606[✅] x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.ts: 15/15 tests passed. |
|
Pinging @elastic/obs-presentation-team (Team:obs-presentation) |
jennypavlova
left a comment
There was a problem hiding this comment.
Thanks for fixing that! Just some questions about the maxItems changes:
oas_docs/bundle.json
Outdated
| "type": "object" | ||
| }, | ||
| "maxItems": 1000, | ||
| "maxItems": 10000, |
There was a problem hiding this comment.
Q: Do we need this change?
There was a problem hiding this comment.
Not really, but this is something done by the CI...
There was a problem hiding this comment.
Ok, thanks for explaining, so I guess it is something the @elastic/observablt-robots configured 🤔
| await expect( | ||
| page.getByTestId('transactionBreakdownChart').getByText('No data to display') | ||
| ).toBeVisible({ timeout: EXTENDED_TIMEOUT }); |
There was a problem hiding this comment.
NIT We can keep the same validation as above using toHaveText so we don't try to get by text:
| await expect( | |
| page.getByTestId('transactionBreakdownChart').getByText('No data to display') | |
| ).toBeVisible({ timeout: EXTENDED_TIMEOUT }); | |
| await expect( | |
| page.getByTestId('transactionBreakdownChart') | |
| ).toHaveText('No data to display', { timeout: EXTENDED_TIMEOUT }); |
oas_docs/bundle.json
Outdated
| "type": "object" | ||
| }, | ||
| "maxItems": 1000, | ||
| "maxItems": 10000, |
There was a problem hiding this comment.
Ok, thanks for explaining, so I guess it is something the @elastic/observablt-robots configured 🤔
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
The CI Stats report is too large to be displayed here, check out the CI build annotation for this information. History
cc @sbelastic |
…ex-kuery-to-header-filters-tests
…iew_cps * commit '3cd2ea4a515d8a0aafd32f75dc61f1cff892a4b0': Fix Failing test: APM Service overview - header filters (elastic#250355) [ES|QL] Small improvements on the editor (elastic#251004) [ES|QL] Refactor promql validation (elastic#250996) [ES|QL] Update the readme in esql-utils (elastic#251024) [ES|QL] Grouping functions as arguments to scalar functions (elastic#251015) [ES|QL] focus editor when user uses visor (elastic#251084) [Contextual Security] add relationship node type for entity graph (elastic#249479) [One Workflow] Fix email connector documentation: to field (elastic#251171)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
Closes #214673
Summary
Re-done migration of cypress tests to scout and made a more complex validation to the kuery test.
Running tests e2e locally
Run server (first terminal):
node scripts/scout.js start-server --statefulRun apm tests (second terminal):
npx playwright test --project local --ui --config x-pack/solutions/observability/plugins/apm/test/scout/ui/parallel.playwright.config.tsChecklist