[ES|QL] Refactor promql validation#250996
Merged
bartoval merged 7 commits intoelastic:mainfrom Feb 2, 2026
Merged
Conversation
bartoval
commented
Jan 30, 2026
| * | ||
| * Example: "PROMQL step=5m col0=(rate(x[5m]))" → "col0=(rate(x[5m]))" | ||
| */ | ||
| function getPromqlQueryTail(command: ESQLAstPromqlCommand): string { |
Contributor
Author
There was a problem hiding this comment.
Go away, you're not beautiful
bartoval
commented
Jan 30, 2026
| for (const source of sources) { | ||
| const indexName = source.name; | ||
|
|
||
| if (indexName && !sourceExists(indexName, sourcesSet)) { |
Contributor
Author
There was a problem hiding this comment.
The other commands generally validate everything so I try to stay aligned, only enrich does a split between prefix and index in the validation
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
Contributor
💚 Build Succeeded
Metrics [docs]Page load bundle
History
cc @bartoval |
stratoula
approved these changes
Feb 2, 2026
Contributor
stratoula
left a comment
There was a problem hiding this comment.
This is an amazing refactor 🙌 LGTM! Code review only
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 2, 2026
…iew_cps * commit '3cd2ea4a515d8a0aafd32f75dc61f1cff892a4b0': Fix Failing test: APM Service overview - header filters (elastic#250355) [ES|QL] Small improvements on the editor (elastic#251004) [ES|QL] Refactor promql validation (elastic#250996) [ES|QL] Update the readme in esql-utils (elastic#251024) [ES|QL] Grouping functions as arguments to scalar functions (elastic#251015) [ES|QL] focus editor when user uses visor (elastic#251084) [Contextual Security] add relationship node type for entity graph (elastic#249479) [One Workflow] Fix email connector documentation: to field (elastic#251171)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With this #250633 we get better support from AST