[ES|QL] Small improvements on the editor#251004
Merged
stratoula merged 8 commits intoelastic:mainfrom Feb 2, 2026
Merged
Conversation
stratoula
commented
Jan 30, 2026
| Boolean(editorMessages.warnings.length), | ||
| Boolean(editorIsInline), | ||
| Boolean(hasOutline) | ||
| const styles = useMemo( |
Contributor
Author
There was a problem hiding this comment.
Memoized for performance
stratoula
commented
Jan 30, 2026
| } | ||
|
|
||
| const unerlinedWarnings = allWarnings.filter((warning) => warning.underlinedWarning); | ||
| const underlinedWarnings = allWarnings.filter((warning) => warning.underlinedWarning); |
stratoula
commented
Jan 30, 2026
| queryValidation(subscription).catch(() => {}); | ||
| } | ||
| return () => (subscription.active = false); | ||
| queryValidation(subscription) |
Contributor
Author
There was a problem hiding this comment.
This was not working properly
stratoula
commented
Jan 30, 2026
| return ESQLLang.getInlineCompletionsProvider?.(esqlCallbacks); | ||
| }, [esqlCallbacks]); | ||
|
|
||
| const codeEditorHoverProvider = useMemo( |
Contributor
Author
There was a problem hiding this comment.
Memoized for performance like the rest providers
stratoula
commented
Jan 30, 2026
| if (closingSquareBracketIndex !== -1) { | ||
| errorLength = warningMessage.length - openingSquareBracketIndex - 1; | ||
| } | ||
| const matches = truncatedWarning.match(quotedWarningMessageRegexp); |
Contributor
Author
There was a problem hiding this comment.
Small change for small performance benefits
stratoula
commented
Jan 30, 2026
Contributor
Author
There was a problem hiding this comment.
The callbacks was a huge memo. I split it into smaller chunks and moved it to a new hook. This will make it more performant and easier to maintain
Contributor
|
Pinging @elastic/kibana-esql (Team:ESQL) |
sddonne
approved these changes
Jan 30, 2026
Contributor
sddonne
left a comment
There was a problem hiding this comment.
Nice job! I think all changes makes sense.
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
|
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Feb 2, 2026
…iew_cps * commit '3cd2ea4a515d8a0aafd32f75dc61f1cff892a4b0': Fix Failing test: APM Service overview - header filters (elastic#250355) [ES|QL] Small improvements on the editor (elastic#251004) [ES|QL] Refactor promql validation (elastic#250996) [ES|QL] Update the readme in esql-utils (elastic#251024) [ES|QL] Grouping functions as arguments to scalar functions (elastic#251015) [ES|QL] focus editor when user uses visor (elastic#251084) [Contextual Security] add relationship node type for entity graph (elastic#249479) [One Workflow] Fix email connector documentation: to field (elastic#251171)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A bunch of improvements to the editor, mostly performance thingies