[Metrics][Discover] Discover to prefer line chars for time series data by crespocarlos · Pull Request #244595 · elastic/kibana

crespocarlos · 2025-11-28T09:20:08Z

Summary

Changes the call to Suggestion API in Discover to set the preferred char type as line if the query contains a timeseries bucket aggregation

Should work

Important

The scenario above depends on this PR #244753

Should not work

src/platform/packages/shared/kbn-unified-histogram/services/lens_vis_service.ts

elasticmachine · 2025-12-01T14:31:48Z

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

elasticmachine · 2025-12-01T14:31:50Z

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

elasticmachine · 2025-12-01T14:31:51Z

Pinging @elastic/kibana-esql (Team:ESQL)

crespocarlos · 2025-12-01T14:55:54Z

@elasticmachine merge upstream

…-agg-poc

stratoula

Thanx Carlos, it works ok! I have added some ideas on how to make this function a bit smarter. I dont think you need the bucketColumns logic. Check my last comment.

You also don't get into account the TBucket function which I am assuming is going to be the most popular one with timeseries.

Last but not least before we merge it, let's wait for this to get merged first #244753 (to test them together) and I am also seen some weird behavior in ES|QL in some cases, for example

TS kibana_sample_data_logstsdb | EVAL meow = DATE_TRUNC(1 hour, @timestamp) | STATS AVG(LAST_OVER_TIME(bytes)) BY meow

The above is another way to create time buckets and is not working correctly in ES|QL TS mode. I asked the team, so let's wait for them to respond first to see if we should also include it on our checks or not!

src/platform/packages/shared/kbn-esql-utils/src/utils/query_parsing_helpers.ts

davismcphee

Tested locally, Data Discovery changes LGTM 👍

src/platform/packages/shared/kbn-unified-histogram/services/lens_vis_service.ts

crespocarlos · 2025-12-03T16:42:32Z

@elasticmachine merge upstream

…-agg-poc

elasticmachine · 2025-12-04T11:12:18Z

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

…-agg-poc

stratoula

Thanx Carlos. ES|QL changes LGTM. I noticed a bug though when changing from one breakdown to another so I pushed a fix. The visualizations team needs to review

src/platform/packages/shared/kbn-esql-utils/src/utils/query_parsing_helpers.test.ts

stratoula · 2025-12-05T11:05:10Z

.../platform/plugins/shared/lens/public/editor_frame_service/editor_frame/suggestion_helpers.ts

  datasourceId?: string
 ) {
  try {
+    const isSubtypeSupported =


Adds another check for the validation of the subVisualizationId. This is important because the suggestions are being generated for all visualizations. So this is valid for XY but it is not for a partition. So we dont send it when it is not valid.

Without it if you change breakdowns (for example from TBUCKET to BUCKET) you will see a notification error.

…rsing_helpers.test.ts Co-authored-by: Stratou <stratoula1@gmail.com>

crespocarlos · 2025-12-08T08:54:49Z

@elasticmachine merge upstream

…-agg-poc

nickofthyme

Viz Code changes LGTM

…-prefer-line-chart-for-bucket-agg-poc

elasticmachine · 2025-12-08T18:15:52Z

💚 Build Succeeded

Buildkite Build
Commit: f1359b8

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`dataVisualizer`	597.5KB	597.1KB	-420.0B
`discover`	1.3MB	1.3MB	+546.0B
`lens`	1.6MB	1.6MB	+129.0B
total			+255.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`dataVisualizer`	29.3KB	29.3KB	+9.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/esql-utils`	171	174	+3

async chunk count

id	before	after	diff
`dataVisualizer`	19	20	+1

History

💛 Build #369443 was flaky 9782483
💔 Build #369355 failed f69928c
💚 Build #368588 succeeded eae22ba
💚 Build #367242 succeeded 1e065cc
💔 Build #367141 failed 9a1c9c0

* commit '6647f813c9fa03ac0378e3d4756246e8dc4b4c76': (33 commits) [Detection Engine] Extracts Rules/Alerts/Exceptions permission to new Rules feature privileges (elastic#239634) [Agent Builder] Add Intro Tour (elastic#245551) Add datastream lifecycle support to indices metadata (elastic#245548) [Serverless] Update preconfigured connectors (elastic#245445) [Metrics][Discover] Discover to prefer line chars for time series data (elastic#244595) Update dependency @elastic/ebt to ^1.4.1 (main) (elastic#241629) [One Workflow] fix: request bodies with oneof schemas (`kibana.SetAlertsStatus`, etc) (elastic#245344) Update dependency ai to v5 (elastic#244675) Fix Discover trace waterfall behavior with duplicate spans (elastic#244984) [FSH] Migrated fs usage to kbn/fs for sample ingest (elastic#244163) Streamlang: Unskip type coercion test (elastic#245519) [Response Ops][Reporting] Fixing error in calculating delay value between retries (elastic#245431) Add TopNavMenuBeta to navigation plugin (elastic#243578) [scout] support custom servers configuration (elastic#244306) [Fleet] Run agentless background sync without dry run (elastic#245286) Fix Change Password Flaky Test (elastic#245443) Add new gap fill status for rules (elastic#242595) [Kibana Search] Move SLOs higher up in search results (elastic#245518) feat(slo): introduce find SLO instances internal route (elastic#245333) [FSH] Dropped unnecessary `fs` persistence for synthetics project code (elastic#244338) ...

This was referenced Nov 28, 2025

[Metrics][Discover] SuggestionAPI prefer line chars for time series data POC #244529

Closed

[Metrics][Discover] Default to optimal chart type (Line vs Area) for time-series queries #236261

Closed

stratoula reviewed Nov 28, 2025

View reviewed changes

src/platform/packages/shared/kbn-unified-histogram/services/lens_vis_service.ts Outdated Show resolved Hide resolved

crespocarlos force-pushed the 236261-discover-prefer-line-chart-for-bucket-agg-poc branch 2 times, most recently from 3444eab to f37dab2 Compare November 28, 2025 15:14

poc

f401420

crespocarlos force-pushed the 236261-discover-prefer-line-chart-for-bucket-agg-poc branch 3 times, most recently from 735f551 to ca5109f Compare December 1, 2025 11:18

feat: prefer line char when the query is ts date histogram

4c88e52

crespocarlos force-pushed the 236261-discover-prefer-line-chart-for-bucket-agg-poc branch from ca5109f to 4c88e52 Compare December 1, 2025 11:20

fix: revert changes on suggestions api

9a1c9c0

crespocarlos changed the title ~~[Metrics][Discover] Discover to prefer line chars for time series data POC~~ [Metrics][Discover] Discover to prefer line chars for time series data Dec 1, 2025

crespocarlos marked this pull request as ready for review December 1, 2025 14:31

crespocarlos requested review from a team as code owners December 1, 2025 14:31

crespocarlos requested a review from stratoula December 1, 2025 14:55

Merge branch 'main' into 236261-discover-prefer-line-chart-for-bucket…

1e065cc

…-agg-poc

simianhacker added the Feature:Metrics in Discover label Dec 1, 2025

stratoula reviewed Dec 2, 2025

View reviewed changes

crespocarlos added 2 commits December 2, 2025 09:56

fix: cr

b7fce59

fix: cr

f0fb456

crespocarlos requested a review from stratoula December 2, 2025 08:58

davismcphee approved these changes Dec 2, 2025

View reviewed changes

davismcphee reviewed Dec 2, 2025

View reviewed changes

src/platform/packages/shared/kbn-unified-histogram/services/lens_vis_service.ts Show resolved Hide resolved

test: add coverage

6b9498e

Merge branch 'main' into 236261-discover-prefer-line-chart-for-bucket…

eae22ba

…-agg-poc

crespocarlos added Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation and removed Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. labels Dec 4, 2025

stratoula and others added 3 commits December 5, 2025 08:24

Merge branch 'main' into 236261-discover-prefer-line-chart-for-bucket…

f69928c

…-agg-poc

feat: consider STATS BY <date_field>

b710229

More robust way to ensure that the sub visualization id is valid

d05b271

stratoula requested a review from a team as a code owner December 5, 2025 11:01

Fix

9782483

stratoula approved these changes Dec 5, 2025

View reviewed changes

Update src/platform/packages/shared/kbn-esql-utils/src/utils/query_pa…

fb5f1a3

…rsing_helpers.test.ts Co-authored-by: Stratou <stratoula1@gmail.com>

Merge branch 'main' into 236261-discover-prefer-line-chart-for-bucket…

2b4ed45

…-agg-poc

nickofthyme approved these changes Dec 8, 2025

View reviewed changes

Merge branch 'main' of github.com:elastic/kibana into 236261-discover…

f1359b8

…-prefer-line-chart-for-bucket-agg-poc

crespocarlos enabled auto-merge (squash) December 8, 2025 16:24

crespocarlos merged commit cb12cc5 into elastic:main Dec 8, 2025
12 checks passed

miguel-sanchez-elastic mentioned this pull request Jan 23, 2026

[Metrics][Discover] PromQL range vectors as line charts #244190

Open

maryam-saeidi added a commit to maryam-saeidi/kibana that referenced this pull request Feb 3, 2026

Partially revert elastic#244595

5824f8c

maryam-saeidi added a commit to maryam-saeidi/kibana that referenced this pull request Feb 6, 2026

Partially revert elastic#244595

0e84613

Conversation

crespocarlos commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Uh oh!

elasticmachine commented Dec 1, 2025

Uh oh!

elasticmachine commented Dec 1, 2025

Uh oh!

elasticmachine commented Dec 1, 2025

Uh oh!

crespocarlos commented Dec 1, 2025

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davismcphee left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

crespocarlos commented Dec 3, 2025

Uh oh!

elasticmachine commented Dec 4, 2025

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stratoula Dec 5, 2025

Choose a reason for hiding this comment

Uh oh!

crespocarlos commented Dec 8, 2025

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Dec 8, 2025

💚 Build Succeeded

Metrics [docs]

Async chunks

Page load bundle

API count

async chunk count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

crespocarlos commented Nov 28, 2025 •

edited

Loading