[FSH] Dropped unnecessary fs persistence for synthetics project code#244338
Merged
elena-shostak merged 14 commits intoelastic:mainfrom Dec 8, 2025
Merged
[FSH] Dropped unnecessary fs persistence for synthetics project code#244338elena-shostak merged 14 commits intoelastic:mainfrom
fs persistence for synthetics project code#244338elena-shostak merged 14 commits intoelastic:mainfrom
Conversation
fs persistence for synthetics project code.
elena-shostak
commented
Nov 28, 2025
Comment on lines
-23
to
-25
| const pathToZip = generateTempPath(); | ||
| await writeFile(pathToZip, decoded); | ||
| const zip = new AdmZip(pathToZip); |
Contributor
Author
There was a problem hiding this comment.
Note
In scope of FSH initiative we wanted to migrate fs usage to the @kbn/fs package. However, I've noticed that AdmZip directly accepts Buffer, so it seems there is no need in persistence at all
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
Contributor
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
fs persistence for synthetics project code.fs persistence for synthetics project code
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
History
|
kdelemme
approved these changes
Dec 8, 2025
Contributor
|
Starting backport for target branches: 8.19, 9.1, 9.2 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2025
elastic#244338) ## Summary Dropped unnecessary `fs` persistence for synthetics project code. __Relates: https://github.com/elastic/kibana/issues/239385__ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5b3dcf0)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2025
elastic#244338) ## Summary Dropped unnecessary `fs` persistence for synthetics project code. __Relates: https://github.com/elastic/kibana/issues/239385__ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5b3dcf0)
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 8, 2025
elastic#244338) ## Summary Dropped unnecessary `fs` persistence for synthetics project code. __Relates: https://github.com/elastic/kibana/issues/239385__ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 5b3dcf0)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2025
…ct code (#244338) (#245531) # Backport This will backport the following commits from `main` to `9.2`: - [[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)](#244338) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"165678770+elena-shostak@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-08T14:07:15Z","message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","Feature:Hardening","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8","Team:obs-ux-management"],"title":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code","number":244338,"url":"https://github.com/elastic/kibana/pull/244338","mergeCommit":{"message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244338","number":244338,"mergeCommit":{"message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2025
…ect code (#244338) (#245529) # Backport This will backport the following commits from `main` to `8.19`: - [[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)](#244338) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"165678770+elena-shostak@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-08T14:07:15Z","message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","Feature:Hardening","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8","Team:obs-ux-management"],"title":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code","number":244338,"url":"https://github.com/elastic/kibana/pull/244338","mergeCommit":{"message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244338","number":244338,"mergeCommit":{"message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Dec 8, 2025
…ct code (#244338) (#245530) # Backport This will backport the following commits from `main` to `9.1`: - [[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)](#244338) <!--- Backport version: 9.6.6 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Elena Shostak","email":"165678770+elena-shostak@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-12-08T14:07:15Z","message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688","branchLabelMapping":{"^v9.3.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","Feature:Hardening","backport:version","v9.3.0","v8.19.8","v9.2.2","v9.1.8","Team:obs-ux-management"],"title":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code","number":244338,"url":"https://github.com/elastic/kibana/pull/244338","mergeCommit":{"message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688"}},"sourceBranch":"main","suggestedTargetBranches":["8.19","9.2","9.1"],"targetPullRequestStates":[{"branch":"main","label":"v9.3.0","branchLabelMappingKey":"^v9.3.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/244338","number":244338,"mergeCommit":{"message":"[FSH] Dropped unnecessary `fs` persistence for synthetics project code (#244338)\n\n## Summary\n\nDropped unnecessary `fs` persistence for synthetics project code.\n\n__Relates: https://github.com/elastic/kibana/issues/239385__\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"5b3dcf04d6613852e95c5356dafc8de42021d688"}},{"branch":"8.19","label":"v8.19.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.2","label":"v9.2.2","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"9.1","label":"v9.1.8","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Elena Shostak <165678770+elena-shostak@users.noreply.github.com>
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 8, 2025
* commit '6647f813c9fa03ac0378e3d4756246e8dc4b4c76': (33 commits) [Detection Engine] Extracts Rules/Alerts/Exceptions permission to new Rules feature privileges (elastic#239634) [Agent Builder] Add Intro Tour (elastic#245551) Add datastream lifecycle support to indices metadata (elastic#245548) [Serverless] Update preconfigured connectors (elastic#245445) [Metrics][Discover] Discover to prefer line chars for time series data (elastic#244595) Update dependency @elastic/ebt to ^1.4.1 (main) (elastic#241629) [One Workflow] fix: request bodies with oneof schemas (`kibana.SetAlertsStatus`, etc) (elastic#245344) Update dependency ai to v5 (elastic#244675) Fix Discover trace waterfall behavior with duplicate spans (elastic#244984) [FSH] Migrated fs usage to kbn/fs for sample ingest (elastic#244163) Streamlang: Unskip type coercion test (elastic#245519) [Response Ops][Reporting] Fixing error in calculating delay value between retries (elastic#245431) Add TopNavMenuBeta to navigation plugin (elastic#243578) [scout] support custom servers configuration (elastic#244306) [Fleet] Run agentless background sync without dry run (elastic#245286) Fix Change Password Flaky Test (elastic#245443) Add new gap fill status for rules (elastic#242595) [Kibana Search] Move SLOs higher up in search results (elastic#245518) feat(slo): introduce find SLO instances internal route (elastic#245333) [FSH] Dropped unnecessary `fs` persistence for synthetics project code (elastic#244338) ...
JordanSh
pushed a commit
to JordanSh/kibana
that referenced
this pull request
Dec 9, 2025
elastic#244338) ## Summary Dropped unnecessary `fs` persistence for synthetics project code. __Relates: https://github.com/elastic/kibana/issues/239385__ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dropped unnecessary
fspersistence for synthetics project code.Relates: #239385