[FSH] Migrated fs usage to kbn/fs for sample ingest by elena-shostak · Pull Request #244163 · elastic/kibana

elena-shostak · 2025-11-25T13:14:57Z

Summary

Migrated fs usage to @kbn/fs for sample ingest in scope of filesystem hardening initiative.

Checklist

Unit or functional tests were updated or added to match the most common scenarios
Review the backport guidelines and apply applicable backport:* labels.

Relates: #239385

…tak/kibana into 239385-fs-usage-sample-ingest

elena-shostak · 2025-12-01T11:25:39Z

x-pack/platform/plugins/shared/sample_data_ingest/server/plugin.ts

    const sampleDataManager = new SampleDataManager({
      kibanaVersion: this.context.env.packageInfo.version,
-      artifactsFolder: Path.join(getDataPath(), 'sample-data-artifacts'),
+      artifactsFolder: 'sample-data-artifacts',


Note
There is no need to form a full path anymore, @kbn/fs saves to data folder under the hood

elena-shostak · 2025-12-01T11:27:10Z

...tform/plugins/shared/sample_data_ingest/server/services/artifact_manager/artifact_manager.ts

    const artifactFileName = getArtifactName({ productName, productVersion });
    const artifactUrl = `${this.artifactRepositoryUrl}/${artifactFileName}`;
-    const artifactPath = `${this.artifactsFolder}/${artifactFileName}`;
+    const artifactPathAtVolume = `${this.artifactsFolder}/${artifactFileName}`;


Note
sample-data-artifacts folder will be created under the hood

elasticmachine · 2025-12-01T11:29:17Z

Pinging @elastic/kibana-security (Team:Security)

SiddharthMantri

LGTM!

yansavitski

LGTM

Thank you

elasticmachine · 2025-12-08T16:03:53Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 08f88e5

Failed CI Steps

FTR Configs #44

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/fs`	2	5	+3

Unknown metric groups

API count

id	before	after	diff
`@kbn/fs`	38	41	+3

History

💛 Build #367142 was flaky 46fa357
💚 Build #366783 succeeded 5e3eebc
💔 Build #366676 failed 0b3dba0
💔 Build #366269 failed a3254ab
💔 Build #365756 failed c245bbc
💔 Build #365645 failed 290435b

kibanamachine · 2025-12-08T16:45:16Z

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/20035676732

kibanamachine · 2025-12-08T16:55:17Z

💔 All backports failed

Status	Branch	Result
❌	9.2	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 244163

Questions ?

Please refer to the Backport tool documentation

* commit '6647f813c9fa03ac0378e3d4756246e8dc4b4c76': (33 commits) [Detection Engine] Extracts Rules/Alerts/Exceptions permission to new Rules feature privileges (elastic#239634) [Agent Builder] Add Intro Tour (elastic#245551) Add datastream lifecycle support to indices metadata (elastic#245548) [Serverless] Update preconfigured connectors (elastic#245445) [Metrics][Discover] Discover to prefer line chars for time series data (elastic#244595) Update dependency @elastic/ebt to ^1.4.1 (main) (elastic#241629) [One Workflow] fix: request bodies with oneof schemas (`kibana.SetAlertsStatus`, etc) (elastic#245344) Update dependency ai to v5 (elastic#244675) Fix Discover trace waterfall behavior with duplicate spans (elastic#244984) [FSH] Migrated fs usage to kbn/fs for sample ingest (elastic#244163) Streamlang: Unskip type coercion test (elastic#245519) [Response Ops][Reporting] Fixing error in calculating delay value between retries (elastic#245431) Add TopNavMenuBeta to navigation plugin (elastic#243578) [scout] support custom servers configuration (elastic#244306) [Fleet] Run agentless background sync without dry run (elastic#245286) Fix Change Password Flaky Test (elastic#245443) Add new gap fill status for rules (elastic#242595) [Kibana Search] Move SLOs higher up in search results (elastic#245518) feat(slo): introduce find SLO instances internal route (elastic#245333) [FSH] Dropped unnecessary `fs` persistence for synthetics project code (elastic#244338) ...

elena-shostak · 2025-12-09T10:43:14Z

💚 All backports created successfully

Status	Branch	Result
✅	9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary Migrated `fs` usage to `@kbn/fs` for sample ingest in scope of filesystem hardening initiative. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Review the [backport guidelines](https://docs.google.com/document/d/1VyN5k91e5OVumlc0Gb9RPa3h1ewuPE705nRtioPiTvY/edit?usp=sharing) and apply applicable `backport:*` labels. __Relates: https://github.com/elastic/kibana/issues/239385__ --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Yan Savitski <yan.savitski@elastic.co> (cherry picked from commit e7ebe47) # Conflicts: # x-pack/platform/plugins/shared/sample_data_ingest/moon.yml # x-pack/platform/plugins/shared/sample_data_ingest/server/plugin.ts # x-pack/platform/plugins/shared/sample_data_ingest/server/services/artifact_manager/artifact_manager.ts # x-pack/platform/plugins/shared/sample_data_ingest/server/services/artifact_manager/utils/download.test.ts # x-pack/platform/plugins/shared/sample_data_ingest/server/services/artifact_manager/utils/download.ts # x-pack/platform/plugins/shared/sample_data_ingest/tsconfig.json

kibanamachine · 2025-12-10T10:48:59Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @elena-shostak

kibanamachine · 2025-12-11T10:49:12Z

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.
cc: @elena-shostak

…245613) # Backport This will backport the following commits from `main` to `9.2`: - [[FSH] Migrated fs usage to kbn/fs for sample ingest (#244163)](#244163)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport)  --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

elena-shostak and others added 8 commits November 25, 2025 13:13

[FSH] Migrated fs usage to kbn/fs for sample ingest

6294813

Changes from node scripts/lint_ts_projects --fix

2f7ed68

Changes from node scripts/regenerate_moon_projects.js --update

85165c6

Test fixes

497b7a4

Merge branch '239385-fs-usage-sample-ingest' of github.com:elena-shos…

489ac9f

…tak/kibana into 239385-fs-usage-sample-ingest

Merge branch 'main' into 239385-fs-usage-sample-ingest

290435b

Changes from node scripts/lint_ts_projects --fix

b8dfbb9

Changes from node scripts/eslint_all_files --no-cache --fix

c245bbc

kibanamachine and others added 4 commits November 26, 2025 12:48

Changes from node scripts/lint_ts_projects --fix

aa1c3e5

Changes from node scripts/regenerate_moon_projects.js --update

8521be1

Merge branch 'main' into 239385-fs-usage-sample-ingest

a3254ab

Merge branch 'main' into 239385-fs-usage-sample-ingest

0b3dba0

elena-shostak mentioned this pull request Nov 28, 2025

Migrate current fs operations to use @kbn/fs package #239385

Closed

elena-shostak and others added 4 commits November 28, 2025 13:38

Test fixes

0211f86

Merge branch 'main' into 239385-fs-usage-sample-ingest

3e34971

Test fixes

1e196db

Merge branch '239385-fs-usage-sample-ingest' of github.com:elena-shos…

5e3eebc

…tak/kibana into 239385-fs-usage-sample-ingest

elena-shostak commented Dec 1, 2025

View reviewed changes

elena-shostak marked this pull request as ready for review December 1, 2025 11:29

elena-shostak requested review from a team as code owners December 1, 2025 11:29

Merge branch 'main' into 239385-fs-usage-sample-ingest

46fa357

SiddharthMantri self-requested a review December 1, 2025 13:25

SiddharthMantri approved these changes Dec 3, 2025

View reviewed changes

yansavitski approved these changes Dec 8, 2025

View reviewed changes

yansavitski and others added 2 commits December 8, 2025 14:26

Merge branch 'main' into 239385-fs-usage-sample-ingest

457840c

Merge branch 'main' into 239385-fs-usage-sample-ingest

08f88e5

elena-shostak merged commit e7ebe47 into elastic:main Dec 8, 2025
12 checks passed

kibanamachine added the v9.3.0 label Dec 8, 2025

elena-shostak removed v8.19.8 v9.1.8 labels Dec 9, 2025

elena-shostak mentioned this pull request Dec 9, 2025

[9.2] [FSH] Migrated fs usage to kbn/fs for sample ingest (#244163) #245613

Merged

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 10, 2025

kibanamachine added v9.2.3 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 11, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FSH] Migrated fs usage to kbn/fs for sample ingest#244163

[FSH] Migrated fs usage to kbn/fs for sample ingest#244163
elena-shostak merged 19 commits intoelastic:mainfrom
elena-shostak:239385-fs-usage-sample-ingest

elena-shostak commented Nov 25, 2025 •

edited by kibanamachine

Loading

Uh oh!

elena-shostak Dec 1, 2025

Uh oh!

elena-shostak Dec 1, 2025

Uh oh!

elasticmachine commented Dec 1, 2025

Uh oh!

SiddharthMantri left a comment

Uh oh!

yansavitski left a comment

Uh oh!

elasticmachine commented Dec 8, 2025

API count

Uh oh!

Uh oh!

kibanamachine commented Dec 8, 2025

Uh oh!

kibanamachine commented Dec 8, 2025 •

edited by elena-shostak

Loading

Uh oh!

elena-shostak commented Dec 9, 2025

Uh oh!

kibanamachine commented Dec 10, 2025

Uh oh!

kibanamachine commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

elena-shostak commented Nov 25, 2025 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

elena-shostak Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

elena-shostak Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 1, 2025

Uh oh!

SiddharthMantri left a comment

Choose a reason for hiding this comment

Uh oh!

yansavitski left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 8, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Public APIs missing comments

API count

History

Uh oh!

Uh oh!

kibanamachine commented Dec 8, 2025

Uh oh!

kibanamachine commented Dec 8, 2025 • edited by elena-shostak Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 All backports failed

Manual backport

Questions ?

Uh oh!

elena-shostak commented Dec 9, 2025

💚 All backports created successfully

Questions ?

Uh oh!

kibanamachine commented Dec 10, 2025

Uh oh!

kibanamachine commented Dec 11, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

elena-shostak commented Nov 25, 2025 •

edited by kibanamachine

Loading

kibanamachine commented Dec 8, 2025 •

edited by elena-shostak

Loading