Skip to content

Fix Discover trace waterfall behavior with duplicate spans#244984

Merged
smith merged 8 commits intoelastic:mainfrom
smith:nls/dupspan
Dec 8, 2025
Merged

Fix Discover trace waterfall behavior with duplicate spans#244984
smith merged 8 commits intoelastic:mainfrom
smith:nls/dupspan

Conversation

@smith
Copy link
Copy Markdown
Contributor

@smith smith commented Dec 2, 2025 •
edited by kibanamachine
Loading

Fixes #244238.

Collapse query for trace items by span ID. Removes duplicates from query response.

@smith smith added release_note:fix backport:all-open Backport to all branches that could still receive a release labels Dec 2, 2025
@smith smith requested a review from a team December 3, 2025 02:01
@smith smith marked this pull request as ready for review December 3, 2025 02:01
@smith smith requested a review from a team as a code owner December 3, 2025 02:01
@smith smith removed the request for review from a team December 3, 2025 02:04
@rmyz rmyz added Team:obs-exploration Observability Exploration team Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation labels Dec 3, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 3, 2025

Pinging @elastic/obs-presentation-team (Team:obs-presentation)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 4, 2025

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@smith smith enabled auto-merge (squash) December 8, 2025 15:19
@smith smith merged commit a3bd73f into elastic:main Dec 8, 2025
12 checks passed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 8, 2025

Starting backport for target branches: 8.19, 9.1, 9.2

https://github.com/elastic/kibana/actions/runs/20036375009

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2025
@smith
Fix Discover trace waterfall behavior with duplicate spans (elastic#2…
52311b8 
…44984)

Fixes elastic#244238.

Collapse query for trace items by span ID. Removes duplicates from query
response.

(cherry picked from commit a3bd73f)
@kibanamachine kibanamachine mentioned this pull request Dec 8, 2025
Closed
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 8, 2025
@smith
Fix Discover trace waterfall behavior with duplicate spans (elastic#2…
d5b1fbf 
…44984)

Fixes elastic#244238.

Collapse query for trace items by span ID. Removes duplicates from query
response.

(cherry picked from commit a3bd73f)
@kibanamachine kibanamachine mentioned this pull request Dec 8, 2025
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 8, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
✅ 9.1
✅ 9.2

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 244984

Questions ?

Please refer to the Backport tool documentation

@smith
Copy link
Copy Markdown
Contributor Author

smith commented Dec 18, 2025

8.19 and 9.1 backports failed becuse of a test that exists there but not in 9.2+.

Closing those backports since the customer experiencing this issue is on 9.2. Can reopen them later if demand exists.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 18, 2025
@smith
Fix Discover trace waterfall behavior with duplicate spans (elastic#2…
d158b62 
…44984)

Fixes elastic#244238.

Collapse query for trace items by span ID. Removes duplicates from query
response.

(cherry picked from commit a3bd73f)
@kibanamachine kibanamachine mentioned this pull request Dec 18, 2025
Closed
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 18, 2025

💔 Some backports could not be created

Status Branch Result
❌ 8.19 Backport failed because of merge conflicts
✅ 9.1
❌ 9.2 Cherrypick failed because the selected commit (a3bd73f) is empty. It looks like the commit was already backported in #245556
❌ 9.3 Cherrypick failed because the selected commit (a3bd73f) is empty. Did you already backport this commit?

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 244984

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 19, 2025
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 19, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

22 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 22, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 23, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 24, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 25, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 26, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 29, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 30, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 31, 2025

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 2, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 5, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 6, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 7, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 8, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 9, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 12, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 13, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 14, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 15, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 16, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 19, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 20, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 21, 2026

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.
cc: @smith

@smith smith deleted the nls/dupspan branch January 21, 2026 17:26
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miloszmarcinkowski miloszmarcinkowski miloszmarcinkowski approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels release_note:fix Team:obs-exploration Observability Exploration team Team:obs-presentation Focus: APM UI, Infra UI, Hosts UI, Universal Profiling, Obs Overview and left Navigation v9.2.3 v9.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Discover][Traces] Waterfall fails to load with duplicate identical spans

5 participants

@smith @elasticmachine @kibanamachine @miloszmarcinkowski @rmyz