Skip to content

Fix canvas plugin directory regression#24049

Merged
rashidkpc merged 1 commit intoelastic:masterfrom
rashidkpc:canvas/plugin_dirs
Oct 16, 2018
Merged

Fix canvas plugin directory regression#24049
rashidkpc merged 1 commit intoelastic:masterfrom
rashidkpc:canvas/plugin_dirs

Conversation

@rashidkpc
Copy link
Copy Markdown
Contributor

Summary

When we merged into x-pack we forgot to point the plugin loading code back at the right directory. This does that.

@rashidkpc rashidkpc added v7.0.0 v6.5.0 Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// labels Oct 15, 2018
@rashidkpc rashidkpc requested a review from w33ble October 15, 2018 21:28
Copy link
Copy Markdown
Contributor

@w33ble w33ble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@rashidkpc
Copy link
Copy Markdown
Contributor Author

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@rashidkpc rashidkpc merged commit 3a7f5f5 into elastic:master Oct 16, 2018
@rashidkpc
Copy link
Copy Markdown
Contributor Author

That backport though: 97c9f52

spalger pushed a commit that referenced this pull request Oct 16, 2018
spalger pushed a commit that referenced this pull request Oct 16, 2018
* Revert "Proofreading edits, UI text consistency (#24016)"

This reverts commit f59f1cc.

* Revert "Skip these tests (#24085)"

This reverts commit e79533d.

* Revert "Point at kibana directory for plugin loading (#24049)"

This reverts commit 3a7f5f5.

* Revert "Translate pie and vaslib_basic_options (#23761)"

This reverts commit 1f73ea1.

* Revert "doing config migration during config get if necessary (#23377)"

This reverts commit 0b4f82d.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v6.5.0 v7.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants