Proofreading edits, UI text consistency#24016
Merged
ryankeairns merged 1 commit intoelastic:masterfrom Oct 16, 2018
Merged
Conversation
b6c46e3 to
d1fee80
Compare
Contributor
💚 Build Succeeded |
Contributor
|
@ryankeairns you're good to merge and backport this. Please do put version labels on your pulls though. |
ryankeairns
pushed a commit
to ryankeairns/kibana
that referenced
this pull request
Oct 16, 2018
rashidkpc
pushed a commit
that referenced
this pull request
Oct 16, 2018
spalger
pushed a commit
that referenced
this pull request
Oct 16, 2018
* Revert "Proofreading edits, UI text consistency (#24016)" This reverts commit f59f1cc. * Revert "Skip these tests (#24085)" This reverts commit e79533d. * Revert "Point at kibana directory for plugin loading (#24049)" This reverts commit 3a7f5f5. * Revert "Translate pie and vaslib_basic_options (#23761)" This reverts commit 1f73ea1. * Revert "doing config migration during config get if necessary (#23377)" This reverts commit 0b4f82d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23847
Summary
@gchaps provided UI text edits in #23847 , this addresses those recommendations as well as other similar occurrences throughout Canvas. Namely sentence casing on display titles and no ending punctuation on help text.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatability, including a check against IE11Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature additition or change that requires a release note and was labeled appropriately