doing config migration during config get if necessary#23377
doing config migration during config get if necessary#23377bmcconaghy merged 2 commits intoelastic:masterfrom
Conversation
💔 Build Failed |
|
retest |
1 similar comment
|
retest |
💚 Build Succeeded |
|
I've been looking into a specific edge case with this fix. Where by a @epixa And I are thinking about alternatives and options for getting this code to trigger the migration or handling the migration elsewhere or even options to removing the necessity of migrating configs between versions. I guess the question is is the current code at least useful for some users as is and if so when should we merge it. |
|
I think the most common scenario is that the admin of the ES stack will be the one to do the upgrade and would likely be the first to log in to Kibana and thus this code would do its work and all is good. So I think this code can be merged as is, and the better fix could follow in a subsequent PR. |
njd5475
left a comment
There was a problem hiding this comment.
This will help catch one of the migration edge cases. And should enhance the user experience.
* doing config migration during config get if necessary * fixing issue with writing new config when user does not have write privilege
* doing config migration during config get if necessary * fixing issue with writing new config when user does not have write privilege
| buildNum: this._buildNum, | ||
| log: this._log, | ||
| }); | ||
| } catch (e) { |
There was a problem hiding this comment.
We should really be checking this error to make sure it's what we expect. Otherwise we could be swallowing errors that indicate unexpected issues down the road.
* Revert "Proofreading edits, UI text consistency (#24016)" This reverts commit f59f1cc. * Revert "Skip these tests (#24085)" This reverts commit e79533d. * Revert "Point at kibana directory for plugin loading (#24049)" This reverts commit 3a7f5f5. * Revert "Translate pie and vaslib_basic_options (#23761)" This reverts commit 1f73ea1. * Revert "doing config migration during config get if necessary (#23377)" This reverts commit 0b4f82d.
Closes #22541
Fixing issue with migration and config not getting migrated to new version. This code makes it so if a config is missing, it gets migrated during _read.