Translate pie and vaslib_basic_options by tibmt · Pull Request #23761 · elastic/kibana

tibmt · 2018-10-03T14:59:10Z

issue #23257
Translation of Pie visualization component

elasticmachine · 2018-10-03T14:59:12Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

pavel06081991 · 2018-10-03T15:27:21Z

src/core_plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.html

+    <label
+      class="kuiSideBarFormRow__label"
+      for="visualizeBasicSettingsLegendPosition"
+      i18n-id="kbnVislibVisTypes.controls.vislibBasicOptions.legendPosition"


kbnVislibVisTypes.controls.vislibBasicOptions.legendPosition => kbnVislibVisTypes.controls.vislibBasicOptions.legendPositionLabel

pavel06081991 · 2018-10-03T15:27:42Z

src/core_plugins/kbn_vislib_vis_types/public/controls/vislib_basic_options.html

+    <label
+      class="kuiSideBarFormRow__label"
+      for="showTooltip"
+      i18n-id="kbnVislibVisTypes.controls.vislibBasicOptions.showTooltip"


kbnVislibVisTypes.controls.vislibBasicOptions.showTooltip => kbnVislibVisTypes.controls.vislibBasicOptions.showTooltipLabel

pavel06081991 · 2018-10-03T15:28:45Z

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html

    <div class="kuiSideBarSectionTitle">
      <div class="kuiSideBarSectionTitle__text">
-        Pie Settings
+        <span i18n-id="kbnVislibVisTypes.editors.pie.pieSettings" i18n-default-message="Pie Settings"></span>


do not create extra span tag, use <div class="kuiSideBarSectionTitle__text"> instead

pavel06081991 · 2018-10-03T15:29:38Z

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html

    <div class="kuiSideBarSectionTitle">
      <div class="kuiSideBarSectionTitle__text">
-        Pie Settings
+        <span i18n-id="kbnVislibVisTypes.editors.pie.pieSettings" i18n-default-message="Pie Settings"></span>


kbnVislibVisTypes.editors.pie.pieSettings => kbnVislibVisTypes.editors.pie.pieSettingsTitle

pavel06081991 · 2018-10-03T15:29:57Z

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html

+      <label
+        class="kuiSideBarFormRow__label"
+        for="isDonut"
+        i18n-id="kbnVislibVisTypes.editors.pie.donut"


kbnVislibVisTypes.editors.pie.donut => kbnVislibVisTypes.editors.pie.donutLabel

pavel06081991 · 2018-10-03T15:32:09Z

src/core_plugins/kbn_vislib_vis_types/public/editors/pie.html

+      <label
+        class="kuiSideBarFormRow__label"
+        for="truncateLabels"
+        i18n-id="kbnVislibVisTypes.editors.pie.truncate"


kbnVislibVisTypes.editors.pie.truncate => kbnVislibVisTypes.editors.pie.truncateLabel

src/core_plugins/kbn_vislib_vis_types/public/pie.js

pavel06081991 · 2018-10-03T15:38:51Z

src/core_plugins/kbn_vislib_vis_types/public/pie.js

          group: 'metrics',
          name: 'metric',
-          title: 'Slice Size',
+          title: i18n('kbnVislibVisTypes.pie.sliceSizeButtonLabel', { defaultMessage: 'Slice Size' }),


kbnVislibVisTypes.pie.sliceSizeButtonLabel => kbnVislibVisTypes.pie.metricTitle

pavel06081991 · 2018-10-03T15:39:32Z

src/core_plugins/kbn_vislib_vis_types/public/pie.js

          name: 'segment',
          icon: 'fa fa-scissors',
-          title: 'Split Slices',
+          title: i18n('kbnVislibVisTypes.pie.splitSlicesButtonLabel', { defaultMessage: 'Split Slices' }),


kbnVislibVisTypes.pie.segmentTitle'

pavel06081991 · 2018-10-03T15:39:52Z

src/core_plugins/kbn_vislib_vis_types/public/pie.js

          name: 'split',
          icon: 'fa fa-th',
-          title: 'Split Chart',
+          title: i18n('kbnVislibVisTypes.pie.splitChartButtonLabel', { defaultMessage: 'Split Chart' }),


kbnVislibVisTypes.pie.splitChartButtonLabel => kbnVislibVisTypes.pie.splitTitle

pavel06081991

LGTM

pavel06081991 · 2018-10-04T16:17:58Z

@tibmt please get access to this repository, after that merge master to your branch and add comment 'retest' it will run CI. When CI is green, merge it and backport to 6.x branch

elasticmachine · 2018-10-04T17:05:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-05T13:52:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-05T16:31:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

tibmt · 2018-10-08T08:24:04Z

retest

pavel06081991

LGTM

elasticmachine · 2018-10-08T10:02:03Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2018-10-08T13:25:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

timroes

Code LGTM

elasticmachine · 2018-10-15T12:01:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

tibmt · 2018-10-16T08:47:27Z

retest

elasticmachine · 2018-10-16T10:24:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

This reverts commit 1f73ea1.

* Revert "Proofreading edits, UI text consistency (#24016)" This reverts commit f59f1cc. * Revert "Skip these tests (#24085)" This reverts commit e79533d. * Revert "Point at kibana directory for plugin loading (#24049)" This reverts commit 3a7f5f5. * Revert "Translate pie and vaslib_basic_options (#23761)" This reverts commit 1f73ea1. * Revert "doing config migration during config get if necessary (#23377)" This reverts commit 0b4f82d.

Translate pie and vaslib_basic_options

Translate pie and vislib_basic_options

* Translations for Tag Cloud (#24065) * Translate pie and vaslib_basic_options (#23761) (#24124) Translate pie and vislib_basic_options * [I18n] Add one-time binding to angularjs i18n (#23499) (#23965) * Add one-time binding to angularjs i18n * Add watcher for values property * Watch values field only if it is provided * Fix ci * Translations for Tag Cloud (#24065)

Translate pie and vaslib_basic_options

553a0fe

pavel06081991 reviewed Oct 3, 2018

View reviewed changes

Translate pie and vaslib_basic_options

109bcfe

pavel06081991 approved these changes Oct 4, 2018

View reviewed changes

Merge branch 'master' into feature/translations/pie

2abfbb7

tibmt force-pushed the feature/translations/pie branch from 3951278 to 2abfbb7 Compare October 5, 2018 14:46

pavel06081991 approved these changes Oct 8, 2018

View reviewed changes

pavel06081991 requested a review from timroes October 8, 2018 08:42

Merge branch 'master' into feature/translations/pie

89bfc60

timroes approved these changes Oct 15, 2018

View reviewed changes

Merge branch 'master' into feature/translations/pie

598c95c

pavel06081991 added the Project:i18n label Oct 16, 2018

tibmt merged commit 1f73ea1 into elastic:master Oct 16, 2018

tibmt deleted the feature/translations/pie branch October 16, 2018 14:28

spalger pushed a commit that referenced this pull request Oct 16, 2018

Revert "Translate pie and vaslib_basic_options (#23761)"

4fe7d4f

This reverts commit 1f73ea1.

tibmt mentioned this pull request Oct 17, 2018

[6.x] Translate pie and vaslib_basic_options (#23761) #24124

Merged

tibmt added a commit to tibmt/kibana that referenced this pull request Oct 17, 2018

Translate pie and vaslib_basic_options (elastic#23761)

2155299

Translate pie and vaslib_basic_options

tibmt added a commit that referenced this pull request Oct 17, 2018

Translate pie and vaslib_basic_options (#23761) (#24124)

8df9757

Translate pie and vislib_basic_options

tibmt added the backported label Oct 18, 2018

Conversation

tibmt commented Oct 3, 2018 • edited by pavel06081991 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Oct 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pavel06081991 left a comment

Choose a reason for hiding this comment

Uh oh!

pavel06081991 commented Oct 4, 2018

Uh oh!

elasticmachine commented Oct 4, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 5, 2018

💚 Build Succeeded

Uh oh!

elasticmachine commented Oct 5, 2018

💔 Build Failed

Uh oh!

tibmt commented Oct 8, 2018

Uh oh!

pavel06081991 left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 8, 2018

💔 Build Failed

Uh oh!

elasticmachine commented Oct 8, 2018

💚 Build Succeeded

Uh oh!

timroes left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Oct 15, 2018

💔 Build Failed

Uh oh!

tibmt commented Oct 16, 2018

Uh oh!

elasticmachine commented Oct 16, 2018

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tibmt commented Oct 3, 2018 •

edited by pavel06081991

Loading