Remove observability:logsExplorer:allowedDataViews advanced setting#209120
Merged
gbamparop merged 5 commits intoelastic:mainfrom Feb 6, 2025
Merged
Remove observability:logsExplorer:allowedDataViews advanced setting#209120gbamparop merged 5 commits intoelastic:mainfrom
gbamparop merged 5 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
gbamparop
commented
Feb 3, 2025
| core.uiSettings.get(OBSERVABILITY_LOGS_EXPLORER_ALLOWED_DATA_VIEWS_ID) | ||
| ), | ||
| [core.uiSettings] | ||
| (dataView) => dataView.testAgainstAllowedList(DEFAULT_ALLOWED_LOGS_BASE_PATTERNS), |
Contributor
Author
There was a problem hiding this comment.
Replaced all setting usages with this constant, the code for Logs Explorer is not used and will be removed anyways but it's outside the scope of this issue.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
/ci |
tonyghiani
approved these changes
Feb 4, 2025
Contributor
tonyghiani
left a comment
There was a problem hiding this comment.
LGTM 👌
As a side note, shall we plan the code removal for the observability_logs_explorer and logs_explorer plugins? Their start contract + exported code still load quite a bit of code that will never be used.
Contributor
Author
@tonyghiani yes, I think we should follow up with #209261 |
dominiqueclarke
approved these changes
Feb 5, 2025
Contributor
dominiqueclarke
left a comment
There was a problem hiding this comment.
obs ux management changes LGTM
jloleysens
approved these changes
Feb 6, 2025
Contributor
Author
|
@elasticmachine merge upstream |
Dosant
approved these changes
Feb 6, 2025
Contributor
|
Starting backport for target branches: 9.0 |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Page load bundle
History
|
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by elastic#178602 as Logs Explorer is [no longer available](elastic#203685) in Serverless and 9.0. Closes elastic#209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 3e5f55d)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 6, 2025
…ting (#209120) (#210005) # Backport This will backport the following commits from `main` to `9.0`: - [Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)](#209120) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Giorgos Bamparopoulos","email":"georgios.bamparopoulos@elastic.co"},"sourceCommit":{"committedDate":"2025-02-06T13:28:00Z","message":"Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)\n\n## 📓 Summary\r\nRemoves the `observability:logsExplorer:allowedDataViews` advanced\r\nsetting that was introduced by\r\nhttps://github.com//pull/178602 as Logs Explorer is [no\r\nlonger available](#203685) in\r\nServerless and 9.0.\r\n\r\nCloses https://github.com/elastic/kibana/issues/209092\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3e5f55dd0258646d976d776127e39bdb04859568","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v9.1.0"],"title":"Remove observability:logsExplorer:allowedDataViews advanced setting","number":209120,"url":"https://github.com/elastic/kibana/pull/209120","mergeCommit":{"message":"Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)\n\n## 📓 Summary\r\nRemoves the `observability:logsExplorer:allowedDataViews` advanced\r\nsetting that was introduced by\r\nhttps://github.com//pull/178602 as Logs Explorer is [no\r\nlonger available](#203685) in\r\nServerless and 9.0.\r\n\r\nCloses https://github.com/elastic/kibana/issues/209092\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3e5f55dd0258646d976d776127e39bdb04859568"}},"sourceBranch":"main","suggestedTargetBranches":["9.0"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/209120","number":209120,"mergeCommit":{"message":"Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)\n\n## 📓 Summary\r\nRemoves the `observability:logsExplorer:allowedDataViews` advanced\r\nsetting that was introduced by\r\nhttps://github.com//pull/178602 as Logs Explorer is [no\r\nlonger available](#203685) in\r\nServerless and 9.0.\r\n\r\nCloses https://github.com/elastic/kibana/issues/209092\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"3e5f55dd0258646d976d776127e39bdb04859568"}}]}] BACKPORT--> Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
…lastic#209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by elastic#178602 as Logs Explorer is [no longer available](elastic#203685) in Serverless and 9.0. Closes elastic#209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📓 Summary
Removes the
observability:logsExplorer:allowedDataViewsadvanced setting that was introduced by #178602 as Logs Explorer is no longer available in Serverless and 9.0.Closes #209092