[Logs Explorer] Add settings for Logs Explorer features by tonyghiani · Pull Request #178602 · elastic/kibana

tonyghiani · 2024-03-13T09:14:53Z

📓 Summary

This work supports a new Logs Explorer UI setting to customize the data view patterns which allow to browse data views directly in Logs Explorer. It's a follow-up work of #176078, where we introduced a way to recognise logs-backed data views and explore their entires without redirecting to Discover.

The previously hard-coded list of allowed patterns (logs, auditbeat, filebeat, winbeat) is now used as the default value for the UI setting "Logs Explorer allowed data views", where is possible to add more base patterns or full indices that should be available for exploration in Logs Explorer.

🎥 Demo

demo.mov

👣 Next steps

Create a dashboard to track the updates on this setting and link it to the team docs.

ghost · 2024-03-13T09:15:06Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
/oblt-deploy-serverless : Deploy a serverless Kibana instance using the Observability test environments.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

tonyghiani · 2024-03-13T09:40:55Z

x-pack/plugins/observability_solution/logs_explorer/common/data_views/utils.ts

 export const buildIndexPatternRegExp = (basePatterns: string[]) => {
  // Create the base patterns union with strict boundaries
-  const basePatternGroup = `\\b(${basePatterns.join('|')})\\b[^,\\s]+`;
+  const basePatternGroup = `\\b(${basePatterns.join('|')})\\b([^,\\s]+)?`;


note: update the regex also to match standalone indices with no wildcard patterns.

tonyghiani · 2024-03-13T11:13:48Z

...lugins/observability_solution/logs_explorer/common/data_views/models/data_view_descriptor.ts

    };
  }

+  testAgainstAllowedList(allowedList: string[]) {


note: I opted for an approach where a setting preference is not coupled to this entity to make decisions on the user journey flow. Ideally, we'll conditionally be able to make decisions against a data view based on any setting passed, without affecting the inner shape of this entity.

tonyghiani · 2024-03-13T11:41:27Z

...y_solution/logs_explorer/public/state_machines/data_views/src/services/data_views_service.ts

note: Just moved some code from the state machine config into a service module, nothing new here on the implemented logic.

…fix'

…-fix'

elasticmachine · 2024-03-14T09:18:49Z

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

tonyghiani · 2024-03-14T09:24:51Z

/oblt-deploy

sabarasaba

Management changes lgtm

maryam-saeidi

Added OBSERVABILITY_LOGS_EXPLORER_ALLOWED_DATA_VIEWS_ID serverless setting LGTM!

Dosant

shared-ux changes lgtm

mgiota

LGTM!

Kerry350

Nice work 🙌 LGTM, and thanks for the additional code comments.

kibana-ci · 2024-03-20T10:43:23Z

💚 Build Succeeded

Buildkite Build
Commit: b7e3cd5

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`logsExplorer`	683	684	+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`@kbn/management-settings-ids`	132	133	+1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`logsExplorer`	1.1MB	1.1MB	+849.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`logsExplorer`	56.1KB	56.2KB	+130.0B

Unknown metric groups

API count

id	before	after	diff
`@kbn/management-settings-ids`	135	136	+1

History

💔 Build #198436 failed 0c3cae5
💛 Build #198203 was flaky b06d451
💛 Build #197996 was flaky 4c8958d
💚 Build #197625 succeeded 933fb20
💔 Build #197612 failed 6500ac5
💔 Build #197474 failed 9e6c979

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by #178602 as Logs Explorer is [no longer available](#203685) in Serverless and 9.0. Closes #209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…lastic#209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by elastic#178602 as Logs Explorer is [no longer available](elastic#203685) in Serverless and 9.0. Closes elastic#209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 3e5f55d)

…ting (#209120) (#210005) # Backport This will backport the following commits from `main` to `9.0`: - [Remove observability:logsExplorer:allowedDataViews advanced setting (#209120)](#209120)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Giorgos Bamparopoulos <georgios.bamparopoulos@elastic.co>

…lastic#209120) ## 📓 Summary Removes the `observability:logsExplorer:allowedDataViews` advanced setting that was introduced by elastic#178602 as Logs Explorer is [no longer available](elastic#203685) in Serverless and 9.0. Closes elastic#209092 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Marco Antonio Ghiani added 5 commits March 12, 2024 12:19

refactor(logs-explorer): remove unused files

678ad69

feature(logs-explorer): enable allowed data views on logs explorer

ac9894f

refactor(logs-explorer): minor renaming

2652f80

refactor(logs-explorer): improve regex to match standalone indices

4b83e2c

refactor(logs-explorer): remove imoports

f6d3ec8

tonyghiani added release_note:skip Skip the PR/issue when compiling release notes Team:obs-onboarding Observability Onboarding Team Feature:LogsExplorer Logs Explorer feature labels Mar 13, 2024

Marco Antonio Ghiani added 2 commits March 13, 2024 10:16

refactor(logs-explorer): rename setting

b9b03f7

refactor(logs-explorer): split logs allowed list into own defaults

777f337

tonyghiani commented Mar 13, 2024

View reviewed changes

Marco Antonio Ghiani added 2 commits March 13, 2024 10:45

refactor(logs-explorer): update description

892d5e6

refactor(logs-explorer): add setting to serverless

a481fa9

tonyghiani commented Mar 13, 2024

View reviewed changes

Marco Antonio Ghiani and others added 8 commits March 13, 2024 12:58

refactor(logs-explorer): update state machine guards

f0b07d9

Merge branch 'main' into 177703-logs-explorer-settings

521fc80

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

bfad892

…fix'

Merge branch 'main' into 177703-logs-explorer-settings

9e6c979

refactor(logs-explorer): update state machine guards

bf710d0

Merge branch 'main' into 177703-logs-explorer-settings

6500ac5

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

9b4b787

…-fix'

test(logs-explorer): update tests for data source selection

933fb20

tonyghiani marked this pull request as ready for review March 14, 2024 09:18

tonyghiani requested review from a team as code owners March 14, 2024 09:18

pgayvallet approved these changes Mar 14, 2024

View reviewed changes

tonyghiani added 2 commits March 18, 2024 14:34

Merge branch 'main' into 177703-logs-explorer-settings

4c8958d

Merge branch 'main' into 177703-logs-explorer-settings

b06d451

tonyghiani requested a review from a team as a code owner March 19, 2024 08:43

sabarasaba approved these changes Mar 19, 2024

View reviewed changes

maryam-saeidi approved these changes Mar 19, 2024

View reviewed changes

Dosant approved these changes Mar 19, 2024

View reviewed changes

mgiota approved these changes Mar 19, 2024

View reviewed changes

Kerry350 self-requested a review March 19, 2024 11:57

Kerry350 approved these changes Mar 19, 2024

View reviewed changes

tonyghiani added 2 commits March 20, 2024 08:38

Merge branch 'main' into 177703-logs-explorer-settings

0c3cae5

Merge branch 'main' into 177703-logs-explorer-settings

b7e3cd5

tonyghiani merged commit c8c3f19 into elastic:main Mar 20, 2024

tonyghiani deleted the 177703-logs-explorer-settings branch March 20, 2024 10:55

kibanamachine added v8.14.0 backport:skip This PR does not require backporting labels Mar 20, 2024

gbamparop mentioned this pull request Jan 31, 2025

Remove observability:logsExplorer:allowedDataViews advanced setting #209120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logs Explorer] Add settings for Logs Explorer features#178602

[Logs Explorer] Add settings for Logs Explorer features#178602
tonyghiani merged 21 commits intoelastic:mainfrom
tonyghiani:177703-logs-explorer-settings

tonyghiani commented Mar 13, 2024 •

edited

Loading

Uh oh!

ghost commented Mar 13, 2024

Uh oh!

tonyghiani Mar 13, 2024

Uh oh!

tonyghiani Mar 13, 2024

Uh oh!

tonyghiani Mar 13, 2024

Uh oh!

elasticmachine commented Mar 14, 2024

Uh oh!

tonyghiani commented Mar 14, 2024

Uh oh!

sabarasaba left a comment

Uh oh!

maryam-saeidi left a comment

Uh oh!

Dosant left a comment

Uh oh!

mgiota left a comment

Uh oh!

Kerry350 left a comment

Uh oh!

kibana-ci commented Mar 20, 2024

API count

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

tonyghiani commented Mar 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📓 Summary

🎥 Demo

👣 Next steps

Uh oh!

ghost commented Mar 13, 2024

🤖 GitHub comments

Uh oh!

tonyghiani Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

tonyghiani Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

tonyghiani Mar 13, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Mar 14, 2024

Uh oh!

tonyghiani commented Mar 14, 2024

Uh oh!

sabarasaba left a comment

Choose a reason for hiding this comment

Uh oh!

maryam-saeidi left a comment

Choose a reason for hiding this comment

Uh oh!

Dosant left a comment

Choose a reason for hiding this comment

Uh oh!

mgiota left a comment

Choose a reason for hiding this comment

Uh oh!

Kerry350 left a comment

Choose a reason for hiding this comment

Uh oh!

kibana-ci commented Mar 20, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Page load bundle

API count

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

tonyghiani commented Mar 13, 2024 •

edited

Loading