Remove kbn-ace, ace and brace dependencies#195703
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-management (Team:Kibana Management) |
dmlemeshko
left a comment
There was a problem hiding this comment.
packages/kbn-test changes LGTM
azasypkin
left a comment
There was a problem hiding this comment.
Changes in role_mappings/edit_role_mapping/rule_editor_panel/json_rule_editor LGTM and the editor still works as expected, thanks!
|
@elasticmachine merge upstream |
kertal
left a comment
There was a problem hiding this comment.
It seems @elastic/kibana-data-discovery was just pinged because of a data view test change, code owner review. LGTM. Congratulations on removing code 🎉 !
💚 Build Succeeded
Metrics [docs]Module Count
Public APIs missing comments
Any counts in public APIs
Async chunks
Page load bundle
Unknown metric groupsAPI count
ESLint disabled in files
ESLint disabled line counts
Total ESLint disabled count
History
cc @sabarasaba |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
(cherry picked from commit d86ce77) # Conflicts: # .github/CODEOWNERS # api_docs/kbn_ace.mdx
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [Remove kbn-ace, ace and brace dependencies (#195703)](#195703) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ignacio Rivas","email":"rivasign@gmail.com"},"sourceCommit":{"committedDate":"2024-10-10T12:16:42Z","message":"Remove kbn-ace, ace and brace dependencies (#195703)","sha":"d86ce77217a26747b39ddf240e5703efba1a0cb0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"number":195703,"url":"https://github.com/elastic/kibana/pull/195703","mergeCommit":{"message":"Remove kbn-ace, ace and brace dependencies (#195703)","sha":"d86ce77217a26747b39ddf240e5703efba1a0cb0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195703","number":195703,"mergeCommit":{"message":"Remove kbn-ace, ace and brace dependencies (#195703)","sha":"d86ce77217a26747b39ddf240e5703efba1a0cb0"}},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
Closes #194533
Summary
With the effort started with #194533 and #155833 we have now finally migrated all instances of the Ace editor into Monaco and there are no more plugins that depend on it.
This PR removes kbn-package, ace and brace dependency from the kibana project.