Fix theme switch success toast layout#195717
Merged
kowalczyk-krzysztof merged 1 commit intoelastic:mainfrom Oct 10, 2024
Merged
Fix theme switch success toast layout#195717kowalczyk-krzysztof merged 1 commit intoelastic:mainfrom
kowalczyk-krzysztof merged 1 commit intoelastic:mainfrom
Conversation
0485dad to
3c4339a
Compare
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
3c4339a to
d53b169
Compare
sebelga
approved these changes
Oct 10, 2024
Contributor
sebelga
left a comment
There was a problem hiding this comment.
LGTM! 🎉 Tested locally and works as expected 👍
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
|
elena-shostak
approved these changes
Oct 10, 2024
Contributor
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 10, 2024
## Summary This PR fixes the layout of `Color theme updated` toast to match [EUI guidelines on success toasts](https://eui.elastic.co/#/display/toast#success). Fixes: elastic#165979 ## Visuals | Previous | New | |-----------------|-----------------| | |  | ### Checklist Delete any items that are not applicable to this PR. - [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) (cherry picked from commit 446ad94)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
This was referenced Oct 10, 2024
kibanamachine
added a commit
that referenced
this pull request
Oct 10, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Fix theme switch success toast layout (#195717)](#195717) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"krzysztof.kowalczyk@elastic.co"},"sourceCommit":{"committedDate":"2024-10-10T12:08:31Z","message":"Fix theme switch success toast layout (#195717)\n\n## Summary\r\n\r\nThis PR fixes the layout of `Color theme updated` toast to match [EUI\r\nguidelines on success\r\ntoasts](https://eui.elastic.co/#/display/toast#success).\r\n\r\nFixes: #165979 \r\n\r\n## Visuals\r\n| Previous | New |\r\n|-----------------|-----------------|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n \r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"446ad9475ba4d419066977f776b4fcd20f8a8cc0","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","Team:SharedUX","backport:prev-minor"],"title":"Fix theme switch success toast layout","number":195717,"url":"https://github.com/elastic/kibana/pull/195717","mergeCommit":{"message":"Fix theme switch success toast layout (#195717)\n\n## Summary\r\n\r\nThis PR fixes the layout of `Color theme updated` toast to match [EUI\r\nguidelines on success\r\ntoasts](https://eui.elastic.co/#/display/toast#success).\r\n\r\nFixes: #165979 \r\n\r\n## Visuals\r\n| Previous | New |\r\n|-----------------|-----------------|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n \r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"446ad9475ba4d419066977f776b4fcd20f8a8cc0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195717","number":195717,"mergeCommit":{"message":"Fix theme switch success toast layout (#195717)\n\n## Summary\r\n\r\nThis PR fixes the layout of `Color theme updated` toast to match [EUI\r\nguidelines on success\r\ntoasts](https://eui.elastic.co/#/display/toast#success).\r\n\r\nFixes: #165979 \r\n\r\n## Visuals\r\n| Previous | New |\r\n|-----------------|-----------------|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n \r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [x] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))","sha":"446ad9475ba4d419066977f776b4fcd20f8a8cc0"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <krzysztof.kowalczyk@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the layout of
Color theme updatedtoast to match EUI guidelines on success toasts.Fixes: #165979
Visuals
Checklist
Delete any items that are not applicable to this PR.