Skip to content

[8.x] Remove kbn-ace, ace and brace dependencies (#195703)#195765

Merged
sabarasaba merged 1 commit intoelastic:8.xfrom
sabarasaba:backport/8.x/pr-195703
Oct 11, 2024
Merged

[8.x] Remove kbn-ace, ace and brace dependencies (#195703)#195765
sabarasaba merged 1 commit intoelastic:8.xfrom
sabarasaba:backport/8.x/pr-195703

Conversation

@sabarasaba
Copy link
Copy Markdown
Member

@sabarasaba sabarasaba commented Oct 10, 2024

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

@sabarasaba sabarasaba added the backport This PR is a backport of another PR label Oct 10, 2024
@sabarasaba sabarasaba enabled auto-merge (squash) October 10, 2024 13:08
@sabarasaba sabarasaba mentioned this pull request Oct 10, 2024
Merged
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@sabarasaba
Copy link
Copy Markdown
Member Author

sabarasaba commented Oct 10, 2024

@elasticmachine merge upstream

@sabarasaba
Remove kbn-ace, ace and brace dependencies (elastic#195703)
07313ea 
(cherry picked from commit d86ce77)

# Conflicts:
#	.github/CODEOWNERS
#	api_docs/kbn_ace.mdx
@sabarasaba sabarasaba force-pushed the backport/8.x/pr-195703 branch from 8b762f6 to 07313ea Compare October 10, 2024 15:38
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 10, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1849 1850 +1
canvas 1285 1286 +1
cloudFullStory 11 12 +1
crossClusterReplication 134 133 -1
dashboard 665 666 +1
dataVisualizer 726 727 +1
esUiShared 241 220 -21
ingestPipelines 327 328 +1
integrationAssistant 564 565 +1
lens 1462 1463 +1
ml 2033 2034 +1
savedObjectsManagement 114 115 +1
security 527 524 -3
share 92 93 +1
stackAlerts 161 160 -1
visDefaultEditor 205 203 -2
total -17

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/ace 11 - -11

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id before after diff
@kbn/ace 5 - -5

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 3.5MB 3.5MB +48.0B
canvas 1.1MB 1.1MB +48.0B
cloudFullStory 13.5KB 17.6KB +4.1KB
crossClusterReplication 148.8KB 146.2KB -2.6KB
dashboard 627.5KB 637.0KB +9.5KB
dataVisualizer 613.8KB 613.9KB +48.0B
ingestPipelines 375.3KB 375.3KB +48.0B
integrationAssistant 949.2KB 949.3KB +49.0B
lens 1.5MB 1.5MB +48.0B
ml 4.5MB 4.5MB +48.0B
savedObjectsManagement 84.5KB 84.6KB +49.0B
security 590.9KB 541.7KB -49.2KB
stackAlerts 75.7KB 73.5KB -2.1KB
visDefaultEditor 142.3KB 95.3KB -47.0KB
total -87.0KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
core 455.8KB 449.4KB -6.3KB
esUiShared 158.2KB 106.5KB -51.7KB
kbnUiSharedDeps-npmDll 6.2MB 5.8MB -417.3KB
share 57.1KB 57.2KB +51.0B
total -475.3KB
Unknown metric groups

API count

id before after diff
@kbn/ace 11 - -11

ESLint disabled in files

id before after diff
@kbn/ace 1 - -1

ESLint disabled line counts

id before after diff
@kbn/ace 1 - -1

Total ESLint disabled count

id before after diff
@kbn/ace 2 - -2

History

  • 💔 Build #241174 failed 8b762f6693500e51b689ab863458a7d55d1552d1
  • 💔 Build #241155 failed aacf4c1fdc2fdbcc9994945848e9d405414e868c

ElenaStoeva
ElenaStoeva approved these changes Oct 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sabarasaba sabarasaba merged commit ffa3e09 into elastic:8.x Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ElenaStoeva ElenaStoeva ElenaStoeva approved these changes

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sabarasaba @elasticmachine @ElenaStoeva