Skip to content

Removes supertest and superuser from platform security serverless API tests#194922

Merged
jeramysoucy merged 6 commits intoelastic:mainfrom
jeramysoucy:remove-superuser-supertest
Oct 10, 2024
Merged

Removes supertest and superuser from platform security serverless API tests#194922
jeramysoucy merged 6 commits intoelastic:mainfrom
jeramysoucy:remove-superuser-supertest

Conversation

@jeramysoucy
Copy link
Copy Markdown
Contributor

@jeramysoucy jeramysoucy commented Oct 4, 2024 •
edited
Loading

Closes #186467

Summary

Removes remaining usages of supertest and superuser from platform security serverless API tests. Utilizes admin privileges when testing disabled routes, viewer privileges for all other routes. Uses cookie authentication for internal API calls.

Tests

@jeramysoucy jeramysoucy added Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Project:Serverless Work as part of the Serverless project for its initial release v8.16.0 labels Oct 4, 2024
@jeramysoucy jeramysoucy marked this pull request as ready for review October 4, 2024 12:41
@jeramysoucy jeramysoucy requested a review from a team as a code owner October 4, 2024 12:41
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 4, 2024

Pinging @elastic/kibana-security (Team:Security)

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented Oct 4, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #73 / Reporting Functional Tests with Security enabled Access to Management > Reporting Download report user can access download link
  • [job] [logs] Jest Integration Tests #3 / unrecognized task types should be no workload aggregator errors when there are removed task types

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 4, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7089

[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/security/common_configs/config.group1.ts: 50/50 tests passed.

see run history

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 4, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7088

[✅] x-pack/test_serverless/api_integration/test_suites/search/common_configs/config.group1.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/observability/common_configs/config.group1.ts: 50/50 tests passed.
[✅] x-pack/test_serverless/api_integration/test_suites/security/common_configs/config.group1.ts: 50/50 tests passed.

see run history

@jeramysoucy jeramysoucy requested a review from a team as a code owner October 8, 2024 16:26
@jeramysoucy jeramysoucy enabled auto-merge (squash) October 8, 2024 16:26
@jeramysoucy jeramysoucy disabled auto-merge October 8, 2024 16:27
@jeramysoucy jeramysoucy removed the request for review from a team October 9, 2024 12:22
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 10, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

@jeramysoucy jeramysoucy merged commit 8ea2846 into elastic:main Oct 10, 2024
@kibanamachine kibanamachine mentioned this pull request Oct 10, 2024
Merged
@wayneseymour wayneseymour mentioned this pull request Oct 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SiddharthMantri SiddharthMantri SiddharthMantri approved these changes

Assignees

No one assigned

Labels

backport:skip This PR does not require backporting Project:Serverless Work as part of the Serverless project for its initial release release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update serverless roles API tests

5 participants

@jeramysoucy @elasticmachine @kibana-ci @kibanamachine @SiddharthMantri