Skip to content

Upgrade Markdown-it to 14.1.0#182244

Merged
kc13greiner merged 3 commits intoelastic:mainfrom
kc13greiner:feature/upgrade-markdown-it-main
May 1, 2024
Merged

Upgrade Markdown-it to 14.1.0#182244
kc13greiner merged 3 commits intoelastic:mainfrom
kc13greiner:feature/upgrade-markdown-it-main

Conversation

@kc13greiner
Copy link
Copy Markdown
Contributor

@kc13greiner kc13greiner commented May 1, 2024

Summary

Upgrade markdown-it to 14.1.0 in main

@kc13greiner kc13greiner added chore Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:all-open Backport to all branches that could still receive a release labels May 1, 2024
@kc13greiner kc13greiner self-assigned this May 1, 2024
@kc13greiner
Copy link
Copy Markdown
Contributor Author

/ci

@kc13greiner
Copy link
Copy Markdown
Contributor Author

/ci

@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
kibanaReact 266 214 -52
visTypeVega 322 270 -52
visTypeVislib 178 126 -52
total -156

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
kibanaReact 165.6KB 197.2KB +31.6KB
visTypeVega 1.8MB 1.8MB +31.5KB
visTypeVislib 339.9KB 371.6KB +31.7KB
total +94.8KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
visTypeVislib 15.3KB 15.3KB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @kc13greiner

@kc13greiner kc13greiner marked this pull request as ready for review May 1, 2024 16:23
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-security (Team:Security)

@kc13greiner kc13greiner merged commit 126410c into elastic:main May 1, 2024
@kc13greiner kc13greiner deleted the feature/upgrade-markdown-it-main branch May 1, 2024 17:18
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 1, 2024

7.17 PR was already merged

Status Branch Result
7.17
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

@kc13greiner kc13greiner added backport:prev-minor and removed backport:all-open Backport to all branches that could still receive a release labels May 1, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
## Summary

Upgrade `markdown-it` to `14.1.0` in `main`

(cherry picked from commit 126410c)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jbudz added a commit to jbudz/kibana that referenced this pull request May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244.  This
updates the webpack configuration to only load files from the browser
and main properties.
@jbudz jbudz mentioned this pull request May 1, 2024
kibanamachine added a commit that referenced this pull request May 1, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Upgrade Markdown-it to 14.1.0
(#182244)](#182244)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Kurt","email":"kc13greiner@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-05-01T17:18:21Z","message":"Upgrade
Markdown-it to 14.1.0 (#182244)\n\n## Summary\r\n\r\nUpgrade
`markdown-it` to `14.1.0` in
`main`","sha":"126410ccfb39c6ec7c4b4f412211385b8edec6a3","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Security","release_note:skip","backport:all-open","v8.15.0"],"title":"Upgrade
Markdown-it to
14.1.0","number":182244,"url":"https://github.com/elastic/kibana/pull/182244","mergeCommit":{"message":"Upgrade
Markdown-it to 14.1.0 (#182244)\n\n## Summary\r\n\r\nUpgrade
`markdown-it` to `14.1.0` in
`main`","sha":"126410ccfb39c6ec7c4b4f412211385b8edec6a3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182244","number":182244,"mergeCommit":{"message":"Upgrade
Markdown-it to 14.1.0 (#182244)\n\n## Summary\r\n\r\nUpgrade
`markdown-it` to `14.1.0` in
`main`","sha":"126410ccfb39c6ec7c4b4f412211385b8edec6a3"}}]}]
BACKPORT-->

Co-authored-by: Kurt <kc13greiner@users.noreply.github.com>
mistic pushed a commit that referenced this pull request May 1, 2024
Storybook is attempting to load an esm after the merge of #182244. This
updates the webpack configuration to only load files from the browser
and main properties.
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244. This
updates the webpack configuration to only load files from the browser
and main properties.

(cherry picked from commit 869402b)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244. This
updates the webpack configuration to only load files from the browser
and main properties.

(cherry picked from commit 869402b)
kibanamachine added a commit that referenced this pull request May 1, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Fix storybook config
(#182283)](#182283)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-05-01T19:35:08Z","message":"Fix
storybook config (#182283)\n\nStorybook is attempting to load an esm
after the merge of #182244. This\r\nupdates the webpack configuration to
only load files from the browser\r\nand main
properties.","sha":"869402b831858240250ceb89bee1929f6cca074c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","ci:build-storybooks","v8.15.0"],"title":"Fix
storybook
config","number":182283,"url":"https://github.com/elastic/kibana/pull/182283","mergeCommit":{"message":"Fix
storybook config (#182283)\n\nStorybook is attempting to load an esm
after the merge of #182244. This\r\nupdates the webpack configuration to
only load files from the browser\r\nand main
properties.","sha":"869402b831858240250ceb89bee1929f6cca074c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182283","number":182283,"mergeCommit":{"message":"Fix
storybook config (#182283)\n\nStorybook is attempting to load an esm
after the merge of #182244. This\r\nupdates the webpack configuration to
only load files from the browser\r\nand main
properties.","sha":"869402b831858240250ceb89bee1929f6cca074c"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
TinLe added a commit to TinLe/kibana that referenced this pull request May 1, 2024
* master: (1654 commits)
  Bump ejs from 3.1.9 to 3.1.10
  Don't render exceptions flyout if data is loading (elastic#181588)
  Enable value list modal (elastic#181593)
  skip flaky suite (elastic#181777)
  skip failing test suite (elastic#182263)
  [Mappings Editor] Disable _source field in serverless (elastic#181712)
  [data.search] Fix unhandled promise rejections (elastic#181785)
  [Fleet] Fix logic for detecting first time Elastic Agent users (elastic#182214)
  [ML] Decouple data_visualizer from MapEmbeddable (elastic#181928)
  [ES|QL] Sorting accepts expressions (elastic#181916)
  [ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation (elastic#182176)
  Adding optional Description field to Roles APIs (elastic#182039)
  Upgrade Markdown-it to 14.1.0 (elastic#182244)
  Bump xml-crypto from 5.0.0 to 6.0.0
  [DOCS] Fix docs and screenshots for rule creation changes (elastic#181925)
  Update dependency elastic-apm-node to ^4.5.3 (main) (elastic#182236)
  [Obs AI Assistant] register alert details context in observability plugin (elastic#181501)
  Add `@typescript-eslint/no-floating-promises` (elastic#181456)
  [Playground] Propagate Error message into FE (elastic#182201)
  [ES|QL] Rename the setting to a more generic one and move to the general section (elastic#182074)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore release_note:skip Skip the PR/issue when compiling release notes Team:Security Platform Security: Auth, Users, Roles, Spaces, Audit Logging, etc t// v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants