Skip to content

Enable value list modal#181593

Merged
nkhristinin merged 6 commits intoelastic:mainfrom
nkhristinin:enable-value-list-moadl
May 1, 2024
Merged

Enable value list modal#181593
nkhristinin merged 6 commits intoelastic:mainfrom
nkhristinin:enable-value-list-moadl

Conversation

@nkhristinin
Copy link
Copy Markdown
Contributor

@nkhristinin nkhristinin commented Apr 24, 2024

Enable value list modal

@nkhristinin nkhristinin added release_note:skip Skip the PR/issue when compiling release notes ci:cloud-deploy Create or update a Cloud deployment labels Apr 24, 2024
@nkhristinin nkhristinin marked this pull request as ready for review April 24, 2024 15:34
@nkhristinin nkhristinin requested a review from a team as a code owner April 24, 2024 15:34
@nkhristinin
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@nkhristinin
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

* Enables the new modal for the value list items
*/
valueListItemsModalEnabled: false,
valueListItemsModalEnabled: true,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point!

@nkhristinin
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@nkhristinin nkhristinin requested a review from a team as a code owner May 1, 2024 10:28
@nkhristinin nkhristinin requested a review from e40pud May 1, 2024 10:28
@nkhristinin
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Copy Markdown

kibana-ci commented May 1, 2024

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@nkhristinin nkhristinin merged commit 813741f into elastic:main May 1, 2024
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
## Enable value list modal

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 813741f)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 1, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Enable value list modal
(#181593)](#181593)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Khristinin
Nikita","email":"nikita.khristinin@elastic.co"},"sourceCommit":{"committedDate":"2024-05-01T18:58:10Z","message":"Enable
value list modal (#181593)\n\n## Enable value list
modal\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"813741f2dfcce6d62faad10231bcf69ae6d7ffff","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:prev-minor","ci:cloud-deploy","v8.15.0"],"title":"Enable
value list
modal","number":181593,"url":"https://github.com/elastic/kibana/pull/181593","mergeCommit":{"message":"Enable
value list modal (#181593)\n\n## Enable value list
modal\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"813741f2dfcce6d62faad10231bcf69ae6d7ffff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/181593","number":181593,"mergeCommit":{"message":"Enable
value list modal (#181593)\n\n## Enable value list
modal\r\n\r\n---------\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"813741f2dfcce6d62faad10231bcf69ae6d7ffff"}}]}]
BACKPORT-->

Co-authored-by: Khristinin Nikita <nikita.khristinin@elastic.co>
TinLe added a commit to TinLe/kibana that referenced this pull request May 1, 2024
* master: (1654 commits)
  Bump ejs from 3.1.9 to 3.1.10
  Don't render exceptions flyout if data is loading (elastic#181588)
  Enable value list modal (elastic#181593)
  skip flaky suite (elastic#181777)
  skip failing test suite (elastic#182263)
  [Mappings Editor] Disable _source field in serverless (elastic#181712)
  [data.search] Fix unhandled promise rejections (elastic#181785)
  [Fleet] Fix logic for detecting first time Elastic Agent users (elastic#182214)
  [ML] Decouple data_visualizer from MapEmbeddable (elastic#181928)
  [ES|QL] Sorting accepts expressions (elastic#181916)
  [ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation (elastic#182176)
  Adding optional Description field to Roles APIs (elastic#182039)
  Upgrade Markdown-it to 14.1.0 (elastic#182244)
  Bump xml-crypto from 5.0.0 to 6.0.0
  [DOCS] Fix docs and screenshots for rule creation changes (elastic#181925)
  Update dependency elastic-apm-node to ^4.5.3 (main) (elastic#182236)
  [Obs AI Assistant] register alert details context in observability plugin (elastic#181501)
  Add `@typescript-eslint/no-floating-promises` (elastic#181456)
  [Playground] Propagate Error message into FE (elastic#182201)
  [ES|QL] Rename the setting to a more generic one and move to the general section (elastic#182074)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants