Skip to content

[Fleet] Fix logic for detecting first time Elastic Agent users#182214

Merged
jen-huang merged 3 commits intoelastic:mainfrom
jen-huang:fix/privilege/first-time
May 1, 2024
Merged

[Fleet] Fix logic for detecting first time Elastic Agent users#182214
jen-huang merged 3 commits intoelastic:mainfrom
jen-huang:fix/privilege/first-time

Conversation

@jen-huang
Copy link
Copy Markdown
Contributor

@jen-huang jen-huang commented May 1, 2024

Summary

Resolves #181800. Fixes the logic for detecting first time Elastic Agent users on Cloud so that the multi-page layout for adding an integration kicks in.

@jen-huang jen-huang added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0 labels May 1, 2024
@jen-huang jen-huang requested a review from nchaulet May 1, 2024 04:00
@jen-huang jen-huang self-assigned this May 1, 2024
@jen-huang jen-huang requested a review from a team as a code owner May 1, 2024 04:00
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/fleet (Team:Fleet)

@ghost
Copy link
Copy Markdown

ghost commented May 1, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@jen-huang
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@jen-huang
Copy link
Copy Markdown
Contributor Author

@elasticmachine merge upstream

@jen-huang jen-huang enabled auto-merge (squash) May 1, 2024 16:09
@kibana-ci
Copy link
Copy Markdown

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] x-pack/test/alerting_api_integration/security_and_spaces/group1/config.ts / alerting api integration security and spaces enabled Alerts - Group 1 alerts find public superuser at space1 should filter out types that the user is not authorized to get retaining pagination
  • [job] [logs] Jest Tests #7 / EditableMarkdown Save button click calls onSaveContent and onChangeEditable when text area value changed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.3MB 1.3MB -1.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@jen-huang jen-huang merged commit 63bc11a into elastic:main May 1, 2024
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
…ic#182214)

## Summary

Resolves elastic#181800. Fixes the
logic for detecting first time Elastic Agent users on Cloud so that the
multi-page layout for adding an integration kicks in.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 63bc11a)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 1, 2024
…#182214) (#182281)

# Backport

This will backport the following commits from `main` to `8.14`:
- [[Fleet] Fix logic for detecting first time Elastic Agent users
(#182214)](#182214)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Jen
Huang","email":"its.jenetic@gmail.com"},"sourceCommit":{"committedDate":"2024-05-01T17:47:53Z","message":"[Fleet]
Fix logic for detecting first time Elastic Agent users (#182214)\n\n##
Summary\r\n\r\nResolves #181800.
Fixes the\r\nlogic for detecting first time Elastic Agent users on Cloud
so that the\r\nmulti-page layout for adding an integration kicks
in.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"63bc11a02b0e25713a494bce8fdf225b64d94975","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","Team:Fleet","v8.14.0","v8.15.0"],"title":"[Fleet]
Fix logic for detecting first time Elastic Agent
users","number":182214,"url":"https://github.com/elastic/kibana/pull/182214","mergeCommit":{"message":"[Fleet]
Fix logic for detecting first time Elastic Agent users (#182214)\n\n##
Summary\r\n\r\nResolves #181800.
Fixes the\r\nlogic for detecting first time Elastic Agent users on Cloud
so that the\r\nmulti-page layout for adding an integration kicks
in.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"63bc11a02b0e25713a494bce8fdf225b64d94975"}},"sourceBranch":"main","suggestedTargetBranches":["8.14"],"targetPullRequestStates":[{"branch":"8.14","label":"v8.14.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182214","number":182214,"mergeCommit":{"message":"[Fleet]
Fix logic for detecting first time Elastic Agent users (#182214)\n\n##
Summary\r\n\r\nResolves #181800.
Fixes the\r\nlogic for detecting first time Elastic Agent users on Cloud
so that the\r\nmulti-page layout for adding an integration kicks
in.\r\n\r\nCo-authored-by: Kibana Machine
<42973632+kibanamachine@users.noreply.github.com>","sha":"63bc11a02b0e25713a494bce8fdf225b64d94975"}}]}]
BACKPORT-->

Co-authored-by: Jen Huang <its.jenetic@gmail.com>
TinLe added a commit to TinLe/kibana that referenced this pull request May 1, 2024
* master: (1654 commits)
  Bump ejs from 3.1.9 to 3.1.10
  Don't render exceptions flyout if data is loading (elastic#181588)
  Enable value list modal (elastic#181593)
  skip flaky suite (elastic#181777)
  skip failing test suite (elastic#182263)
  [Mappings Editor] Disable _source field in serverless (elastic#181712)
  [data.search] Fix unhandled promise rejections (elastic#181785)
  [Fleet] Fix logic for detecting first time Elastic Agent users (elastic#182214)
  [ML] Decouple data_visualizer from MapEmbeddable (elastic#181928)
  [ES|QL] Sorting accepts expressions (elastic#181916)
  [ML] Single Metric Viewer: ensures chart displays correctly when opening from a job annotation (elastic#182176)
  Adding optional Description field to Roles APIs (elastic#182039)
  Upgrade Markdown-it to 14.1.0 (elastic#182244)
  Bump xml-crypto from 5.0.0 to 6.0.0
  [DOCS] Fix docs and screenshots for rule creation changes (elastic#181925)
  Update dependency elastic-apm-node to ^4.5.3 (main) (elastic#182236)
  [Obs AI Assistant] register alert details context in observability plugin (elastic#181501)
  Add `@typescript-eslint/no-floating-promises` (elastic#181456)
  [Playground] Propagate Error message into FE (elastic#182201)
  [ES|QL] Rename the setting to a more generic one and move to the general section (elastic#182074)
  ...
@jen-huang jen-huang deleted the fix/privilege/first-time branch July 12, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Fleet]: New Add integration flow is not available on fresh kibana setup while adding first integration.

5 participants