Skip to content

Fix storybook config#182283

Merged
mistic merged 1 commit intoelastic:mainfrom
jbudz:fix-storybooks-main
May 1, 2024
Merged

Fix storybook config#182283
mistic merged 1 commit intoelastic:mainfrom
jbudz:fix-storybooks-main

Conversation

@jbudz
Copy link
Copy Markdown
Contributor

@jbudz jbudz commented May 1, 2024

Storybook is attempting to load an esm after the merge of #182244. This updates the webpack configuration to only load files from the browser and main properties.

Storybook is attempting to load an esm after the merge of elastic#182244.  This
updates the webpack configuration to only load files from the browser
and main properties.
@jbudz jbudz added Team:Operations Kibana-Operations Team release_note:skip Skip the PR/issue when compiling release notes ci:build-storybooks labels May 1, 2024
@jbudz jbudz requested a review from a team as a code owner May 1, 2024 18:26
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mistic mistic enabled auto-merge (squash) May 1, 2024 19:11
@mistic mistic added the backport:all-open Backport to all branches that could still receive a release label May 1, 2024
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit 869402b into elastic:main May 1, 2024
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244. This
updates the webpack configuration to only load files from the browser
and main properties.

(cherry picked from commit 869402b)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 1, 2024
Storybook is attempting to load an esm after the merge of elastic#182244. This
updates the webpack configuration to only load files from the browser
and main properties.

(cherry picked from commit 869402b)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
7.17
8.14

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request May 1, 2024
# Backport

This will backport the following commits from `main` to `8.14`:
- [Fix storybook config
(#182283)](#182283)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Jon","email":"jon@elastic.co"},"sourceCommit":{"committedDate":"2024-05-01T19:35:08Z","message":"Fix
storybook config (#182283)\n\nStorybook is attempting to load an esm
after the merge of #182244. This\r\nupdates the webpack configuration to
only load files from the browser\r\nand main
properties.","sha":"869402b831858240250ceb89bee1929f6cca074c","branchLabelMapping":{"^v8.15.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Operations","release_note:skip","backport:all-open","ci:build-storybooks","v8.15.0"],"title":"Fix
storybook
config","number":182283,"url":"https://github.com/elastic/kibana/pull/182283","mergeCommit":{"message":"Fix
storybook config (#182283)\n\nStorybook is attempting to load an esm
after the merge of #182244. This\r\nupdates the webpack configuration to
only load files from the browser\r\nand main
properties.","sha":"869402b831858240250ceb89bee1929f6cca074c"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.15.0","branchLabelMappingKey":"^v8.15.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/182283","number":182283,"mergeCommit":{"message":"Fix
storybook config (#182283)\n\nStorybook is attempting to load an esm
after the merge of #182244. This\r\nupdates the webpack configuration to
only load files from the browser\r\nand main
properties.","sha":"869402b831858240250ceb89bee1929f6cca074c"}}]}]
BACKPORT-->

Co-authored-by: Jon <jon@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:all-open Backport to all branches that could still receive a release backported ci:build-storybooks release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v8.14.0 v8.15.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants