[Custom branding] Add custom logo to space selector#150284
[Custom branding] Add custom logo to space selector#150284majagrubic merged 3 commits intoelastic:mainfrom
Conversation
|
@majagrubic How do I set the logo? Is it part of the yml file, a UI setting I can find somewhere, or an API call? |
|
It's still WIP: If you hardcode a base64-encoded image from as |
I was not able to get this to work. Is there an image format or size restriction? I just grabbed a simple 200x200 bitmap and converted it to a base64 encoded string. I added the set you suggested, but it doesn't render. |
|
Well, it looks like something was picked up (otherwise the default Elastic logo would be rendered), but it wasn't properly decoded into image. I guess the image encoding is wrong? |
|
EDIT: I figured out that the string requires the following prefix
That was my guess too, but every tool I try yields the same exact string for each image I supply. What are you using to generate the image string? |
jeramysoucy
left a comment
There was a problem hiding this comment.
LGTM! FYI there is another open PR modifying the space selector but the merge should be pretty straightforward. Unrelated to this PR, I did also notice that the custom image on the loading screen is stretched disproportionately.
|
I was using this tool: https://www.base64-image.de/
Thanks for the feedback, will have a look into that. |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
* main: (115 commits) [Custom branding] Add custom logo to space selector (elastic#150284) [api-docs] 2023-02-10 Daily api_docs build (elastic#150831) [ci] build next docs in PRs when relevant files change (elastic#149991) [codeowners] allow overrides to take higher precedence (elastic#150821) [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788) [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780) [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761) fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768) [Synthetics] adjust overview scrolling e2e (elastic#150774) [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765) Upgrade EUI to v74.1.0 (elastic#150235) [skip ci] Fix labeling for Infrastructure UI (elastic#150571) [Enterprise Search] Move pipelines modal to flyout (elastic#150727) [Security Solution] fix flaky endpoint tests (elastic#150652) Fixes the space selector page layout (elastic#150503) [Dashboard] [Navigation] Fix mount point bug (elastic#150507) [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685) [Dashboard Usability] Moves scrollbar to panel section (elastic#145628) [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497) [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394) ...
## Summary This PR updates the snapshot for `space_selector_test`, so the test can pass normally. Discrepancy occurred after two PRs changing the `space_selector` were merged around the same time. #150284 #150503 __Fixes: https://github.com/elastic/kibana/issues/150834__ ### Checklist Delete any items that are not applicable to this PR. ~- [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)~ ~- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials~ - [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ~- [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))~ ~- [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))~ ~- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)~ ~- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))~ ~- [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)~ ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Summary
As part of custom branding, we need to replace all occurrences of Elastic logo with the custom one, when it's set. This PR does that for space selector.
Resolves: #150272
Example of how it might look like:
Checklist
Delete any items that are not applicable to this PR.
~ - [ ] Documentation was added for features that require explanation or tutorials~
- [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)- [ ] This was checked for cross-browser compatibilityFor maintainers