[Custom Branding] Adds Custom Branding settings to Global settings#150080
[Custom Branding] Adds Custom Branding settings to Global settings#150080majagrubic merged 42 commits intoelastic:mainfrom
Conversation
Co-authored-by: Vadim Kibana <82822460+vadimkibana@users.noreply.github.com>
|
@elasticmachine merge upstream |
| const settingName = 'xpackCustomBranding:logo'; | ||
| await PageObjects.settings.setAdvancedSettingsImage( | ||
| settingName, | ||
| require.resolve('./mcdonalds_logo.png') |
There was a problem hiding this comment.
question: I'm far from being a legal expert and likely exaggerating, but just curious, is it fine (no DMCA Takedown risk and such) to store copyrighted logo of the 3rd-party in our repository? 🙂
There was a problem hiding this comment.
We should probably come up with a mock logo/name to use in the repo. I see ACME used in mockups regularly, we can come up some creative commons image to use for a logo or something.
There was a problem hiding this comment.
++ I'd avoid using anything copyrighted here
There was a problem hiding this comment.
I've seen some UIs re: custom branding use this wording:
By uploading a custom company logo, I confirm I have the rights to use this image.
Should we consider using copy like that here?
There was a problem hiding this comment.
Thanks, updated this with acme logo.
| ) : ( | ||
| <EuiIcon type="logoElastic" size="xxl" /> | ||
| ); | ||
| const logoStyle = customLogo ? { padding: 0 } : {}; |
There was a problem hiding this comment.
nit: would you mind adding a clarifying comment in the code why this is needed for custom logos and not default one (for future readers)?
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
Summary
This PR registers custom branding settings from the
custom_brandingplugin. Once registered, these settings can be viewed under "Global settings".UI changes:
I also removed the client-side version of the
custom_brandingplugin, as it's not needed.With this change, it became easier to test custom branding, so I made a few changes where logo was not showing properly or image size was wrong or test subjects were missing.
I am working with @gchaps on the exact wording, so that might change.
Checklist
Delete any items that are not applicable to this PR.
- [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker listFor maintainers