Skip to content

[Infrastructure UI] Track host cloud provider on table entry click#150685

Merged
tonyghiani merged 2 commits intoelastic:mainfrom
tonyghiani:150681-track-default-cloud-provider
Feb 9, 2023
Merged

[Infrastructure UI] Track host cloud provider on table entry click#150685
tonyghiani merged 2 commits intoelastic:mainfrom
tonyghiani:150681-track-default-cloud-provider

Conversation

@tonyghiani
Copy link
Copy Markdown
Contributor

@tonyghiani tonyghiani commented Feb 9, 2023

📓 Summary

Closes #150681

The tracked event when clicking an entry from the Hosts table was not applying correctly the default unknow string for the cloud_provider parameter.
Now it defaults to it in case the value is not passed or is null.

🧪 Testing

  • Navigate to the Hosts view
  • Open the console dev tools
  • Click on a host name from the table and navigate to the host detail.
  • Verify the following error does not appear in the log
Uncaught Error: Failed to validate payload coming from "Event Type 'Host Entry Clicked'":
[cloud_provider]: {"expected":"string","actual":"object","value":null}

@tonyghiani tonyghiani added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v8.7.0 v8.8.0 labels Feb 9, 2023
@tonyghiani tonyghiani requested a review from a team as a code owner February 9, 2023 11:46
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@tonyghiani tonyghiani changed the title [Infrastructure UI]Track host cloud provider on table entry click [Infrastructure UI] Track host cloud provider on table entry click Feb 9, 2023
Copy link
Copy Markdown
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tonyghiani tonyghiani enabled auto-merge (squash) February 9, 2023 17:08
@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
infra 87.1KB 87.1KB +8.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@tonyghiani tonyghiani merged commit 26eddec into elastic:main Feb 9, 2023
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Feb 9, 2023
…lastic#150685)

## 📓 Summary

Closes elastic#150681

The tracked event when clicking an entry from the Hosts table was not
applying correctly the default `unknow` string for the `cloud_provider`
parameter.
Now it defaults to it in case the value is not passed or is null.

## 🧪 Testing
- Navigate to the Hosts view
- Open the console dev tools
- Click on a host name from the table and navigate to the host detail.
- Verify the following error does not appear in the log
```
Uncaught Error: Failed to validate payload coming from "Event Type 'Host Entry Clicked'":
[cloud_provider]: {"expected":"string","actual":"object","value":null}
```

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani@elastic.co>
(cherry picked from commit 26eddec)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.7

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Feb 9, 2023
…ick (#150685) (#150760)

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Infrastructure UI] Track host cloud provider on table entry click
(#150685)](#150685)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco Antonio
Ghiani","email":"marcoantonio.ghiani01@gmail.com"},"sourceCommit":{"committedDate":"2023-02-09T18:19:10Z","message":"[Infrastructure
UI] Track host cloud provider on table entry click (#150685)\n\n## 📓
Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an
entry from the Hosts table was not\r\napplying correctly the default
`unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it
defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪
Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev
tools\r\n- Click on a host name from the table and navigate to the host
detail.\r\n- Verify the following error does not appear in the
log\r\n```\r\nUncaught Error: Failed to validate payload coming from
\"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]:
{\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by:
Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Infra
Monitoring
UI","release_note:skip","v8.7.0","v8.8.0"],"number":150685,"url":"https://github.com/elastic/kibana/pull/150685","mergeCommit":{"message":"[Infrastructure
UI] Track host cloud provider on table entry click (#150685)\n\n## 📓
Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an
entry from the Hosts table was not\r\napplying correctly the default
`unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it
defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪
Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev
tools\r\n- Click on a host name from the table and navigate to the host
detail.\r\n- Verify the following error does not appear in the
log\r\n```\r\nUncaught Error: Failed to validate payload coming from
\"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]:
{\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by:
Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534"}},"sourceBranch":"main","suggestedTargetBranches":["8.7"],"targetPullRequestStates":[{"branch":"8.7","label":"v8.7.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/150685","number":150685,"mergeCommit":{"message":"[Infrastructure
UI] Track host cloud provider on table entry click (#150685)\n\n## 📓
Summary\r\n\r\nCloses #150681 \r\n\r\nThe tracked event when clicking an
entry from the Hosts table was not\r\napplying correctly the default
`unknow` string for the `cloud_provider`\r\nparameter.\r\nNow it
defaults to it in case the value is not passed or is null.\r\n\r\n## 🧪
Testing\r\n- Navigate to the Hosts view\r\n- Open the console dev
tools\r\n- Click on a host name from the table and navigate to the host
detail.\r\n- Verify the following error does not appear in the
log\r\n```\r\nUncaught Error: Failed to validate payload coming from
\"Event Type 'Host Entry Clicked'\":\r\n[cloud_provider]:
{\"expected\":\"string\",\"actual\":\"object\",\"value\":null}\r\n```\r\n\r\nCo-authored-by:
Marco Antonio Ghiani
<marcoantonio.ghiani@elastic.co>","sha":"26eddec70844ffb65e5d3521a7adb52e643c4534"}}]}]
BACKPORT-->

Co-authored-by: Marco Antonio Ghiani <marcoantonio.ghiani01@gmail.com>
@tonyghiani tonyghiani deleted the 150681-track-default-cloud-provider branch February 10, 2023 08:22
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 10, 2023
* main: (115 commits)
  [Custom branding] Add custom logo to space selector (elastic#150284)
  [api-docs] 2023-02-10 Daily api_docs build (elastic#150831)
  [ci] build next docs in PRs when relevant files change (elastic#149991)
  [codeowners] allow overrides to take higher precedence (elastic#150821)
  [docs] Remove kibDevDocsOpsPluginDiscovery (elastic#150788)
  [Fleet] Fix max 20 installed integrations returned from Fleet API (elastic#150780)
  [maps] fix Changing resolutions on Heat map layer throws error in console (elastic#150761)
  fixes Failing ES Promotion: X-Pack API Integration Tests x-pack/test/api_integration/apis/maps/get_grid_tile.js (elastic#150768)
  [Synthetics] adjust overview scrolling e2e (elastic#150774)
  [Security Solution] Fixes bulk close alerts from exception flyout type bug (elastic#150765)
  Upgrade EUI to v74.1.0 (elastic#150235)
  [skip ci] Fix labeling for Infrastructure UI (elastic#150571)
  [Enterprise Search] Move pipelines modal to flyout (elastic#150727)
  [Security Solution] fix flaky endpoint tests (elastic#150652)
  Fixes the space selector page layout  (elastic#150503)
  [Dashboard] [Navigation] Fix mount point bug (elastic#150507)
  [Infrastructure UI] Track host cloud provider on table entry click (elastic#150685)
  [Dashboard Usability] Moves scrollbar to panel section (elastic#145628)
  [Maps] fixes Kibana maps shows MVT borders if the geometry border style is greater than 1 (elastic#150497)
  [Cloud Posture][Dashboard] dashboard re-design enhancements (elastic#150394)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.7.0 v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Infrastructure UI] Hosts clicked event not tracking default cloud provider

5 participants