Skip to content

[Space selector] Fix failing test#150853

Merged
majagrubic merged 1 commit intoelastic:mainfrom
majagrubic:fix-merge-conflict-ss
Feb 10, 2023
Merged

[Space selector] Fix failing test#150853
majagrubic merged 1 commit intoelastic:mainfrom
majagrubic:fix-merge-conflict-ss

Conversation

@majagrubic
Copy link
Copy Markdown
Contributor

@majagrubic majagrubic commented Feb 10, 2023

Summary

This PR updates the snapshot for space_selector_test, so the test can pass normally. Discrepancy occurred after two PRs changing the space_selector were merged around the same time.
#150284
#150503

Fixes: #150834

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials

  • Unit or functional tests were updated or added to match the most common scenarios
    - [ ] Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
    - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)
    - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
    - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)
    - [ ] This was checked for cross-browser compatibility

For maintainers

@majagrubic majagrubic added v8.8.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 10, 2023
@majagrubic majagrubic marked this pull request as ready for review February 10, 2023 11:04
@majagrubic majagrubic requested a review from a team as a code owner February 10, 2023 11:04
Copy link
Copy Markdown
Contributor

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kibana-ci
Copy link
Copy Markdown

💚 Build Succeeded

Metrics [docs]

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@majagrubic majagrubic merged commit 4f25fa7 into elastic:main Feb 10, 2023
@kibanamachine kibanamachine added the backport:skip This PR does not require backporting label Feb 10, 2023
@majagrubic majagrubic deleted the fix-merge-conflict-ss branch February 10, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes v8.8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.x-pack/plugins/spaces/public/space_selector - it renders with custom logo

4 participants