Redirect endpoint by streamich · Pull Request #103286 · elastic/kibana

streamich · 2021-06-24T13:44:27Z

Summary

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk	Probability	Severity	Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space.	Low	High	Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks.	High	Low	Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled.	Medium	High	Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

This was checked for breaking API changes and was labeled appropriately

streamich · 2021-06-28T08:53:19Z

@elasticmachine merge upstream

src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts

src/plugins/kibana_utils/common/persistable_state/types.ts

src/plugins/share/common/url_service/locators/types.ts

src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts

…atest.ts

…en (#103283) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [ML] Rare anomaly detection job wizard * fixing fields selection * small improvements * adding event rate chart to summary step * [ML] Changes UI text for rare wizard. * improving detector summary * fixing translations * removing comments * fixing field selection * fixing advanced wizard * updating detector text * fixing bucketspan estimator * bug fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

Co-authored-by: Shahzad <shahzad31comp@gmail.com>

…emoved on Rules and Connectors page (#103663)

streamich · 2021-06-30T14:28:47Z

Closing this one because rebasing caused review request from everyone. Sorry for the ping!

kibanamachine · 2021-06-30T15:43:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 32a61bf
Storybooks not built
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Failed CI Steps

Test Failures

Jest Tests.src/plugins/kibana_utils/common/persistable_state.returns the same object if there are no migrations to be applied

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

Error: expect(received).toEqual(expected) // deep equality

Expected: [{"name": "Foo"}, "0.0.1"]
Received: {"state": undefined, "version": undefined}
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.test.ts:47:20)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Jest Tests.src/plugins/kibana_utils/common/persistable_state.applies a single migration

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Invalid Version: undefined
    at new SemVer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/classes/semver.js:22:13)
    at compare (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/compare.js:3:32)
    at filter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts:17:20)
    at Array.filter (<anonymous>)
    at migrateToLatest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts:17:6)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.test.ts:51:34)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

Jest Tests.src/plugins/kibana_utils/common/persistable_state.does not apply migration if it has the same version as state

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

TypeError: Invalid Version: undefined
    at new SemVer (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/classes/semver.js:22:13)
    at compare (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/semver/functions/compare.js:3:32)
    at filter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts:17:20)
    at Array.filter (<anonymous>)
    at migrateToLatest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts:17:6)
    at Object.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.test.ts:66:34)
    at Promise.then.completed (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:276:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/utils.js:216:10)
    at _callCircusTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:212:40)
    at processTicksAndRejections (internal/process/task_queues.js:95:5)
    at _runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:149:3)
    at _runTestsForDescribeBlock (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:63:9)
    at run (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/run.js:25:3)
    at runAndTransformResultsToJestFormat (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:176:21)
    at jestAdapter (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:109:19)
    at runTestInternal (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

and 3 more failures, only showing the first 3.

Metrics [docs]

‼️ ERROR: metrics for 32a61bf were not reported

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

streamich added 11 commits June 24, 2021 10:05

feat: 🎸 add redirect endpoint app

98fdb00

feat: 🎸 improve spinner design

a037e97

feat: 🎸 implement basic version of redirect endpoint

0a6e737

feat: 🎸 render errors for user on the screen

ae93f92

feat: 🎸 improve error message display

8c6b3e1

feat: 🎸 improve error display

d85f394

feat: 🎸 improve locator errors

2b95156

feat: 🎸 improve errors

feaac63

feat: 🎸 improve persistable state types

cc4c21c

feat: 🎸 implement migrateToLatest function

e2973ff

feat: 🎸 migrate locator params to the latest in redirect endp

81c6521

streamich mentioned this pull request Jun 25, 2021

[Meta] URL Service #87304

Closed

13 tasks

streamich marked this pull request as ready for review June 28, 2021 08:52

streamich requested a review from a team as a code owner June 28, 2021 08:52

Merge branch 'master' into redirect-endpoint

95d137c

ppisljar reviewed Jun 28, 2021

View reviewed changes

src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts Outdated Show resolved Hide resolved

ppisljar reviewed Jun 28, 2021

View reviewed changes

src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts Outdated Show resolved Hide resolved

ppisljar requested changes Jun 28, 2021

View reviewed changes

src/plugins/kibana_utils/common/persistable_state/types.ts Outdated Show resolved Hide resolved

src/plugins/share/common/url_service/locators/types.ts Show resolved Hide resolved

Merge remote-tracking branch 'upstream/master' into redirect-endpoint

21125a3

streamich commented Jun 29, 2021

View reviewed changes

src/plugins/kibana_utils/common/persistable_state/migrate_to_latest.ts Outdated Show resolved Hide resolved

streamich and others added 9 commits June 30, 2021 12:06

Update src/plugins/kibana_utils/common/persistable_state/migrate_to_l…

1e64da8

…atest.ts

[Lens] Do not persist time zone (#102735)

14bed7a

add formula telemetry (#103451)

b835e8b

[Lens] Remove reference tooltip in Formula panel when the popup is op…

ff13a53

…en (#103283) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Exploratory view] use percentages in distribution chart (#103080)

da14a88

Update security telemetry allowlist. (#103471)

b1d3789

[ML] Fixing categorization tokens for multi-line messages (#103007)

874ad59

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

[Migrations V2] Unskip migration_7.7.2_xpack_100k (#103435)

fc37ffc

sorenlouv and others added 4 commits June 30, 2021 16:26

[APM] Add “Analyze Data” button (#103485)

c8f0b72

Co-authored-by: Shahzad <shahzad31comp@gmail.com>

fix too many rernders (#103672)

37e9a0e

[Alerting] Fixed search results are not updated when search term is r…

cc1ef6d

…emoved on Rules and Connectors page (#103663)

refactor: 💡 make Versioned state be an object

32a61bf

streamich requested review from a team June 30, 2021 14:27

streamich requested review from a team as code owners June 30, 2021 14:27

streamich requested a review from a team June 30, 2021 14:27

streamich requested review from a team as code owners June 30, 2021 14:27

streamich requested a review from a team June 30, 2021 14:27

streamich requested a review from a team as a code owner June 30, 2021 14:27

streamich requested a review from a team June 30, 2021 14:27

streamich closed this Jun 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Redirect endpoint#103286

Redirect endpoint#103286
streamich wants to merge 115 commits intoelastic:masterfrom
streamich:redirect-endpoint

streamich commented Jun 24, 2021

Uh oh!

streamich commented Jun 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

streamich commented Jun 30, 2021 •

edited

Loading

Uh oh!

kibanamachine commented Jun 30, 2021 •

edited

Loading

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

streamich commented Jun 24, 2021

Summary

Checklist

Risk Matrix

For maintainers

Uh oh!

streamich commented Jun 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

streamich commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Jun 30, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Test Failures

Standard Out

Stack Trace

Standard Out

Stack Trace

Standard Out

Stack Trace

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

streamich commented Jun 30, 2021 •

edited

Loading

kibanamachine commented Jun 30, 2021 •

edited

Loading