[Lens] Do not persist time zone#102735
Merged
flash1293 merged 4 commits intoelastic:masterfrom Jun 29, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
wylieconlon
reviewed
Jun 24, 2021
| '7.12.0': transformTableState, | ||
| '7.13.0': renameOperationsForFormula, | ||
| '7.13.1': renameOperationsForFormula, // duplicate this migration in case a broken by value panel is added to the library | ||
| '7.14.0': removeTimezoneDateHistogramParam, |
Contributor
There was a problem hiding this comment.
@LeeDr New migration being added to 7.14 here FYI
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
wylieconlon
approved these changes
Jun 28, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
Tested and LGTM. This does not fix the bug where rollup timezones cause lines to always be disconnected, but I can confirm that if I follow these steps it works as expected:
- Create a 2-layer chart with a rollup and the primary index
- Convert the rollup layer into the primary index, and the two layers merge
- Convert the rollup layer back and it work
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 29, 2021
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #99894
This PR removes the time zone parameter from date histogram columns. We can fetch this information when building the expression and there is no upside to storing it because it can get out of sync with the used index pattern in multiple ways (like in the linked bug).
This also makes it unnecessary to change the column params on changing the index pattern. In fact, the transfer logic is now unused in Lens - I left it in however because we might need/want to go back to it at some point for smarter transition (e.g. use the clostest allowed interval of the new index pattern)