[Lens] Remove reference tooltip in Formula panel when the popup is open#103283
Merged
dej611 merged 2 commits intoelastic:masterfrom Jun 29, 2021
Merged
[Lens] Remove reference tooltip in Formula panel when the popup is open#103283dej611 merged 2 commits intoelastic:masterfrom
dej611 merged 2 commits intoelastic:masterfrom
Conversation
wylieconlon
approved these changes
Jun 24, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
Haven't tested but LGTM, this was annoying me too.
wylieconlon
reviewed
Jun 28, 2021
Contributor
wylieconlon
left a comment
There was a problem hiding this comment.
I've now verified that this works as expected.
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 29, 2021
…en (elastic#103283) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've noticed that the formula reference tooltip keeps on animate as long as the whole popup is in focus, in particular when scrolling the documentation in it.
I've then extended the
TooltipWrappercomponent and used to prevent the tooltip to appear completely when the popover is open: the information in the tooltip is already shown as popover title.Before:
After:
Checklist
Delete any items that are not applicable to this PR.
For maintainers