[ML] Rare anomaly detection job wizard by jgowdyelastic · Pull Request #100390 · elastic/kibana

jgowdyelastic · 2021-05-20T11:19:35Z

Adds the option to create a rare detector job using a new wizard.
Three general rare detector types are available, rare, rare in population and frequently rare in population. The later two require a population field to be selected.
A split field can be added to any of the choices.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
Any UI touched in this PR does not create any new axe failures (run axe in browser: FF, Chrome)

jgowdyelastic · 2021-05-27T10:24:34Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-01T07:30:30Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-02T12:33:14Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-02T16:43:49Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-04T09:47:24Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-07T13:10:57Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-08T13:36:24Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-09T07:40:30Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-14T09:22:27Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-15T10:38:57Z

@elasticmachine merge upstream

jgowdyelastic · 2021-06-17T13:22:28Z

x-pack/plugins/ml/public/application/jobs/new_job/pages/job_type/rare_job_icon.tsx

+
+import React from 'react';
+
+export const RareIcon = (


this is currently a copy of the categorisation icon. a new icon needs designing and will be placed here when ready in a follow up PR

...ion/jobs/new_job/pages/components/pick_fields_step/components/rare_view/metric_selection.tsx

...ication/jobs/new_job/pages/components/pick_fields_step/components/rare_field/description.tsx

jgowdyelastic · 2021-06-21T10:02:03Z

@elasticmachine merge upstream

...cation/jobs/new_job/pages/components/pick_fields_step/components/split_field/description.tsx

jgowdyelastic · 2021-06-22T10:38:40Z

@elasticmachine merge upstream

x-pack/plugins/ml/public/application/jobs/new_job/common/job_creator/rare_job_creator.ts

alvarezmelissa87 · 2021-06-22T18:22:16Z

I was able to reproduce the bug you mentione @jgowdyelastic with the error for the model memory limit fetch failing due to the over field not being selected.

Not sure if you were planning on updating that in this PR. Works fine once I select the population field.

I was unable to reproduce the estimate bucket span error that @peteharverson was seeing - I tested with gallery dataset and tried rare, rare in population, and frequently rare in population but wasn't able to get an error.

@alvarezmelissa87 this bug is tricky to fix and so i'll look at it in a follow up PR

alvarezmelissa87 · 2021-06-22T18:29:04Z

Found a small issue with estimate bucket span. If I try to estimate bucket span more than once the Next button becomes disabled and I'm unable to proceed unless I change something else in the form. Not a huge deal but a bit of a pain.

rare-wizard-bug.mp4

@alvarezmelissa87 good spot, this is a new bug in this PR. Hopefully easy to fix.
Fixed in 0862bb9

jgowdyelastic · 2021-06-29T06:13:54Z

@elasticmachine merge upstream

kibanamachine · 2021-06-29T08:18:34Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`ml`	1698	1718	+20

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`ml`	5.9MB	5.9MB	+26.4KB

History

💚 Build #133317 succeeded 0862bb9
💚 Build #133146 succeeded 9ba5c60
💔 Build #133105 failed 6f648b1
💚 Build #133072 succeeded adb6aa2
💚 Build #132701 succeeded 5c494ef

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jgowdyelastic

peteharverson

LGTM.

I raised #103466 to look into the bucket span estimator separately.

* [ML] Rare anomaly detection job wizard * fixing fields selection * small improvements * adding event rate chart to summary step * [ML] Changes UI text for rare wizard. * improving detector summary * fixing translations * removing comments * fixing field selection * fixing advanced wizard * updating detector text * fixing bucketspan estimator * bug fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

kibanamachine · 2021-06-29T10:04:48Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

* [ML] Rare anomaly detection job wizard * fixing fields selection * small improvements * adding event rate chart to summary step * [ML] Changes UI text for rare wizard. * improving detector summary * fixing translations * removing comments * fixing field selection * fixing advanced wizard * updating detector text * fixing bucketspan estimator * bug fixes Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co> Co-authored-by: James Gowdy <jgowdy@elastic.co> Co-authored-by: István Zoltán Szabó <istvan.szabo@elastic.co>

alvarezmelissa87

LGTM ⚡

[ML] Rare anomaly detection job wizard

b6d31df

Merge branch 'master' into rare-job-wizard

0ab671c

Merge branch 'master' into rare-job-wizard

4166e08

Merge branch 'master' into rare-job-wizard

e71da5d

Merge branch 'master' into rare-job-wizard

3298581

kibanamachine and others added 3 commits June 4, 2021 05:47

Merge branch 'master' into rare-job-wizard

ec5dffc

fixing fields selection

8fc1a88

small improvements

24824ff

Merge branch 'master' into rare-job-wizard

4b2b73a

kibanamachine and others added 2 commits June 8, 2021 09:36

Merge branch 'master' into rare-job-wizard

0ea7fac

adding event rate chart to summary step

9782e9c

Merge branch 'master' into rare-job-wizard

1deef6e

Merge branch 'master' into rare-job-wizard

64ac7e6

kibanamachine and others added 4 commits June 15, 2021 06:39

Merge branch 'master' into rare-job-wizard

9fd466c

[ML] Changes UI text for rare wizard.

7dda40d

improving detector summary

e92d3f7

fixing translations

cd16fc2

jgowdyelastic commented Jun 17, 2021

View reviewed changes

jgowdyelastic requested review from peteharverson and qn895 June 17, 2021 13:23

peteharverson reviewed Jun 18, 2021

View reviewed changes

...ion/jobs/new_job/pages/components/pick_fields_step/components/rare_view/metric_selection.tsx Show resolved Hide resolved

fixing field selection

2262218

jgowdyelastic commented Jun 21, 2021

View reviewed changes

...ication/jobs/new_job/pages/components/pick_fields_step/components/rare_field/description.tsx Outdated Show resolved Hide resolved

Merge branch 'master' into rare-job-wizard

50008a0

szabosteve reviewed Jun 21, 2021

View reviewed changes

...cation/jobs/new_job/pages/components/pick_fields_step/components/split_field/description.tsx Outdated Show resolved Hide resolved

fixing advanced wizard

5c494ef

kibanamachine and others added 3 commits June 22, 2021 06:38

Merge branch 'master' into rare-job-wizard

adb6aa2

updating detector text

6f648b1

fixing bucketspan estimator

9ba5c60

alvarezmelissa87 reviewed Jun 22, 2021

View reviewed changes

x-pack/plugins/ml/public/application/jobs/new_job/common/job_creator/rare_job_creator.ts Outdated Show resolved Hide resolved

bug fixes

0862bb9

Merge branch 'master' into rare-job-wizard

aa27210

peteharverson approved these changes Jun 29, 2021

View reviewed changes

jgowdyelastic merged commit 2e00e9c into elastic:master Jun 29, 2021

jgowdyelastic deleted the rare-job-wizard branch June 29, 2021 10:02

kibanamachine mentioned this pull request Jun 29, 2021

[7.x] [ML] Rare anomaly detection job wizard (#100390) #103630

Merged

alvarezmelissa87 reviewed Jun 29, 2021

View reviewed changes

lcawl added release_note:feature Makes this part of the condensed release notes and removed release_note:enhancement labels Jul 6, 2021

This was referenced Jul 14, 2021

[ML] Rare anomaly detection job wizard card text #105635

Merged

[ML] Edits rare anomaly detection job summaries #105694

Merged

Conversation

jgowdyelastic commented May 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

jgowdyelastic commented May 27, 2021

Uh oh!

jgowdyelastic commented Jun 1, 2021

Uh oh!

jgowdyelastic commented Jun 2, 2021

Uh oh!

jgowdyelastic commented Jun 2, 2021

Uh oh!

jgowdyelastic commented Jun 4, 2021

Uh oh!

jgowdyelastic commented Jun 7, 2021

Uh oh!

jgowdyelastic commented Jun 8, 2021

Uh oh!

jgowdyelastic commented Jun 9, 2021

Uh oh!

jgowdyelastic commented Jun 14, 2021

Uh oh!

jgowdyelastic commented Jun 15, 2021

Uh oh!

jgowdyelastic Jun 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jgowdyelastic commented Jun 21, 2021

Uh oh!

Uh oh!

jgowdyelastic commented Jun 22, 2021

Uh oh!

Uh oh!

alvarezmelissa87 commented Jun 22, 2021 • edited by jgowdyelastic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alvarezmelissa87 commented Jun 22, 2021 • edited by jgowdyelastic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jgowdyelastic commented Jun 29, 2021

Uh oh!

kibanamachine commented Jun 29, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Async chunks

History

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jun 29, 2021

💚 Backport successful

Uh oh!

alvarezmelissa87 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jgowdyelastic commented May 20, 2021 •

edited

Loading

alvarezmelissa87 commented Jun 22, 2021 •

edited by jgowdyelastic

Loading

alvarezmelissa87 commented Jun 22, 2021 •

edited by jgowdyelastic

Loading