Skip to content

[Lens] Add formula help telemetry#103451

Merged
flash1293 merged 1 commit intoelastic:masterfrom
flash1293:lens/formula-popover-temeletry
Jun 29, 2021
Merged

[Lens] Add formula help telemetry#103451
flash1293 merged 1 commit intoelastic:masterfrom
flash1293:lens/formula-popover-temeletry

Conversation

@flash1293
Copy link
Copy Markdown
Contributor

@flash1293 flash1293 commented Jun 28, 2021

Fixes #102489

Adds telemetry counter for formula help popover

@flash1293 flash1293 added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed labels Jun 28, 2021
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 28, 2021

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +66.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 marked this pull request as ready for review June 28, 2021 11:11
@flash1293 flash1293 requested a review from a team as a code owner June 28, 2021 11:11
@flash1293 flash1293 requested a review from a team June 28, 2021 11:11
@flash1293 flash1293 requested a review from a team as a code owner June 28, 2021 11:11
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 28, 2021

Pinging @elastic/kibana-app (Team:KibanaApp)

wylieconlon
wylieconlon approved these changes Jun 28, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flash1293 flash1293 merged commit ce2fabe into elastic:master Jun 29, 2021
@kibanamachine kibanamachine mentioned this pull request Jun 29, 2021
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jun 29, 2021

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jun 29, 2021
@flash1293 @kibanamachine
add formula telemetry (elastic#103451)
61ed574
kibanamachine added a commit that referenced this pull request Jun 29, 2021
@kibanamachine @flash1293
add formula telemetry (#103451) (#103623)
5f16d3e 
Co-authored-by: Joe Reuter <johannes.reuter@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@Bamieh Bamieh Bamieh approved these changes

+1 more reviewer

@wylieconlon wylieconlon wylieconlon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

auto-backport Deprecated - use backport:version if exact versions are needed Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.14.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] Add telemetry for formula help popover

6 participants

@flash1293 @kibanamachine @elasticmachine @wylieconlon @lukeelmers @Bamieh