Move assertion in ES85BloomFilterPostingsFormat to fix test#90150
Merged
original-brownbear merged 4 commits intoelastic:mainfrom Sep 21, 2022
original-brownbear:90144
Merged
Move assertion in ES85BloomFilterPostingsFormat to fix test#90150original-brownbear merged 4 commits intoelastic:mainfrom original-brownbear:90144
original-brownbear merged 4 commits intoelastic:mainfrom
original-brownbear:90144
Conversation
This assertion is failing a corruption test in some corner cases because the corruption is causing a bloom filter to be read that trips the assertion. If we just assert in a separate loop after checking the checksum it fixes the test issue because the checksum check is tripped before the assertion. Also, this technically makes the assertion more correct since we could legitimately run into corruption here so it should only hold after verifying the checksum anyway. closes #90144
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Jenkins run elasticsearch-ci/part-1 |
DaveCTurner
approved these changes
Sep 21, 2022
...r/src/main/java/org/elasticsearch/index/codec/bloomfilter/ES85BloomFilterPostingsFormat.java
Show resolved
Hide resolved
…/ES85BloomFilterPostingsFormat.java Co-authored-by: David Turner <david.turner@elastic.co>
Contributor
Author
|
@elasticsearchmachine update branch |
Contributor
Author
|
Jenkins update branch |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Jenkins run elasticsearch-ci/bwc |
Contributor
Author
|
Jenkins run elasticsearch-ci/bwc please |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 22, 2022
* main: (186 commits) [DOCS] Add 8.5 release notes and fix links (elastic#90201) Mute DownsampleActionSingleNodeTests.testCannotRollupWhileOtherRollupInProgress (elastic#90198) Bump to version 8.6.0 Increase the minimum size of the management pool to 2 (elastic#90193) Speed `getIntLE` from `BytesReference` (elastic#90147) Restrict nodes for testClusterPrimariesActive1 (elastic#90191) Fix bug with `BigIntArray` serialization (elastic#90142) Synthetic _source: test _source filtering (elastic#90138) Modernize cardinality agg tests (elastic#90114) Mute failing test (elastic#90186) Move assertion in ES85BloomFilterPostingsFormat to fix test (elastic#90150) Restrict nodes for testClusterPrimariesActive2 (elastic#90184) Batch index delete cluster state updates (elastic#90033) Register stable plugins in ActionModule (elastic#90067) Mute failing test (elastic#90180) [HealthAPI] Disk: Use _ for diagnosis id (elastic#90179) [HealtAPI] Disk: use shorter help URLs (elastic#90178) Fixing disk health indicator unit tests (elastic#90175) Enable the health node and the disk health indicator elastic#84811 (elastic#90085) Add missing Disk Indicator health api IDs (elastic#90174) ...
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 22, 2022
* main: (121 commits) [DOCS] Add 8.5 release notes and fix links (elastic#90201) Mute DownsampleActionSingleNodeTests.testCannotRollupWhileOtherRollupInProgress (elastic#90198) Bump to version 8.6.0 Increase the minimum size of the management pool to 2 (elastic#90193) Speed `getIntLE` from `BytesReference` (elastic#90147) Restrict nodes for testClusterPrimariesActive1 (elastic#90191) Fix bug with `BigIntArray` serialization (elastic#90142) Synthetic _source: test _source filtering (elastic#90138) Modernize cardinality agg tests (elastic#90114) Mute failing test (elastic#90186) Move assertion in ES85BloomFilterPostingsFormat to fix test (elastic#90150) Restrict nodes for testClusterPrimariesActive2 (elastic#90184) Batch index delete cluster state updates (elastic#90033) Register stable plugins in ActionModule (elastic#90067) Mute failing test (elastic#90180) [HealthAPI] Disk: Use _ for diagnosis id (elastic#90179) [HealtAPI] Disk: use shorter help URLs (elastic#90178) Fixing disk health indicator unit tests (elastic#90175) Enable the health node and the disk health indicator elastic#84811 (elastic#90085) Add missing Disk Indicator health api IDs (elastic#90174) ...
Member
|
Thanks Armin! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This assertion is failing a corruption test in some corner cases because the corruption is causing a bloom filter to be read that trips the assertion. If we just assert in a separate loop after checking the checksum it fixes the test issue because the checksum check is tripped before the assertion. Also, this technically makes the assertion more correct since we could legitimately run into corruption here so it should only hold after verifying the checksum anyway.
closes #90144