Skip to content

Enable the health node and the disk health indicator #84811#90085

Merged
andreidan merged 11 commits intoelastic:mainfrom
gmarouli:remove-feature-flag-84811
Sep 20, 2022
Merged

Enable the health node and the disk health indicator #84811#90085
andreidan merged 11 commits intoelastic:mainfrom
gmarouli:remove-feature-flag-84811

Conversation

@gmarouli
Copy link
Copy Markdown
Contributor

@gmarouli gmarouli commented Sep 15, 2022

Depends on #90041, the draft status remains to protect from a premature merge.

This PR removes the health node feature flag and enabled the disk health indicator. The following changes were made to ensure a safe rollout:

  • Remove the feature flag.
  • Bump the minimum version of all writeables to 8.5.0, this ensures that during a rolling upgrade from 8.4.x we will not introduce writeables that will be unknown to the older nodes because of the feature flag.
  • Adjust tests that did not anticipate the health node persistent task.

@gmarouli gmarouli changed the title Remove health node feature flag Enable the health node and the disk health indicator #84811 Sep 15, 2022
@gmarouli
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

@gmarouli
Copy link
Copy Markdown
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

@gmarouli gmarouli mentioned this pull request Sep 19, 2022
9 tasks
@gmarouli gmarouli added >feature :Distributed/Health Issues for the health report API labels Sep 19, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Hi @gmarouli, I've created a changelog YAML for you.

@gmarouli gmarouli requested a review from andreidan September 19, 2022 13:05
@gmarouli gmarouli marked this pull request as ready for review September 19, 2022 14:13
@elasticsearchmachine elasticsearchmachine added the Team:Data Management (obsolete) DO NOT USE. This team no longer exists. label Sep 19, 2022
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@gmarouli
Copy link
Copy Markdown
Contributor Author

Don't merge until #90041 is merged.

Copy link
Copy Markdown
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for when mergeable (after the required work)

@andreidan
Copy link
Copy Markdown
Contributor

@elasticmachine update branch

@andreidan andreidan merged commit 4901cf8 into elastic:main Sep 20, 2022
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Sep 22, 2022
* main: (186 commits)
  [DOCS] Add 8.5 release notes and fix links (elastic#90201)
  Mute DownsampleActionSingleNodeTests.testCannotRollupWhileOtherRollupInProgress (elastic#90198)
  Bump to version 8.6.0
  Increase the minimum size of the management pool to 2 (elastic#90193)
  Speed `getIntLE` from `BytesReference` (elastic#90147)
  Restrict nodes for testClusterPrimariesActive1 (elastic#90191)
  Fix bug with `BigIntArray` serialization (elastic#90142)
  Synthetic _source: test _source filtering (elastic#90138)
  Modernize cardinality agg tests (elastic#90114)
  Mute failing test (elastic#90186)
  Move assertion in ES85BloomFilterPostingsFormat to fix test (elastic#90150)
  Restrict nodes for testClusterPrimariesActive2 (elastic#90184)
  Batch index delete cluster state updates (elastic#90033)
  Register stable plugins in ActionModule (elastic#90067)
  Mute failing test (elastic#90180)
  [HealthAPI] Disk: Use _ for diagnosis id (elastic#90179)
  [HealtAPI] Disk: use shorter help URLs (elastic#90178)
  Fixing disk health indicator unit tests (elastic#90175)
  Enable the health node and the disk health indicator elastic#84811 (elastic#90085)
  Add missing Disk Indicator health api IDs (elastic#90174)
  ...
weizijun added a commit to weizijun/elasticsearch that referenced this pull request Sep 22, 2022
* main: (121 commits)
  [DOCS] Add 8.5 release notes and fix links (elastic#90201)
  Mute DownsampleActionSingleNodeTests.testCannotRollupWhileOtherRollupInProgress (elastic#90198)
  Bump to version 8.6.0
  Increase the minimum size of the management pool to 2 (elastic#90193)
  Speed `getIntLE` from `BytesReference` (elastic#90147)
  Restrict nodes for testClusterPrimariesActive1 (elastic#90191)
  Fix bug with `BigIntArray` serialization (elastic#90142)
  Synthetic _source: test _source filtering (elastic#90138)
  Modernize cardinality agg tests (elastic#90114)
  Mute failing test (elastic#90186)
  Move assertion in ES85BloomFilterPostingsFormat to fix test (elastic#90150)
  Restrict nodes for testClusterPrimariesActive2 (elastic#90184)
  Batch index delete cluster state updates (elastic#90033)
  Register stable plugins in ActionModule (elastic#90067)
  Mute failing test (elastic#90180)
  [HealthAPI] Disk: Use _ for diagnosis id (elastic#90179)
  [HealtAPI] Disk: use shorter help URLs (elastic#90178)
  Fixing disk health indicator unit tests (elastic#90175)
  Enable the health node and the disk health indicator elastic#84811 (elastic#90085)
  Add missing Disk Indicator health api IDs (elastic#90174)
  ...
@gmarouli gmarouli deleted the remove-feature-flag-84811 branch August 20, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Health Issues for the health report API >feature Team:Data Management (obsolete) DO NOT USE. This team no longer exists. v8.5.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants