Batch index delete cluster state updates#90033
Merged
original-brownbear merged 4 commits intoelastic:mainfrom Sep 21, 2022
original-brownbear:batch-index-deletes
Merged
Batch index delete cluster state updates#90033original-brownbear merged 4 commits intoelastic:mainfrom original-brownbear:batch-index-deletes
original-brownbear merged 4 commits intoelastic:mainfrom
original-brownbear:batch-index-deletes
Conversation
Batching these up in a straight-forward manner using the new infrastructure for batched CS updates. closes #90022
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
DaveCTurner
reviewed
Sep 20, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
#89192 should cut out some of this boilerplate; I left a couple of other comments too.
Comment on lines
-119
to
-120
| // Make sure we actually attempted to reroute | ||
| verify(allocationService).reroute(any(ClusterState.class), any(String.class)); |
Member
There was a problem hiding this comment.
Hm that's kind of important :) Although in practice it doesn't need to happen immediately, we could use the batched reroute service instead.
I suggest having at least one test that runs the executor tho, maybe using ClusterStateTaskExecutorUtils to avoid boilerplate.
Contributor
Author
There was a problem hiding this comment.
Ah thanks, reworked the test using that class now and brought back this assertion.
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataDeleteIndexService.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataDeleteIndexService.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks you two, applied your points and brought back the test now. |
DaveCTurner
requested changes
Sep 21, 2022
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
Actually sorry missed a thing: this deserves an entry in the release notes I think so not a >non-issue. I'll relabel it which should trigger the changelog creation.
Collaborator
|
Hi @original-brownbear, I've created a changelog YAML for you. |
Contributor
Author
|
Thanks both! |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 22, 2022
* main: (186 commits) [DOCS] Add 8.5 release notes and fix links (elastic#90201) Mute DownsampleActionSingleNodeTests.testCannotRollupWhileOtherRollupInProgress (elastic#90198) Bump to version 8.6.0 Increase the minimum size of the management pool to 2 (elastic#90193) Speed `getIntLE` from `BytesReference` (elastic#90147) Restrict nodes for testClusterPrimariesActive1 (elastic#90191) Fix bug with `BigIntArray` serialization (elastic#90142) Synthetic _source: test _source filtering (elastic#90138) Modernize cardinality agg tests (elastic#90114) Mute failing test (elastic#90186) Move assertion in ES85BloomFilterPostingsFormat to fix test (elastic#90150) Restrict nodes for testClusterPrimariesActive2 (elastic#90184) Batch index delete cluster state updates (elastic#90033) Register stable plugins in ActionModule (elastic#90067) Mute failing test (elastic#90180) [HealthAPI] Disk: Use _ for diagnosis id (elastic#90179) [HealtAPI] Disk: use shorter help URLs (elastic#90178) Fixing disk health indicator unit tests (elastic#90175) Enable the health node and the disk health indicator elastic#84811 (elastic#90085) Add missing Disk Indicator health api IDs (elastic#90174) ...
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 22, 2022
* main: (121 commits) [DOCS] Add 8.5 release notes and fix links (elastic#90201) Mute DownsampleActionSingleNodeTests.testCannotRollupWhileOtherRollupInProgress (elastic#90198) Bump to version 8.6.0 Increase the minimum size of the management pool to 2 (elastic#90193) Speed `getIntLE` from `BytesReference` (elastic#90147) Restrict nodes for testClusterPrimariesActive1 (elastic#90191) Fix bug with `BigIntArray` serialization (elastic#90142) Synthetic _source: test _source filtering (elastic#90138) Modernize cardinality agg tests (elastic#90114) Mute failing test (elastic#90186) Move assertion in ES85BloomFilterPostingsFormat to fix test (elastic#90150) Restrict nodes for testClusterPrimariesActive2 (elastic#90184) Batch index delete cluster state updates (elastic#90033) Register stable plugins in ActionModule (elastic#90067) Mute failing test (elastic#90180) [HealthAPI] Disk: Use _ for diagnosis id (elastic#90179) [HealtAPI] Disk: use shorter help URLs (elastic#90178) Fixing disk health indicator unit tests (elastic#90175) Enable the health node and the disk health indicator elastic#84811 (elastic#90085) Add missing Disk Indicator health api IDs (elastic#90174) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batching these up in a straight-forward manner using the new infrastructure for batched CS updates.
Mainly just me wanting to try and use the new batching API once to see if I get it right :)
closes #90022