Skip to content

ML: Fix testMigrateConfigs #37373

Merged
benwtrent merged 4 commits intoelastic:masterfrom
benwtrent:fix/ml-fix-testMigrateConfigs
Jan 11, 2019
Merged

ML: Fix testMigrateConfigs #37373
benwtrent merged 4 commits intoelastic:masterfrom
benwtrent:fix/ml-fix-testMigrateConfigs

Conversation

@benwtrent
Copy link
Copy Markdown
Member

@benwtrent benwtrent commented Jan 11, 2019

Index refresh request was called with an execute, which returns a future.

should be a get so it is called synchronously.

closes #37374

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests v7.0.0 :ml Machine learning v6.7.0 labels Jan 11, 2019
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core

Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195
Copy link
Copy Markdown

I removed the v6.7.0 label because you can make the change in #37372 for the 6.x branch

@benwtrent
Copy link
Copy Markdown
Member Author

run the gradle build tests 1

@benwtrent benwtrent merged commit 5101e51 into elastic:master Jan 11, 2019
@benwtrent benwtrent deleted the fix/ml-fix-testMigrateConfigs branch January 11, 2019 19:29
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 12, 2019
…rsistence

* elastic/master:
  Fix PrimaryAllocationIT Race Condition (elastic#37355)
  SQL: Make `FULL` non-reserved keyword in the grammar (elastic#37377)
  SQL: [Tests] Fix and enable internalClusterTests (elastic#37300)
  ML: Fix testMigrateConfigs  (elastic#37373)
  Fix RollupDocumentation test to wait for job to stop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.0.0-beta1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] MlConfigMigratorIT.testMigrateConfigs fails occasionally.

4 participants