SQL: Make FULL non-reserved keyword in the grammar#37377
Merged
matriv merged 1 commit intoelastic:masterfrom Jan 11, 2019
Merged
SQL: Make FULL non-reserved keyword in the grammar#37377matriv merged 1 commit intoelastic:masterfrom
FULL non-reserved keyword in the grammar#37377matriv merged 1 commit intoelastic:masterfrom
Conversation
Since `full` can be common as a field name or part of a field name (e.g.: `full.name` or `name.full`), it's nice if it's not a reserved keyword of the grammar so a user can use it without resorting to quotes. Fixes: elastic#37376
Collaborator
|
Pinging @elastic/es-search |
Contributor
Author
|
@costin do you think we should backport it to earlier version too? |
costin
approved these changes
Jan 11, 2019
Member
costin
left a comment
There was a problem hiding this comment.
LGTM - and the test is a good asset.
Let's back port this to 6.6.x as well
Contributor
Author
|
Backported to |
matriv
added a commit
that referenced
this pull request
Jan 11, 2019
Contributor
Author
|
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 12, 2019
…rsistence * elastic/master: Fix PrimaryAllocationIT Race Condition (elastic#37355) SQL: Make `FULL` non-reserved keyword in the grammar (elastic#37377) SQL: [Tests] Fix and enable internalClusterTests (elastic#37300) ML: Fix testMigrateConfigs (elastic#37373) Fix RollupDocumentation test to wait for job to stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
fullcan be common as a field name or part of a field name(e.g.:
full.nameorname.full), it's nice if it's not a reservedkeyword of the grammar so a user can use it without resorting to quotes.
Fixes: #37376