SQL: [Tests] Fix and enable internalClusterTests#37300
Merged
matriv merged 10 commits intoelastic:masterfrom Jan 11, 2019
Merged
SQL: [Tests] Fix and enable internalClusterTests#37300matriv merged 10 commits intoelastic:masterfrom
matriv merged 10 commits intoelastic:masterfrom
Conversation
Partially fixes: elastic#37191
Collaborator
|
Pinging @elastic/es-search |
astefan
reviewed
Jan 10, 2019
|
|
||
| import java.nio.file.Path; | ||
|
|
||
| public class LocalStateSQLXpackPlugin extends LocalStateCompositeXPackPlugin { |
Contributor
There was a problem hiding this comment.
Does it have to be public? Also, I think the naming around xpack should be XPack (capital P).
Contributor
Author
There was a problem hiding this comment.
no, can be package private, thx!
Contributor
Author
There was a problem hiding this comment.
Actually, it needs to be public:
> Throwable #1: java.lang.IllegalStateException: no public constructor for [org.elasticsearch.xpack.sql.action.LocalStateSQLXPackPlugin]
> at org.elasticsearch.plugins.PluginsService.loadPlugin(PluginsService.java:590)
> at org.elasticsearch.plugins.PluginsService.<init>(PluginsService.java:119)
> at org.elasticsearch.node.Node.<init>(Node.java:303)
Contributor
Author
|
run default distro tests |
Contributor
Author
|
run gradle build tests 2 |
Contributor
Author
|
run default distro tests |
Contributor
Author
|
run gradle build tests 2 |
Contributor
Author
|
Seems that the changes affect the |
SqlPlugin cannot have more than one constructor, so for the testing purposes one should set a dummy `sqlLicenseChecker` instead.
Contributor
Author
Contributor
Author
|
@astefan Maybe you want to also take another look here. |
Contributor
Author
|
run gradle build tests 2 |
Contributor
Author
|
run gradle build tests 1 |
Contributor
|
@matriv still LGTM |
matriv
added a commit
that referenced
this pull request
Jan 11, 2019
SqlPlugin cannot have more than one public constructor, so for the testing purposes the `getLicenseState()` should be overriden. Fixes: #37191 Co-authored-by: Michael Basnight <mbasnight@gmail.com>
Contributor
Author
|
Backported to |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Jan 12, 2019
…rsistence * elastic/master: Fix PrimaryAllocationIT Race Condition (elastic#37355) SQL: Make `FULL` non-reserved keyword in the grammar (elastic#37377) SQL: [Tests] Fix and enable internalClusterTests (elastic#37300) ML: Fix testMigrateConfigs (elastic#37373) Fix RollupDocumentation test to wait for job to stop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #37191