ML: update .ml-state actions to support > 1 index #37307 #37372
Merged
benwtrent merged 4 commits intoelastic:6.xfrom Jan 14, 2019
Merged
ML: update .ml-state actions to support > 1 index #37307 #37372benwtrent merged 4 commits intoelastic:6.xfrom
benwtrent merged 4 commits intoelastic:6.xfrom
Conversation
* ML: Updating .ml-state calls to be able to support > 1 index * Matching bulk delete behavior with dbq * Adjusting state name * refreshing indices before search * fixing line length * adjusting index expansion options
Collaborator
|
Pinging @elastic/ml-core |
benwtrent
commented
Jan 11, 2019
| indices.add(stateIndexName); | ||
| for (ModelSnapshot modelSnapshot : modelSnapshots) { | ||
| idsToDelete.addAll(modelSnapshot.stateDocumentIds()); | ||
| idsToDelete.addAll(modelSnapshot.legacyStateDocumentIds()); |
Member
Author
There was a problem hiding this comment.
Simply referring to the legacy docs in this query works as the DBQ request does not reference a type, so it searches across all types. Additionally, there should not be any fear of IDs conflicting from what I found the two IDs that would conflict would be jobId + "-" + quantiles and jobId + "-" + snapshotId.
This would only be if the snapshotId == "quantiles" which is very improbable if not impossible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #37307