Tests: Add checks to GeoDistanceQueryBuilderTests#34273
Merged
imotov merged 3 commits intoelastic:masterfrom Oct 23, 2018
Merged
Tests: Add checks to GeoDistanceQueryBuilderTests#34273imotov merged 3 commits intoelastic:masterfrom
imotov merged 3 commits intoelastic:masterfrom
Conversation
Adds checks for parsed geo distance query. It is a bit hackish since it compares with query's toString() output, but it is better than no checks. The parsed query itself has default visibility, so we cannot access it here unless we move the test to org.apache.lucene.document package. Fixes elastic#34043
Collaborator
|
Pinging @elastic/es-search-aggs |
cbuescher
requested changes
Oct 17, 2018
Member
cbuescher
left a comment
There was a problem hiding this comment.
The change looks good, but I was wondering if there is a way to avoid the "toString" comparison. Could you comment if you think my suggestion works or if you disagree?
server/src/test/java/org/elasticsearch/index/query/GeoDistanceQueryBuilderTests.java
Show resolved
Hide resolved
Contributor
Author
|
retest this please |
imotov
added a commit
that referenced
this pull request
Oct 23, 2018
Adds checks for parsed geo distance query. It is a bit hack-ish since it compares with query's toString() output, but it is better than no checks. The parsed query itself has default visibility, so we cannot access it here unless we move the test to org.apache.lucene.document package. Fixes #34043
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 23, 2018
* master: (24 commits) ingest: better support for conditionals with simulate?verbose (elastic#34155) [Rollup] Job deletion should be invoked on the allocated task (elastic#34574) [DOCS] .Security index is never auto created (elastic#34589) CCR: Requires soft-deletes on the follower (elastic#34725) re-enable bwc tests (elastic#34743) Empty GetAliases authorization fix (elastic#34444) INGEST: Document Processor Conditional (elastic#33388) [CCR] Add total fetch time leader stat (elastic#34577) SQL: Support pattern against compatible indices (elastic#34718) [CCR] Auto follow pattern APIs adjustments (elastic#34518) [Test] Remove dead code from ExceptionSerializationTests (elastic#34713) A small typo in migration-assistance doc (elastic#34704) ingest: processor stats (elastic#34724) SQL: Implement IN(value1, value2, ...) expression. (elastic#34581) Tests: Add checks to GeoDistanceQueryBuilderTests (elastic#34273) INGEST: Rename Pipeline Processor Param. (elastic#34733) Core: Move IndexNameExpressionResolver to java time (elastic#34507) [DOCS] Force Merge: clarify execution and storage requirements (elastic#33882) TESTING.asciidoc fix examples using forbidden annotation (elastic#34515) SQL: Implement `CONVERT`, an alternative to `CAST` (elastic#34660) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
Adds checks for parsed geo distance query. It is a bit hack-ish since it compares with query's toString() output, but it is better than no checks. The parsed query itself has default visibility, so we cannot access it here unless we move the test to org.apache.lucene.document package. Fixes #34043
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds checks for parsed geo distance query. It is a bit hackish since it
compares with query's toString() output, but it is better than no
checks. The parsed query itself has default visibility, so we cannot
access it here unless we move the test to org.apache.lucene.document
package.
Fixes #34043