[CCR] Auto follow pattern APIs adjustments#34518
Merged
martijnvg merged 7 commits intoelastic:masterfrom Oct 23, 2018
Merged
Conversation
…name instead of being the leader cluster alias name.
Collaborator
|
Pinging @elastic/es-distributed |
Member
Author
|
run gradle build tests |
bleskes
reviewed
Oct 17, 2018
| if (randomBoolean()) { | ||
| putAutoFollowPatterns("my-pattern", new String[] {"logs-*", "transactions-*"}); | ||
| } else { | ||
| putAutoFollowPatterns("my-pattern1", new String[] {"logs-*"}); |
| } | ||
|
|
||
| private void putAutoFollowPatterns(String... patterns) { | ||
| public void testConflictingPatterns() throws Exception { |
Contributor
There was a problem hiding this comment.
if two patterns match an index, why is that a problem? we used to be able to do it before no?
Member
Author
There was a problem hiding this comment.
So only one auto follow pattern would trigger the index following and when applying the second one would result in an error (same follow index already exists in follow cluster). Also which auto follow pattern gets applied first is undefined.
Contributor
There was a problem hiding this comment.
I looked at it more and I realized I got confused - with the new model we can still specify multiple patterns in a single auto follow config (is this a better name?). All good. Thanks for explaining.
Member
Author
There was a problem hiding this comment.
with the new model we can still specify multiple patterns in a single auto follow config (is this a better name?)
Yes, we can still do that.
martijnvg
added a commit
that referenced
this pull request
Oct 23, 2018
* Changed the resource id of auto follow patterns to be a user defined name instead of being the leader cluster alias name. * Fail when an unfollowed leader index matches with two or more auto follow patterns.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Oct 23, 2018
* master: (24 commits) ingest: better support for conditionals with simulate?verbose (elastic#34155) [Rollup] Job deletion should be invoked on the allocated task (elastic#34574) [DOCS] .Security index is never auto created (elastic#34589) CCR: Requires soft-deletes on the follower (elastic#34725) re-enable bwc tests (elastic#34743) Empty GetAliases authorization fix (elastic#34444) INGEST: Document Processor Conditional (elastic#33388) [CCR] Add total fetch time leader stat (elastic#34577) SQL: Support pattern against compatible indices (elastic#34718) [CCR] Auto follow pattern APIs adjustments (elastic#34518) [Test] Remove dead code from ExceptionSerializationTests (elastic#34713) A small typo in migration-assistance doc (elastic#34704) ingest: processor stats (elastic#34724) SQL: Implement IN(value1, value2, ...) expression. (elastic#34581) Tests: Add checks to GeoDistanceQueryBuilderTests (elastic#34273) INGEST: Rename Pipeline Processor Param. (elastic#34733) Core: Move IndexNameExpressionResolver to java time (elastic#34507) [DOCS] Force Merge: clarify execution and storage requirements (elastic#33882) TESTING.asciidoc fix examples using forbidden annotation (elastic#34515) SQL: Implement `CONVERT`, an alternative to `CAST` (elastic#34660) ...
kcm
pushed a commit
that referenced
this pull request
Oct 30, 2018
* Changed the resource id of auto follow patterns to be a user defined name instead of being the leader cluster alias name. * Fail when an unfollowed leader index matches with two or more auto follow patterns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.